qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 00/17] Block patches
Date: Tue, 7 Jul 2015 14:47:50 +0100	[thread overview]
Message-ID: <CAFEAcA_0zCed0XKYY5KM9wYQeqO_YL6GZFTzxFLrpBY2Xnui2Q@mail.gmail.com> (raw)
In-Reply-To: <1435828789-9647-1-git-send-email-stefanha@redhat.com>

On 2 July 2015 at 10:19, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> The following changes since commit d2966f804d70a244f5dde395fc5d22a50ed3e74e:
>
>   Merge remote-tracking branch 'remotes/vivier/tags/pull-m68k-20150629' into staging (2015-06-29 17:03:20 +0100)
>
> are available in the git repository at:
>
>   git://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 764ba3ae511adddfa750db290ac8375d660ca5b9:
>
>   block: remove redundant check before g_slist_find() (2015-07-02 10:06:23 +0100)
>
> ----------------------------------------------------------------
>
> ----------------------------------------------------------------
>
> Alberto Garcia (3):
>   timer: Move NANOSECONDS_PER_SECONDS to timer.h
>   timer: Use a single definition of NSEC_PER_SEC for the whole codebase

I've just noticed that this clashes with the OSX standard
headers:

In file included from /Users/pm215/src/qemu/ui/cocoa.m:31:
In file included from /Users/pm215/src/qemu/include/sysemu/sysemu.h:8:
/Users/pm215/src/qemu/include/qemu/timer.h:8:9: warning:
'NSEC_PER_SEC' macro redefined [-Wmacro-redefined]
#define NSEC_PER_SEC 1000000000LL
        ^
/usr/include/dispatch/time.h:48:9: note: previous definition is here
#define NSEC_PER_SEC 1000000000ull

Can we use some other constant name, please?

thanks
-- PMM

  parent reply	other threads:[~2015-07-07 13:48 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02  9:19 [Qemu-devel] [PULL 00/17] Block patches Stefan Hajnoczi
2015-07-02  9:19 ` [Qemu-devel] [PULL 01/17] block/iscsi: add support for request timeouts Stefan Hajnoczi
2015-07-02  9:19 ` [Qemu-devel] [PULL 02/17] qcow2: Handle EAGAIN returned from update_refcount Stefan Hajnoczi
2015-07-02  9:19 ` [Qemu-devel] [PULL 03/17] qapi: Rename 'dirty-bitmap' mode to 'incremental' Stefan Hajnoczi
2015-07-02  9:19 ` [Qemu-devel] [PULL 04/17] blockdev: no need to drain+flush in hmp_drive_del Stefan Hajnoczi
2015-07-02  9:19 ` [Qemu-devel] [PULL 05/17] timer: Move NANOSECONDS_PER_SECONDS to timer.h Stefan Hajnoczi
2015-07-02  9:19 ` [Qemu-devel] [PULL 06/17] timer: Use a single definition of NSEC_PER_SEC for the whole codebase Stefan Hajnoczi
2015-07-02  9:19 ` [Qemu-devel] [PULL 07/17] block: Add bdrv_get_block_status_above Stefan Hajnoczi
2015-07-02  9:19 ` [Qemu-devel] [PULL 08/17] qmp: Add optional bool "unmap" to drive-mirror Stefan Hajnoczi
2015-07-02  9:19 ` [Qemu-devel] [PULL 09/17] mirror: Do zero write on target if sectors not allocated Stefan Hajnoczi
2015-07-02  9:19 ` [Qemu-devel] [PULL 10/17] block: Fix dirty bitmap in bdrv_co_discard Stefan Hajnoczi
2015-07-02  9:19 ` [Qemu-devel] [PULL 11/17] block: Remove bdrv_reset_dirty Stefan Hajnoczi
2015-07-02  9:19 ` [Qemu-devel] [PULL 12/17] qemu-iotests: Make block job methods common Stefan Hajnoczi
2015-07-02  9:19 ` [Qemu-devel] [PULL 13/17] qemu-iotests: Add test case for mirror with unmap Stefan Hajnoczi
2015-07-02  9:19 ` [Qemu-devel] [PULL 14/17] iotests: Use event_wait in wait_ready Stefan Hajnoczi
2015-07-02  9:19 ` [Qemu-devel] [PULL 15/17] block/iscsi: restore compatiblity with libiscsi 1.9.0 Stefan Hajnoczi
2015-07-02  9:19 ` [Qemu-devel] [PULL 16/17] block/nfs: limit maximum readahead size to 1MB Stefan Hajnoczi
2015-07-02  9:19 ` [Qemu-devel] [PULL 17/17] block: remove redundant check before g_slist_find() Stefan Hajnoczi
2015-07-02 12:46 ` [Qemu-devel] [PULL 00/17] Block patches Peter Maydell
2015-07-07 13:47 ` Peter Maydell [this message]
2015-07-08 13:52   ` Stefan Hajnoczi
  -- strict thread matches above, loose matches on Subject: below --
2019-08-19 16:17 Max Reitz
2019-08-20 12:40 ` Peter Maydell
2016-09-12 14:08 Stefan Hajnoczi
2016-09-12 15:12 ` Peter Maydell
2016-09-12 15:56   ` Peter Maydell
2016-09-13  1:11     ` Fam Zheng
2016-09-13  8:34       ` Stefan Hajnoczi
2016-09-13  8:53     ` Stefan Hajnoczi
2016-01-20 16:24 Kevin Wolf
2016-01-21 13:42 ` Peter Maydell
2015-06-05 11:57 Stefan Hajnoczi
2015-06-05 13:53 ` Peter Maydell
2014-06-02 13:56 Kevin Wolf
2014-06-02 14:46 ` Peter Maydell
2014-05-09 19:03 Stefan Hajnoczi
2014-05-13 10:32 ` Peter Maydell
2013-10-29 16:30 Kevin Wolf
2010-07-06 15:33 Kevin Wolf
2010-07-06 19:07 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA_0zCed0XKYY5KM9wYQeqO_YL6GZFTzxFLrpBY2Xnui2Q@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).