From: Peter Maydell <peter.maydell@linaro.org>
To: John Snow <jsnow@redhat.com>
Cc: Stefan Fritsch <sf@sfritsch.de>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 2/3] ahci: Force ICC bits in PxCMD to zero
Date: Tue, 21 Jul 2015 12:38:00 +0100 [thread overview]
Message-ID: <CAFEAcA_7OKrZexyoAFc3Jhiib=Syf3UUKPYGNxdPmQO_wm-vMQ@mail.gmail.com> (raw)
In-Reply-To: <1437416961-26348-3-git-send-email-jsnow@redhat.com>
On 20 July 2015 at 19:29, John Snow <jsnow@redhat.com> wrote:
> From: Stefan Fritsch <sf@sfritsch.de>
>
> The AHCI spec requires that the HBA sets the ICC bits to zero after the
> ICC change is done. Since we don't do any ICC change, force the bits to
> zero all the time.
>
> This fixes delays with some OSs (e.g. OpenBSD) waiting for the ICC bits
> to change to 0.
This change provokes a lot of clang sanitizer warnings:
/home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:288:49: runtime
error: left shift of 15 by 28 places cannot be represented in type
'int'
PORT_CMD_ICC_MASK is defined as
#define PORT_CMD_ICC_MASK (0xf << 28) /* i/f ICC state mask */
which shifts into the sign bit of a signed integer.
thanks
-- PMM
next prev parent reply other threads:[~2015-07-21 11:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 18:29 [Qemu-devel] [PULL 0/3] Ide patches John Snow
2015-07-20 18:29 ` [Qemu-devel] [PULL 1/3] qtest/ide: add another short PRDT test flavor John Snow
2015-07-20 18:29 ` [Qemu-devel] [PULL 2/3] ahci: Force ICC bits in PxCMD to zero John Snow
2015-07-21 11:38 ` Peter Maydell [this message]
2015-07-21 12:55 ` Eric Blake
2015-07-21 13:02 ` Peter Maydell
2015-07-21 17:41 ` John Snow
2015-07-20 18:29 ` [Qemu-devel] [PULL 3/3] tests: Fix broken targets check-report-qtest-* John Snow
2015-07-21 10:18 ` [Qemu-devel] [PULL 0/3] Ide patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_7OKrZexyoAFc3Jhiib=Syf3UUKPYGNxdPmQO_wm-vMQ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sf@sfritsch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).