From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12DD1C433ED for ; Wed, 12 May 2021 15:23:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80F6961C9A for ; Wed, 12 May 2021 15:23:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80F6961C9A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39516 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgqi0-0000Ro-5h for qemu-devel@archiver.kernel.org; Wed, 12 May 2021 11:23:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgqg8-0007Ar-Cl for qemu-devel@nongnu.org; Wed, 12 May 2021 11:21:40 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]:34581) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgqg6-0002T7-Ra for qemu-devel@nongnu.org; Wed, 12 May 2021 11:21:40 -0400 Received: by mail-ej1-x62c.google.com with SMTP id a4so35602042ejk.1 for ; Wed, 12 May 2021 08:21:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yQzqJujMg8+OBARjbP9X4fTPf7LBFaB4n42rLPvtzHA=; b=tlnNykyHPpAE4NIfWe9+1DBQA2kReTfoeDRRw6G1O/wUu9B30YMj0NQpO/C/4yqn3S kYPGSlmNAA0QmGaMsuInygtlOHRAdnwOeuxZxcmSKJqrO/vorymnFMXAA7joGED1XqTY QjHuaAPHKuRkCCCjrG0l/XHzeRUCZwDAL3iZAAXn8MixCb9t9SyMIEWIPp6vMVCVPTXv SijJ7s6XQdr5UTUn/P9wlySK/n4bW/cKiwU/lxUqoIi7Hz9UHW/ByJbKkyLNMX+NAjxK e1zDdTRqkVhI95H2l+dUGSJKvwa6dyR2xWd+7f1IuPqOTdHpZyH7o2os7IIzeR2VVTOU GMUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yQzqJujMg8+OBARjbP9X4fTPf7LBFaB4n42rLPvtzHA=; b=h8IDmzuvaexiwrAE0amFp640+lbulYH0G1+v8XVMgoCAKGMpWk260H7WmBhK3fXvVa dzSlr1pwg1M5UDWDgD2Uy2XQLsKJF+gd8NdMUgEWjIkmZfgTJbgKp8XJZVZJ9YeFkA8F AG/t2NvpP8l4ajyt2EiuFyD5OADHEUVt9R87JVtDPV+SEJP3HfCYdJismdVo+Qd0SRaq 89t1VlqoXSlaQA6vWtb0f/ITYGoBAMVg58jwyaBGgqvzPVr4RgYL9VnLLbSkFDeoRoj1 fCcthrWYBOThssXN2TVSo5F61HcDg2vc2UCpka5bXlwUSKoLmnSbbV5iPwrzpeZxF8B1 Go5Q== X-Gm-Message-State: AOAM530FyJz6EZ+gsBisvk5rRiQOCbi2sgVY6p8phbOSezJ9dvyM1Fmf VVlo41nSDP+INBlSoQxwh/gWeiu/ycHQs8o9fRw+sg== X-Google-Smtp-Source: ABdhPJzI6V57/9wXuR1v7S3Hpt/FrnkY0vFORgPDOMOPunuryzvgVdPhT0Pd4ukWLim6mrWGDq5yNj7SM1DEeuXpYp4= X-Received: by 2002:a17:906:eced:: with SMTP id qt13mr37868587ejb.382.1620832897492; Wed, 12 May 2021 08:21:37 -0700 (PDT) MIME-Version: 1.0 References: <20210430202610.1136687-1-richard.henderson@linaro.org> <20210430202610.1136687-38-richard.henderson@linaro.org> In-Reply-To: <20210430202610.1136687-38-richard.henderson@linaro.org> From: Peter Maydell Date: Wed, 12 May 2021 16:20:23 +0100 Message-ID: Subject: Re: [PATCH v6 37/82] target/arm: Implement SVE2 complex integer multiply-add To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 30 Apr 2021 at 22:00, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v2: Fix do_sqrdmlah_d (laurent desnogues) > --- > @@ -1448,6 +1448,48 @@ DO_SQDMLAL(sve2_sqdmlsl_zzzw_d, int64_t, int32_t, , H1_4, > > #undef DO_SQDMLAL > > +#define DO_CMLA(NAME, TYPE, H, OP) \ > +void HELPER(NAME)(void *vd, void *vn, void *vm, void *va, uint32_t desc) \ > +{ \ > + intptr_t i, opr_sz = simd_oprsz(desc) / sizeof(TYPE); \ > + int rot = simd_data(desc); \ > + int sel_a = rot & 1, sel_b = sel_a ^ 1; \ > + bool sub_r = rot == 1 || rot == 2; \ > + bool sub_i = rot >= 2; \ > + TYPE *d = vd, *n = vn, *m = vm, *a = va; \ > + for (i = 0; i < opr_sz; i += 2) { \ > + TYPE elt1_a = n[H(i + sel_a)]; \ > + TYPE elt2_a = m[H(i + sel_a)]; \ > + TYPE elt2_b = m[H(i + sel_b)]; \ > + d[H(i)] = OP(elt1_a, elt2_a, a[H(i)], sub_r); \ > + d[H(i + 1)] = OP(elt1_a, elt2_b, a[H(i + 1)], sub_i); \ > + } \ > +} > + > +#define do_cmla(N, M, A, S) (A + (N * M) * (S ? -1 : 1)) Could we rename this just so it's not different-in-case-only to the other macro ? Otherwise Reviewed-by: Peter Maydell thanks -- PMM