From: Peter Maydell <peter.maydell@linaro.org>
To: "ishii.shuuichir@fujitsu.com" <ishii.shuuichir@fujitsu.com>
Cc: qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2 0/3] Add support for Fujitsu A64FX processor
Date: Tue, 3 Aug 2021 10:03:16 +0100 [thread overview]
Message-ID: <CAFEAcA_VS9MfZM2NumtScxk_8mXtF=D_-YPsb+tt_acO3r3U7w@mail.gmail.com> (raw)
In-Reply-To: <TYCPR01MB616096BA80EBBA7FFA10A119E9F09@TYCPR01MB6160.jpnprd01.prod.outlook.com>
On Tue, 3 Aug 2021 at 01:37, ishii.shuuichir@fujitsu.com
<ishii.shuuichir@fujitsu.com> wrote:
>
> > I'm afraid this isn't the way a v2 patchseries should be structured.
> > The idea is that a v2 series should be complete in itself, not based on whatever v1
> > was. So when you make the changes requested in review of v1, you update the
> > commits in your local git branch, and then you send out the patches as the v2. v2
> > should apply cleanly on to master, and all the patches in it should be logically
> > separated out changes (with no "patch 1 makes a change and then patch 2
> > changes the code that was added in patch 1" effects).
>
> Thank you for comments.
> We apologize for the inconvenience caused by our lack of understanding.
> I understood your point.
>
> Just to confirm,
> should I update to v3 and resubmit it as a patch series based on the points you mentioned?
Yes, please.
thanks
-- PMM
next prev parent reply other threads:[~2021-08-03 9:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 3:08 [PATCH v2 0/3] Add support for Fujitsu A64FX processor Shuuichirou Ishii
2021-07-30 3:08 ` [PATCH v2 1/3] target-arm: delete ARM_FEATURE_A64FX Shuuichirou Ishii
2021-07-30 10:34 ` Peter Maydell
2021-08-03 0:23 ` ishii.shuuichir
2021-07-30 10:36 ` Alex Bennée
2021-08-03 0:32 ` ishii.shuuichir
2021-07-30 3:08 ` [PATCH v2 2/3] target-arm: cpu64: Add support for Fujitsu A64FX Shuuichirou Ishii
2021-07-30 3:08 ` [PATCH v2 3/3] target-arm: Add A64FX processor support to virt machine Shuuichirou Ishii
2021-07-30 10:36 ` Peter Maydell
2021-08-03 0:21 ` ishii.shuuichir
2021-07-30 10:38 ` [PATCH v2 0/3] Add support for Fujitsu A64FX processor Peter Maydell
2021-08-03 0:36 ` ishii.shuuichir
2021-08-03 9:03 ` Peter Maydell [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-07-30 1:40 Shuuichirou Ishii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_VS9MfZM2NumtScxk_8mXtF=D_-YPsb+tt_acO3r3U7w@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=ishii.shuuichir@fujitsu.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).