From: Peter Maydell <peter.maydell@linaro.org>
To: Leif Lindholm <leif@nuviainc.com>
Cc: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] arm: bump amount of PMU counters to pass SBSA ACS
Date: Thu, 11 Mar 2021 17:02:09 +0000 [thread overview]
Message-ID: <CAFEAcA_Wu3nQ1vLa6YhCfLmPfaGHYkyuw90RU5sa8mBs6me=sw@mail.gmail.com> (raw)
In-Reply-To: <20210304152512.GJ1664@vanye>
On Thu, 4 Mar 2021 at 15:25, Leif Lindholm <leif@nuviainc.com> wrote:
>
> On Thu, Mar 04, 2021 at 15:14:36 +0000, Peter Maydell wrote:
> > On Thu, 4 Mar 2021 at 13:53, Leif Lindholm <leif@nuviainc.com> wrote:
> > >
> > > On Wed, Mar 03, 2021 at 18:06:46 +0000, Peter Maydell wrote:
> > > > On Wed, 3 Mar 2021 at 17:48, Leif Lindholm <leif@nuviainc.com> wrote:
> > > > > It would be good if we could get 6.0 closer to SBSA compliance.
> > > >
> > > > How far away are we at the moment ?
> > > >
> > > > > Would it be worth the effort to make this controllable per cpu model?
> > > >
> > > > I don't have a strong opinion on whether we should, but if we do then the
> > > > right way to implement that would be to have the PMCR reset value
> > > > as a reset_pmcr_el0 field in struct ARMCPU (like the existing reset_fpsid,
> > > > reset_sctlr, etc) that gets set per-CPU to whatever the CPU's value for
> > > > it is; and then instead of using a PMCR_NUM_COUNTERS value,
> > > > extract the PMCR.N field when needed. The hardest part would be
> > > > going through all the CPU TRMs to find out the correct reset value.
> > >
> > > That makes sense.
> I'll throw this on my never-shrinking pile of things I hope to get
> around to at some point.
I just sent a patch that does it that way, though it is desperately
in need of more testing. I'm currently on the fence about whether to
put this patch or that one in for 6.0.
thanks
-- PMM
prev parent reply other threads:[~2021-03-11 17:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 15:16 [PATCH] arm: bump amount of PMU counters to pass SBSA ACS Marcin Juszkiewicz
2021-03-03 17:48 ` Leif Lindholm
2021-03-03 18:06 ` Peter Maydell
2021-03-03 20:33 ` Marcin Juszkiewicz
2021-03-04 13:53 ` Leif Lindholm
2021-03-04 15:14 ` Peter Maydell
2021-03-04 15:25 ` Leif Lindholm
2021-03-11 17:02 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_Wu3nQ1vLa6YhCfLmPfaGHYkyuw90RU5sa8mBs6me=sw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=leif@nuviainc.com \
--cc=marcin.juszkiewicz@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).