From: Peter Maydell <peter.maydell@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH 7/8] memory.h: Silence kernel-doc complaints
Date: Mon, 2 Dec 2019 18:04:31 +0000 [thread overview]
Message-ID: <CAFEAcA_Y-8truVZkwHMULUwMkt01UwaCv62pgiKM2i=tskH6bw@mail.gmail.com> (raw)
In-Reply-To: <20191129140217.17797-8-pbonzini@redhat.com>
On Fri, 29 Nov 2019 at 14:02, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Fix a few instances where kernel-doc complains about doc comments
> in memory.h.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> include/exec/memory.h | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/include/exec/memory.h b/include/exec/memory.h
> index e499dc215b..1e875996ec 100644
> --- a/include/exec/memory.h
> +++ b/include/exec/memory.h
> @@ -360,10 +360,14 @@ typedef struct IOMMUMemoryRegionClass {
> typedef struct CoalescedMemoryRange CoalescedMemoryRange;
> typedef struct MemoryRegionIoeventfd MemoryRegionIoeventfd;
>
> +/** MemoryRegion:
Checkpatch thinks there should be a newline after the /**.
> + *
> + * A struct representing a memory region.
> + */
> struct MemoryRegion {
> Object parent_obj;
>
> - /* All fields are private - violators will be prosecuted */
> + /* private: */
>
> /* The following fields should fit in a cache line */
> bool romd_mode;
> @@ -452,7 +456,7 @@ struct MemoryListener {
> * AddressSpace: describes a mapping of addresses to #MemoryRegion objects
> */
> struct AddressSpace {
> - /* All fields are private. */
> + /* private: */
> struct rcu_head rcu;
> char *name;
> MemoryRegion *root;
> @@ -1673,8 +1677,8 @@ bool memory_region_is_mapped(MemoryRegion *mr);
> *
> * Returns a #MemoryRegionSection that describes a contiguous overlap.
> * It will have the following characteristics:
> - * .@size = 0 iff no overlap was found
> - * .@mr is non-%NULL iff an overlap was found
> + * - @size = 0 iff no overlap was found
> + * - @mr is non-%NULL iff an overlap was found
> *
> * Remember that in the return value the @offset_within_region is
> * relative to the returned region (in the .@mr field), not to the
> @@ -1685,8 +1689,8 @@ bool memory_region_is_mapped(MemoryRegion *mr);
> * returned one. However, in the special case where the @mr argument
> * has no container (and thus is the root of the address space), the
> * following will hold:
> - * .@offset_within_address_space >= @addr
> - * .@offset_within_address_space + .@size <= @addr + @size
> + * - @offset_within_address_space >= @addr
> + * - @offset_within_address_space + .@size <= @addr + @size
> *
> * @mr: a MemoryRegion within which @addr is a relative address
> * @addr: start of the area within @as to be searched
> --
> 2.21.0
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2019-12-02 18:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 14:02 [PATCH for-5.0 0/8] docs: integrate doc comments with Sphinx build Paolo Bonzini
2019-11-29 14:02 ` [PATCH 1/8] docs: import Linux kernel-doc script and extension Paolo Bonzini
2019-12-02 17:50 ` Peter Maydell
2019-11-29 14:02 ` [PATCH 2/8] docs: tweak kernel-doc for QEMU coding standards Paolo Bonzini
2019-12-02 18:01 ` Peter Maydell
2019-12-02 18:17 ` Paolo Bonzini
2020-10-02 18:34 ` Eduardo Habkost
2020-10-02 18:43 ` Peter Maydell
2020-10-02 18:46 ` Eduardo Habkost
2020-10-02 18:50 ` Paolo Bonzini
2020-10-02 19:18 ` Eduardo Habkost
2019-11-29 14:02 ` [PATCH 3/8] docs/conf.py: Enable use of kerneldoc sphinx extension Paolo Bonzini
2019-11-29 14:02 ` [PATCH 4/8] Makefile: disable Sphinx nitpicking Paolo Bonzini
2019-11-29 14:02 ` [PATCH 5/8] bitops.h: Silence kernel-doc complaints Paolo Bonzini
2019-11-29 14:02 ` [PATCH 6/8] docs: Create bitops.rst as example of kernel-docs Paolo Bonzini
2019-11-29 14:02 ` [PATCH 7/8] memory.h: Silence kernel-doc complaints Paolo Bonzini
2019-12-02 18:04 ` Peter Maydell [this message]
2019-11-29 14:02 ` [PATCH 8/8] docs: add memory API reference Paolo Bonzini
2019-12-02 18:05 ` Peter Maydell
2019-11-30 1:54 ` [PATCH for-5.0 0/8] docs: integrate doc comments with Sphinx build no-reply
2019-12-02 18:06 ` Peter Maydell
2019-12-02 18:13 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_Y-8truVZkwHMULUwMkt01UwaCv62pgiKM2i=tskH6bw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).