qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Joelle van Dyne <j@getutm.app>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [PATCH] coroutine: add libucontext as external library
Date: Tue, 9 Mar 2021 10:20:07 +0000	[thread overview]
Message-ID: <CAFEAcA__kgr8=g1X87RAaMax9zs00mefCvqrfH4TzfU6oTaowA@mail.gmail.com> (raw)
In-Reply-To: <CA+E+eSBt5sq08zfxLOZKNQd=A3q=9YLEt0moipTb7j+OGWyuRg@mail.gmail.com>

On Tue, 9 Mar 2021 at 09:59, Joelle van Dyne <j@getutm.app> wrote:
>
> On Tue, Mar 9, 2021 at 1:36 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
> > The README here:
> >
> >   https://github.com/kaniini/libucontext
> >
> > indicates that it is intentionally limiting what registers it saves
> > and restores, explicitly excluding FPU.
> >
> > Peter & Paolo expressed concern about this, indicating FPU reg support
> > was a requirement for QEMU:
> >
> >    https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05525.html
> >
> Does it make a difference if this is provided as an option and not as
> a replacement? Would it make sense to add some warning at configure
> time? Right now none of the concurrency backends are supported on iOS
> and it's possible support will go away on macOS as well in the future.
> QEMU would not be able to run at all.

We don't currently support iOS; if we add it we definitely don't
want to add it as a "we know this has buggy coroutine support"
target, because that's a path to weird hard-to-diagnose bugs.
Right now macOS works fine without libucontext; if we ever do need
to use libucontext on macOS in future we'd want to get the FPU
support etc fixed first.

Adding FPU handling for aarch64 to libucontext should not be too
difficult (because the FPU is guaranteed to exist you don't need to
do the hardware capability detection the README talks about).

thanks
-- PMM


  reply	other threads:[~2021-03-09 10:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09  3:26 [PATCH] coroutine: add libucontext as external library Joelle van Dyne
2021-03-09  9:35 ` Daniel P. Berrangé
2021-03-09  9:59   ` Joelle van Dyne
2021-03-09 10:20     ` Peter Maydell [this message]
2021-03-09 10:32       ` Daniel P. Berrangé
2021-03-09 10:24     ` Paolo Bonzini
2021-03-09 10:29       ` Daniel P. Berrangé
2021-03-09 10:42         ` Marc-André Lureau
2021-03-09 10:48           ` Paolo Bonzini
2021-03-09 15:38 ` Stefan Hajnoczi
2021-03-09 18:24   ` Joelle van Dyne
2021-03-09 21:21     ` Joelle van Dyne
2021-03-10  9:29       ` Daniel P. Berrangé
2021-03-10 16:32         ` Joelle van Dyne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA__kgr8=g1X87RAaMax9zs00mefCvqrfH4TzfU6oTaowA@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=berrange@redhat.com \
    --cc=j@getutm.app \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).