From: Peter Maydell <peter.maydell@linaro.org>
To: Programmingkid <programmingkidx@gmail.com>
Cc: QEMU devel list <qemu-devel@nongnu.org>,
Akihiko Odaki <akihiko.odaki@gmail.com>
Subject: Re: Picture missing in About dialog on cocoa ui
Date: Tue, 17 Aug 2021 09:59:06 +0100 [thread overview]
Message-ID: <CAFEAcA_fcg-opZa9UCLy6f7x4gMk6jhX9236nu3BDU1WuC+f=w@mail.gmail.com> (raw)
In-Reply-To: <CAC5464E-0E9B-4B0B-A844-2F4F3AADCCF5@gmail.com>
On Mon, 16 Aug 2021 at 21:55, Programmingkid <programmingkidx@gmail.com> wrote:
>
>
>
> > On Jul 8, 2021, at 2:38 PM, Programmingkid <programmingkidx@gmail.com> wrote:
> >
> >
> >
> >> On Jul 8, 2021, at 1:50 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> >>
> >> On Thu, 8 Jul 2021 at 17:28, Programmingkid <programmingkidx@gmail.com> wrote:
> >>> The problem with e31746ecf8dd2f25f687c94ac14016a3ba5debfc is it requires a
> >>> picture file to be found in a certain path. My original code used QEMU's
> >>> icon to obtain a picture. The reason why the picture in the About dialog
> >>> stopped appearing was because of the move to the meson build system.
> >>> A new patch has just been committed that fixes the missing icon issue.
> >>> Using 'git revert e31746ecf8dd2f25f687c94ac14016a3ba5debfc' fixes the
> >>> missing picture issue in the About dialog.
>
>
> Hi Peter, I was wondering if you had made a decision on whether you plan on reverting the patch that breaks the About dialog for the Cocoa UI.
No, reverting looks like the wrong thing. If get_relocated_path()
doesn't work then we should find and fix that bug.
-- PMM
next prev parent reply other threads:[~2021-08-17 9:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 17:00 Picture missing in About dialog on cocoa ui Programmingkid
2021-07-08 5:37 ` Akihiko Odaki
2021-07-08 8:58 ` Peter Maydell
2021-07-08 16:23 ` Programmingkid
2021-07-08 16:27 ` Programmingkid
2021-07-08 17:50 ` Peter Maydell
2021-07-08 18:38 ` Programmingkid
2021-08-16 20:55 ` Programmingkid
2021-08-17 8:59 ` Peter Maydell [this message]
2021-07-09 0:15 ` Akihiko Odaki
2021-07-10 2:43 ` Programmingkid
2021-07-10 3:30 ` Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_fcg-opZa9UCLy6f7x4gMk6jhX9236nu3BDU1WuC+f=w@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=akihiko.odaki@gmail.com \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).