From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6352C433DB for ; Thu, 18 Mar 2021 20:16:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FF6A64F1B for ; Thu, 18 Mar 2021 20:16:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FF6A64F1B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMz4T-0003p1-VS for qemu-devel@archiver.kernel.org; Thu, 18 Mar 2021 16:16:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMz2e-0002o5-Uk for qemu-devel@nongnu.org; Thu, 18 Mar 2021 16:14:50 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:43650) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMz2c-0004SI-8a for qemu-devel@nongnu.org; Thu, 18 Mar 2021 16:14:48 -0400 Received: by mail-ed1-x52f.google.com with SMTP id e7so8212787edu.10 for ; Thu, 18 Mar 2021 13:14:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7Slz3Sk8F3I1jFQEZGdButOahAHA1k5lJ+yNinAJeJY=; b=GMMAlZ/m1QnBTvg3c4ddZ8y1L/nJll4Zn3t9rJaqPBrgmAsGwLFvE7sZFWfwjuW4vU QYH0AIKJSL/4nD6iFin0Ichhnl1aVzhi9NpR4/waIFJ2vzIGyvatlka5xQPuDJn5DYzd iUZMU7gJAGKjXDO4uAmCIdGppIGq2skG+GJai5bFWjgRgYO9HkRZCsRbRNi+ln7dQSEL XOF+NmjYeiD3JHHctyOHjqQFnIYVQPaQ6DHmBTFm02dYZK/fibcBlYdSC2axFiI1dQQ0 ZwuQQA06HIptIYX1sPKmBOolcCEoTsUx0Kjb3CBQmUd3zS2JnhGj/7L4+9r9CHkJ0sX6 Spyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7Slz3Sk8F3I1jFQEZGdButOahAHA1k5lJ+yNinAJeJY=; b=spF+RJyc6gFD5xvWNYTPnXn3PAua+wPnueh3jIMLE+oINai4pkKLgRMiTBJFuBW2j0 oK2k47g9JEePnHfM685bj85PTQ/d4g2zRk3qVSgPU54FbMLXbAS/aYpDAHWLf9h7HIGv eCgIjmq+V2okFJJvDge2XR/hDSI05NqVHQ4bEtHZdaQXH0nBRjHh7laRwNS6ixjEm2N0 VvD8Va8eV6TF1ObPUCrDOP5yX2CqLaEzJCc8h5/GhGUhcGC+Z2iBYT7hLL0S6snkx39q tUa8AEU+Gps4HMaSS/ch3ZhEd0eJrZWldkOOhOQB8C2bKbII+eT64ibDDBV49JGPDzuw gwkQ== X-Gm-Message-State: AOAM533ZXjNcks0hmtA5n8TtlfWbyarWS4LxtyD1t8XChYfP/hx6KtnN AW6786HiVz8Tiry1rMAWWJmBiRDICKGkv4KEgc1uGw== X-Google-Smtp-Source: ABdhPJw5YdkOIR+2WdvbBo4NDSTmibLQil+cuC3wMiAqCWCLpVd1HBYobvZfL0j763TyvPnXhDlyPj4TC7MnOK4YKEI= X-Received: by 2002:aa7:c804:: with SMTP id a4mr5666277edt.251.1616098484753; Thu, 18 Mar 2021 13:14:44 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Peter Maydell Date: Thu, 18 Mar 2021 20:14:20 +0000 Message-ID: Subject: Re: of AVR target page size To: "Dr. David Alan Gilbert" Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Richard Henderson , Michael Rolnik , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 18 Mar 2021 at 20:05, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.maydell@linaro.org) wrote: > > On Thu, 18 Mar 2021 at 10:45, Dr. David Alan Gilbert > > wrote: > > > > > > * Peter Maydell (peter.maydell@linaro.org) wrote: > > > > Also, what does the > > > > /* 0x80 is reserved in migration.h start with 0x100 next */ > > > > comment refer to? migration.h has no instances of "RAM_SAVE" > > > > or 0x80 or 1 << 7... > > > > > > It looks like it got moved to qemu-file.h a few years ago > > > as RAM_SAVE_FLAG_HOOK. > > > > Could we put the define of RAM_SAVE_FLAG_HOOK in migration.h > > with all the other RAM_SAVE_FLAG defines ? It looks like the two > > places that use it already include migration.h... > > Do you mean move the rest of the RAM_SAVE_FLAG_* from migration/ram.c > into migration.h? > > We could do - although they're never used by anything else. Oh, I'd missed that the other RAM_SAVE_FLAG_* are in a C file. Yes, I think they would be better in a .h file, so the whole set of definitions can be together. migration/ram.h seems like a plausible place. thanks -- PMM