From: Peter Maydell <peter.maydell@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-ppc <qemu-ppc@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Guenter Roeck <linux@roeck-us.net>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2 3/3] sam460ex: Clean up irq mapping
Date: Fri, 1 Jan 2021 12:03:07 +0000 [thread overview]
Message-ID: <CAFEAcA_hROTuxFmXZq7dyp931XWr3reXHUtqzDLdQu0ynixUHQ@mail.gmail.com> (raw)
In-Reply-To: <79681dc2-d689-4518-a83-dead38dd6e8@eik.bme.hu>
On Thu, 31 Dec 2020 at 20:55, BALATON Zoltan <balaton@eik.bme.hu> wrote:
> The SoC is called 460EX (despite having a PPC 440 core not 460 one) but I
> think you've looked at the right data sheet and it's just a typo. I also
> don't know how the board is wired so I think in this case I prefer
> dropping this patch and keeping the current code just for simplicity but
> to avoid going through this again maybe we should add a comment saying why
> it's working. Can you please suggest a text for such comment pointing to
> the relevant part of pci_change_irq_level() you refer to above? I don't
> think I understand it enough to document it.
How about:
/*
* All four IRQ[ABCD] pins from all slots are tied to a single board
* IRQ, so our mapping function here maps everything to IRQ 0.
* The code in pci_change_irq_level() tracks the number of times
* the mapped IRQ is asserted and deasserted, so if multiple devices
* assert an IRQ at the same time the behaviour is correct.
*/
?
thanks
-- PMM
next prev parent reply other threads:[~2021-01-01 12:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 11:11 [PATCH v2 0/3] Clean up sam460ex irq mapping BALATON Zoltan via
2020-12-25 20:12 ` [PATCH v2 2/3] sam460ex: Remove FDT_PPC dependency from KConfig BALATON Zoltan via
2020-12-31 16:08 ` Philippe Mathieu-Daudé
2021-01-04 1:51 ` BALATON Zoltan via
2021-01-04 11:48 ` Peter Maydell
2021-01-05 12:50 ` Paolo Bonzini
2020-12-31 11:11 ` [PATCH v2 1/3] ppc4xx: Move common dependency on serial to common option BALATON Zoltan via
2021-01-04 0:31 ` David Gibson
2021-01-04 1:25 ` BALATON Zoltan via
2020-12-31 11:11 ` [PATCH v2 3/3] sam460ex: Clean up irq mapping BALATON Zoltan via
2020-12-31 15:11 ` Peter Maydell
2020-12-31 15:51 ` Peter Maydell
2020-12-31 20:54 ` BALATON Zoltan via
2020-12-31 20:58 ` BALATON Zoltan via
2021-01-01 12:03 ` Peter Maydell [this message]
2021-01-03 1:46 ` BALATON Zoltan via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA_hROTuxFmXZq7dyp931XWr3reXHUtqzDLdQu0ynixUHQ@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=david@gibson.dropbear.id.au \
--cc=linux@roeck-us.net \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).