From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NORMAL_HTTP_TO_IP,NUMERIC_HTTP_ADDR,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73C2CC433B4 for ; Fri, 21 May 2021 08:51:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BDD46108B for ; Fri, 21 May 2021 08:51:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BDD46108B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lk0sh-0005VU-Ua for qemu-devel@archiver.kernel.org; Fri, 21 May 2021 04:51:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lk0rN-0003oB-66 for qemu-devel@nongnu.org; Fri, 21 May 2021 04:50:21 -0400 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]:34425) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lk0rJ-0001cH-5J for qemu-devel@nongnu.org; Fri, 21 May 2021 04:50:20 -0400 Received: by mail-ej1-x634.google.com with SMTP id p24so28090766ejb.1 for ; Fri, 21 May 2021 01:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nHQf9aqjvDiQAloLKZf4E0K0KTaekuoeyXryd7vtLTA=; b=kI7hIvPzqWmwhSt6CZRdUnShAImbYznG4JCkU1hTXao3CWhdOKTVo9SPX/hGXzcQdR 17x27lImPRFDwaHdjsuHkf9iCWE2xy9O1LzoDnhHIAtSPaCJ4Xpnf3Ys2Wg1qnUoc3s+ HT37K3BAsLSssaJYtlkhdzi9kLb37qYQFMdBrV6llPVflq7vwLZ3CTVXt+cGHKM1/HI0 xA3/LQ9GQaZAtlMXQcMR/c5lKTx0S7gq7fwR76Zce+qXbmcmXkMG3VsBUbsvbpldMWY/ i9zU8NISyvSN8tZMqd68bC8Db0ECZqGcL8TiUsJnWTL/6Q8mVAFL4MkQuGvo4YtjXUy7 H+vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nHQf9aqjvDiQAloLKZf4E0K0KTaekuoeyXryd7vtLTA=; b=UblvdNells6Puuiz7n9LZb+lAqA+5rY/gWO2oyYs/wSnModbaIoTB1c9kiK4GPcYDI a/M0wea/nykcsGB3dQbMy+c/fFrjUlKmVq3SmDWyX5dBBzFVReGppNy+BPvWXQhnrACK gPHskWmlBAnCtWjbobr0d3/5NGoHDJSwmV5D3nj8szxtu/KZx6AOGZfn41SlO6WFibbz gkf083jHif7sWnUf736atOLDBGkwqwhYfw0PYDWm3cvW9ZRIkbpsShNTbrftnSwdSv0a QMuXV6RRVgo4UnNid+LErI8CVdKrJLSt/WgddjjWvIPfp8j8GM9/WCUAachrMZ+w6NGn M0BQ== X-Gm-Message-State: AOAM5309DdNc2AOe+mRdf/gjjZwMB4K5QsJnZiGowABq80RhOGSQlgME UkTmHzBONI1EMp+7kcO5mimYkupsYWaIhQRQDzbygw== X-Google-Smtp-Source: ABdhPJxkTzy1RkyufQPf2MOsz2cv6Qus5J5xl3EonDH0eM0tlVmCIvng9+EcaTbrBP8oZdovuIa4aP6k2nZ8JWkJhLY= X-Received: by 2002:a17:906:b74f:: with SMTP id fx15mr9256970ejb.85.1621587015080; Fri, 21 May 2021 01:50:15 -0700 (PDT) MIME-Version: 1.0 References: <20210208182331.58897-1-pbonzini@redhat.com> <20210208182331.58897-22-pbonzini@redhat.com> In-Reply-To: <20210208182331.58897-22-pbonzini@redhat.com> From: Peter Maydell Date: Fri, 21 May 2021 09:49:55 +0100 Message-ID: Subject: Re: [PULL 21/46] meson: Warn when TCI is selected but TCG backend is available To: Paolo Bonzini Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Thomas Huth , =?UTF-8?Q?Daniel_Berrang=C3=A9?= , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 8 Feb 2021 at 23:09, Paolo Bonzini wrote: > > From: Philippe Mathieu-Daud=C3=A9 > > Some new users get confused with 'TCG' and 'TCI', and enable TCI > support expecting to enable TCG. > > Emit a warning when native TCG backend is available on the > host architecture, mentioning this is a suboptimal configuration. > > Reviewed-by: Thomas Huth > Suggested-by: Daniel Berrang=C3=A9 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > Reviewed-by: Daniel P. Berrang=C3=A9 > Message-Id: <20210125144530.2837481-5-philmd@redhat.com> > Signed-off-by: Paolo Bonzini > --- > meson.build | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/meson.build b/meson.build > index 3a13ba3307..4cc3ebb827 100644 > --- a/meson.build > +++ b/meson.build > @@ -231,6 +231,13 @@ if not get_option('tcg').disabled() > else > error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(c= pu)) > endif > + elif get_option('tcg_interpreter') > + warning('Use of the TCG interpretor is not recommended on this host'= ) > + warning('architecture. There is a native TCG execution backend avail= able') > + warning('which provides substantially better performance and reliabi= lity.') > + warning('It is strongly recommended to remove the --enable-tcg-inter= preter') > + warning('configuration option on this architecture to use the native= ') > + warning('backend.') > endif > if get_option('tcg_interpreter') Just noticed this one after it hit master, but there's a typo here: "TCG interpretor" should be "interpreter". thanks -- PMM