From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D23BC48BE5 for ; Mon, 21 Jun 2021 10:44:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28EAC610CA for ; Mon, 21 Jun 2021 10:44:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28EAC610CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvHPu-0001em-39 for qemu-devel@archiver.kernel.org; Mon, 21 Jun 2021 06:44:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvH3J-0004ME-43 for qemu-devel@nongnu.org; Mon, 21 Jun 2021 06:21:17 -0400 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]:42905) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lvH3G-0003C4-N5 for qemu-devel@nongnu.org; Mon, 21 Jun 2021 06:21:12 -0400 Received: by mail-ed1-x52b.google.com with SMTP id m14so1463118edp.9 for ; Mon, 21 Jun 2021 03:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=euDIMfdif4hfuxSIEYdj+9uKBob9bmEhRYjfTESE64E=; b=zfM7y/FUFrg9hYPDNJQ5epCK6asud0HhR37cZu5af9jA3HGwdqcVI7gIkV8Ju11Nd2 /t//6tm2mjiEUdAH6BuUH/dfu9y0MCXoprCb2Dvz2JJhadaVystVgOq3mOUkGOdnjgZN d3uFGznwFcUeaMC/eyxvYUq0BOJ6g6nKl0fQaltLy/0Yq0BsR3aaT98+MT7z3DP6ouGR PUwzpyBp8TadIPp/ysVp5pP8+vcR85IjTlSb0OgMF+JTGQFU/Eb+FsYgSuW8Nlpvs/zo y5xfD1wCWSbPiKlNr7ZnGeavTA7D6pFzllNJLjmZVXxeRwnAkEr/WVvcC6ZAtN1IqULS JpSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=euDIMfdif4hfuxSIEYdj+9uKBob9bmEhRYjfTESE64E=; b=awtml1zH/ELDMZxWugGSGXMvQc/Lcjwsadw0I1vEECPDaZ9TZL8yjpx859mrwvx7xI YzM0BbpXH9TPtDKJavD7oGFxMZbr4K1AYE0N5aOgKeXuV+fTACU11C32M3O1/3JMeFTA 2QaklK/ZVIwZEgLXdk/v8ix7AWFiBrgLo0R4XWucv5/fX/scVnwH6UIzhOj6Lhe6cLKb fKIbFDoFbx8zZAspA22xoNhNYEa+b6JGGWB9OafuPu9oNJAhCQW3IubFAd9sgmyqRDEn p0p9TF39O8pFAJVYo8GShsP5D/kzqYYObvGHKhxVyPvYLJfSXzN2rTHIwMhmZvrO3NWh 1NPw== X-Gm-Message-State: AOAM531tTNgFZtIAvlHc+s3etKomCEgjq999pBY3951Fg54R6WHWDYlg QLk+oYY7vEtT+/rRTPTMLU+aUiUkif8XDtZNd/keGQ== X-Google-Smtp-Source: ABdhPJxuKhOoDhOEkoEltVOprPKSokU8604dyyDXYx5d/V6MzHi5EqKGvhkvfoSVoDN7JnO6J4YFMZ6nLpPplPY/3hg= X-Received: by 2002:a05:6402:3553:: with SMTP id f19mr8383125edd.52.1624270868587; Mon, 21 Jun 2021 03:21:08 -0700 (PDT) MIME-Version: 1.0 References: <20210621013439.1791385-1-richard.henderson@linaro.org> <20210621013439.1791385-6-richard.henderson@linaro.org> In-Reply-To: <20210621013439.1791385-6-richard.henderson@linaro.org> From: Peter Maydell Date: Mon, 21 Jun 2021 11:20:32 +0100 Message-ID: Subject: Re: [PATCH 05/26] target/arm: Use translator_use_goto_tb To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::52b; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 21 Jun 2021 at 02:42, Richard Henderson wrote: > > Put a wrapper in translate.h, which also checks for ss_active. > The ss_active test was incorrectly missing from the a32 version. True, but we almost never call gen_goto_tb() when ss_active (which makes sense because we generate code to raise a singlestep exception instead). The only cases I think where we do call gen_goto_tb() are ISB and SB; everything else calls gen_jmp_tb() or otherwise handles the is_singlestepping() case. thanks -- PMM