From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DAC6C433EF for ; Wed, 8 Sep 2021 16:23:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFF1460E77 for ; Wed, 8 Sep 2021 16:23:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BFF1460E77 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:60916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mO0Me-0003Bm-1A for qemu-devel@archiver.kernel.org; Wed, 08 Sep 2021 12:23:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mO0Ll-0001sE-Q4 for qemu-devel@nongnu.org; Wed, 08 Sep 2021 12:23:01 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:37855) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mO0Lk-0006ED-7n for qemu-devel@nongnu.org; Wed, 08 Sep 2021 12:23:01 -0400 Received: by mail-wm1-x335.google.com with SMTP id c8-20020a7bc008000000b002e6e462e95fso2079512wmb.2 for ; Wed, 08 Sep 2021 09:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=uyCEqiZpFPbhNhLUHk+jlAm0SG8m8+ljOTRADMgnNIs=; b=HnHtfQG5BNpDiDQ9TdlrcbueXohaFMNdHoEIte5tzTEboRsFO3ua4K53pqAZSiLHnj 9/CgnY0h4YmMSlMBxmkhjWXN2axyNNqckYFDpLC7C0LBXi/s51AZeCOSLOzD0aaxxsHd ZREXyk79UBhqfyhUxtFfuqlpxcEIhT3Oy7wmZpTJbua0EmgqOiU7emo40srG3B/wcaL4 tCHZTdwjkGN2WLN09XooRZdqQ2f+3Gc78MHFsn2Uj11KTEIDWvxNEiugceIbf0jf+6pL kJbDsma6hYjvlcYe5CDFM+M7Z5HK1u+wYuynqqc0LF7614ve9aMiCN9KM2g7aDFhNhTM vNqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=uyCEqiZpFPbhNhLUHk+jlAm0SG8m8+ljOTRADMgnNIs=; b=pAXZM8p3wd5BP7yB53kSi5F2qgn+Zw8rUafPkBhHJehX4V1yQGb48rIwgZPGDk2gRn CSCgE0oOeXZvGsGuFnAouJAZApe2JHtJ6oSBIVz2auDZhI79yLpsPST80H06GdOfd7A9 mLhABSJ1ojFoEmk5e2NIA6o3wx+4EKTp0BOKNnmBJhaU+R4DMQE7wBI1AyCmMO4ajbkG YeBRYgC24Uy94cRnTdyUQZnIo5wo/GVGl/JK1s0zaeMN4eb0HawHVdd8zovB1fVMU6zl EMqOzwO6AZdTAo3oxmiKVuQMN7toczDg2w0wGXPgMajtV75quG4CbyqPae7iRJrHvsyn 0maQ== X-Gm-Message-State: AOAM531lFjkt/E4rgQFbRPPh6djzKeKtNw7zWGtgpgQQfmhroW65ZtZW hjtVXQYK8WpCHk/ZQ0v7egDkcOS+RQPvF2F9wT780A== X-Google-Smtp-Source: ABdhPJxSiYgJorncs8Wm86XAcx4l02tY6OKCb/Rul2P0lHjmRGxM2keZLa52HVmxVKw/lkmbXr028yji2UurixWJw6Y= X-Received: by 2002:a7b:c246:: with SMTP id b6mr4491564wmj.37.1631118177458; Wed, 08 Sep 2021 09:22:57 -0700 (PDT) MIME-Version: 1.0 References: <20210907121943.3498701-1-marcandre.lureau@redhat.com> <20210907121943.3498701-14-marcandre.lureau@redhat.com> <24888.55565.53378.616422@mariner.uk.xensource.com> <24888.56575.675507.669862@mariner.uk.xensource.com> In-Reply-To: From: Peter Maydell Date: Wed, 8 Sep 2021 17:22:07 +0100 Message-ID: Subject: Re: [RFC v3 13/32] rust: use vendored-sources To: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Daniel P. Berrange" , Markus Armbruster , QEMU , Ian Jackson , Stefan Hajnoczi , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 8 Sept 2021 at 17:17, Marc-Andr=C3=A9 Lureau wrote: > > Hi > > On Wed, Sep 8, 2021 at 7:55 PM Ian Jackson wrote: >> >> Marc-Andr=C3=A9 Lureau writes ("Re: [RFC v3 13/32] rust: use vendored-so= urces"): >> > Hmm, I do "cargo vendor --versioned-dirs ../rust/vendored" to vendor c= rates. >> > >> > It seems cc was updated, and I didn't update the submodule accordingly= . For >> > reference, this is the dependency tree that WFM: >> >> git submodules are just awful IMO. > > > Yes, but it's often (always?) the user fault. I tend to agree with Ian -- submodules are badly designed, and have lots of sharp edges that it's easy to cut yourself on. Yes, you can say "well, the user should have held it by the other handle because that one isn't fitted with the spring-loaded razorblades", but I would argue that fault is better placed at the door of the designer in that kind of situation... -- PMM