From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19192C11F66 for ; Tue, 29 Jun 2021 13:46:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D379861D94 for ; Tue, 29 Jun 2021 13:46:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D379861D94 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyE4n-0000Bv-Or for qemu-devel@archiver.kernel.org; Tue, 29 Jun 2021 09:46:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyE0s-0002Ml-Ej for qemu-devel@nongnu.org; Tue, 29 Jun 2021 09:42:54 -0400 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]:39440) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyE0o-00066r-Nw for qemu-devel@nongnu.org; Tue, 29 Jun 2021 09:42:53 -0400 Received: by mail-ej1-x636.google.com with SMTP id yy20so28689516ejb.6 for ; Tue, 29 Jun 2021 06:42:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p17HE7hDXce1n71AxYOWi1oO24J4ufK5itugnEo8N/A=; b=IYrqnt2wFxvMkkXrUdXpS86MovSv0rp8yvrimNExoO0BW+78ez92UzSkj2HA5JHqqA QUQIIjas7O2B60gWT8Iy1q9Ej1g/4pgzm8dlht0xG/Il1k1ZaWN4nKlewlEb7F9h99zq uoy5c+VVOvYVuIg4sGeWPVgXbEgtCeYkpLIHC2iBOBt8BFELRw3WLwq5fnkJnvQYcSFm NoOptCWSwnLcPYF57dwmIxQgTa/uLPyyro5rq77wY/Efc0tMsoyvltQ8P1MBy/eT0wF1 0BBtS4olcQp21Y3AF7r5rEUj36zvIuMcx6Fn1tfHvFaFqtYl62H1p2BQ3MTS0uvgLAn4 fTyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p17HE7hDXce1n71AxYOWi1oO24J4ufK5itugnEo8N/A=; b=Op2yoohIY+rX710tqh+XRKHXAGLvsRypaRjpsVR91SkjTsX4rRCp5y7qMlxmnpnPby 6Rl6uAoo4S4PTWolT9SCIUHQd4Ws66qjjRnenf/6lsW9LAJz1qGWcwMYG4Z9/xwgMTFr PSLrMD17VTgmXUGXPl/XiP9rkWeoB8mxgb9y6Swia2UTqF+fLBkC8WMBIqFXlhHAOVco ye5EXnH4pxCNSIVcLNqKjfa5mSc2pPNbGiLhySc9vxbCbY+KesUnvrj/uWg1Itv2rxZB orupwOqHnZdrJRVIX5Gvu9N+ps7Gb0OL24VI3oh9zineteoIhwH8E9TqmlKPqY4gYfwp W4Yw== X-Gm-Message-State: AOAM5300fypG/uY/upSbvCg3rI2HSyQQGw8GR5U0fPGJMKr1Gx/PvcHW HgxRg2Kt3gtJOmk9GHtP5QH53N0bO0X2tw9U29+cxg== X-Google-Smtp-Source: ABdhPJxyJ/R8euBl43viH0kFhqcvo/fi6ugvJjvTvzj05mzP3zdQOAEWncrUa833EJ0wzRwUWOZtR6G5Ya8HgUK5epM= X-Received: by 2002:a17:907:a064:: with SMTP id ia4mr30376630ejc.482.1624974169075; Tue, 29 Jun 2021 06:42:49 -0700 (PDT) MIME-Version: 1.0 References: <1624881885-31692-1-git-send-email-gaosong@loongson.cn> <1624881885-31692-21-git-send-email-gaosong@loongson.cn> In-Reply-To: <1624881885-31692-21-git-send-email-gaosong@loongson.cn> From: Peter Maydell Date: Tue, 29 Jun 2021 14:42:12 +0100 Message-ID: Subject: Re: [PATCH 20/20] target/loongarch: Add linux-user emulation support To: Song Gao Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Richard Henderson , QEMU Developers , Bibo Mao , Laurent Vivier , Alistair Francis , Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 28 Jun 2021 at 13:05, Song Gao wrote: > > Add files to linux-user/loongarch64 > Add file to default-configs > Add loongarch to target/meson.build > > Signed-off-by: Song Gao > --- > MAINTAINERS | 1 + > default-configs/targets/loongarch64-linux-user.mak | 4 + > include/elf.h | 2 + > linux-user/elfload.c | 58 ++++ > linux-user/loongarch64/cpu_loop.c | 177 ++++++++++++ > linux-user/loongarch64/signal.c | 193 +++++++++++++ > linux-user/loongarch64/sockbits.h | 1 + > linux-user/loongarch64/syscall_nr.h | 307 +++++++++++++++++++++ > linux-user/loongarch64/target_cpu.h | 36 +++ > linux-user/loongarch64/target_elf.h | 14 + > linux-user/loongarch64/target_fcntl.h | 12 + > linux-user/loongarch64/target_signal.h | 28 ++ > linux-user/loongarch64/target_structs.h | 49 ++++ > linux-user/loongarch64/target_syscall.h | 46 +++ > linux-user/loongarch64/termbits.h | 229 +++++++++++++++ > linux-user/syscall_defs.h | 8 +- > meson.build | 2 +- > qapi/machine-target.json | 4 +- > target/loongarch/meson.build | 19 ++ > target/meson.build | 1 + > 20 files changed, 1185 insertions(+), 6 deletions(-) This is a massive patch that would benefit from being split up into multiple smaller patches. I'm told by a kernel developer that loongarch hasn't yet been accepted into the Linux kernel mainline. Until it has been, the syscall ABI for it is not yet stable, so we won't be able to take the linux-user patches for it yet. (We have been burned in the past by taking linux-user architecture support patches without realizing they weren't for a stable ABI, and then being out of sync with the eventual upstream kernel ABI that was accepted.) We can certainly do code review in the meantime, though. thanks -- PMM