* [PULL 0/1] QGA warning fix
@ 2023-03-22 19:22 Konstantin Kostiuk
2023-03-22 19:22 ` [PULL 1/1] qga/vss-win32: fix warning for clang++-15 Konstantin Kostiuk
2023-03-25 16:28 ` [PULL 0/1] QGA warning fix Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Konstantin Kostiuk @ 2023-03-22 19:22 UTC (permalink / raw)
To: qemu-devel, Peter Maydell, Daniel P . Berrangé, Pierrick Bouvier
From: Kostiantyn Kostiuk <kostyanf14@live.com>
The following changes since commit 9832009d9dd2386664c15cc70f6e6bfe062be8bd:
Merge tag 'pull-riscv-to-apply-20230306' of https://gitlab.com/palmer-dabbelt/qemu into staging (2023-03-07 12:53:00 +0000)
are available in the Git repository at:
git@github.com:kostyanf14/qemu.git tags/qga-pull-2023-03-22
for you to fetch changes up to 0fcd574b025fccdf14d5140687cafe2bc30b634f:
qga/vss-win32: fix warning for clang++-15 (2023-03-22 21:02:09 +0200)
----------------------------------------------------------------
qga-pull-2023-03-22
----------------------------------------------------------------
Pierrick Bouvier (1):
qga/vss-win32: fix warning for clang++-15
qga/vss-win32/install.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PULL 1/1] qga/vss-win32: fix warning for clang++-15
2023-03-22 19:22 [PULL 0/1] QGA warning fix Konstantin Kostiuk
@ 2023-03-22 19:22 ` Konstantin Kostiuk
2023-03-25 16:28 ` [PULL 0/1] QGA warning fix Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Konstantin Kostiuk @ 2023-03-22 19:22 UTC (permalink / raw)
To: qemu-devel, Peter Maydell, Daniel P . Berrangé, Pierrick Bouvier
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reported when compiling with clang-windows-arm64.
../qga/vss-win32/install.cpp:537:9: error: variable 'hr' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
if (!(ControlService(service, SERVICE_CONTROL_STOP, NULL))) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../qga/vss-win32/install.cpp:545:12: note: uninitialized use occurs here
return hr;
^~
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Fixes: 917ebcb170 ("qga-win: Fix QGA VSS Provider service stop failure")
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Kostiantyn Kostiuk <kostyanf14@live.com>
---
qga/vss-win32/install.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
index b57508fbe0..b8087e5baa 100644
--- a/qga/vss-win32/install.cpp
+++ b/qga/vss-win32/install.cpp
@@ -518,7 +518,7 @@ namespace _com_util
/* Stop QGA VSS provider service using Winsvc API */
STDAPI StopService(void)
{
- HRESULT hr;
+ HRESULT hr = S_OK;
SC_HANDLE manager = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
SC_HANDLE service = NULL;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PULL 0/1] QGA warning fix
2023-03-22 19:22 [PULL 0/1] QGA warning fix Konstantin Kostiuk
2023-03-22 19:22 ` [PULL 1/1] qga/vss-win32: fix warning for clang++-15 Konstantin Kostiuk
@ 2023-03-25 16:28 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2023-03-25 16:28 UTC (permalink / raw)
To: Konstantin Kostiuk; +Cc: qemu-devel, Daniel P . Berrangé, Pierrick Bouvier
On Wed, 22 Mar 2023 at 19:22, Konstantin Kostiuk <kkostiuk@redhat.com> wrote:
>
> From: Kostiantyn Kostiuk <kostyanf14@live.com>
>
>
> The following changes since commit 9832009d9dd2386664c15cc70f6e6bfe062be8bd:
>
> Merge tag 'pull-riscv-to-apply-20230306' of https://gitlab.com/palmer-dabbelt/qemu into staging (2023-03-07 12:53:00 +0000)
>
> are available in the Git repository at:
>
> git@github.com:kostyanf14/qemu.git tags/qga-pull-2023-03-22
>
> for you to fetch changes up to 0fcd574b025fccdf14d5140687cafe2bc30b634f:
>
> qga/vss-win32: fix warning for clang++-15 (2023-03-22 21:02:09 +0200)
>
> ----------------------------------------------------------------
> qga-pull-2023-03-22
>
> ----------------------------------------------------------------
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-25 16:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-22 19:22 [PULL 0/1] QGA warning fix Konstantin Kostiuk
2023-03-22 19:22 ` [PULL 1/1] qga/vss-win32: fix warning for clang++-15 Konstantin Kostiuk
2023-03-25 16:28 ` [PULL 0/1] QGA warning fix Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).