From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38683)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aVKMS-0005f4-Ep
	for qemu-devel@nongnu.org; Mon, 15 Feb 2016 09:42:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aVKMR-0001Pq-H0
	for qemu-devel@nongnu.org; Mon, 15 Feb 2016 09:42:48 -0500
Received: from mail-vk0-x229.google.com ([2607:f8b0:400c:c05::229]:34818)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1aVKMR-0001Pl-4X
	for qemu-devel@nongnu.org; Mon, 15 Feb 2016 09:42:47 -0500
Received: by mail-vk0-x229.google.com with SMTP id e6so108662634vkh.2
	for <qemu-devel@nongnu.org>; Mon, 15 Feb 2016 06:42:47 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <87wpq6m490.fsf@linaro.org>
References: <1454664263-25969-1-git-send-email-famz@redhat.com>
	<1454664263-25969-7-git-send-email-famz@redhat.com>
	<87wpq6m490.fsf@linaro.org>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 15 Feb 2016 14:42:27 +0000
Message-ID: <CAFEAcA_xVFD+4=D8AkzeLBoT1_gYX8_6gZAu9iXa+-Febq3pqw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 06/12] docker: Add basic test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Stefan Weil <sw@weilnetz.de>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>, David Gibson <david@gibson.dropbear.id.au>

On 15 February 2016 at 14:34, Alex Benn=C3=A9e <alex.bennee@linaro.org> wro=
te:
>
> Fam Zheng <famz@redhat.com> writes:
>> +cd $(mktemp -d)
>> +mkdir build
>> +mkdir install
>> +cd build
>> +build_qemu --target-list=3Dx86_64-softmmu --prefix=3D"${pwd}/install"

Why restrict the target list ?

>> +make check $MAKEFLAGS
>> +make install
>
> From my excursions last week into the tests directory I discovered the
> unit tests are built for a number of different qtest binaries. For
> completeness we should probably include the whole list:
>
> #+name: qtest-targets
> #+begin_src sh :dir ~/lsrc/qemu/qemu.git :results scalar
> grep -E "check-qtest-[[:alnum:]]+-y " tests/Makefile | cut -d " " -f 1 | =
sort -u
> #+end_src
>
> #+RESULTS: qtest-targets
> #+begin_example
> check-qtest-arm-y
> check-qtest-generic-y
> check-qtest-i386-y
> check-qtest-ipack-y
> check-qtest-microblazeel-y
> check-qtest-mips64el-y
> check-qtest-mips64-y
> check-qtest-mips-y
> check-qtest-pci-y
> check-qtest-ppc64-y
> check-qtest-ppc-y
> check-qtest-sh4eb-y
> check-qtest-sh4-y
> #check-qtest-sparc64-y
> check-qtest-sparc64-y
> #check-qtest-sparc-y
> check-qtest-virtioserial-y
> check-qtest-virtio-y
> check-qtest-x86_64-y
> check-qtest-xtensaeb-y
> check-qtest-y
> #+end_example

I'm having difficulty figuring out what you're proposing here,
but it looks like you're suggesting listing all the check-qtest-*
test names again here, which seems worth avoiding. We should
just do a build and make check and let that take care of
running all the tests.

thanks
-- PMM