From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CDB4C11D19 for ; Thu, 20 Feb 2020 17:53:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CBFE20722 for ; Thu, 20 Feb 2020 17:53:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qkBSCu3x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CBFE20722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4q0u-0003mO-In for qemu-devel@archiver.kernel.org; Thu, 20 Feb 2020 12:53:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44474) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j4q07-0003Jx-Qi for qemu-devel@nongnu.org; Thu, 20 Feb 2020 12:52:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j4q06-0002ny-O9 for qemu-devel@nongnu.org; Thu, 20 Feb 2020 12:52:39 -0500 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]:43785) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j4q06-0002nc-IZ for qemu-devel@nongnu.org; Thu, 20 Feb 2020 12:52:38 -0500 Received: by mail-oi1-x244.google.com with SMTP id p125so28393060oif.10 for ; Thu, 20 Feb 2020 09:52:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NTib0i3ZmZmHWf0sfEYyRftDJz7/bDCOOfO8RltpuB8=; b=qkBSCu3xV1qE6Ydgug4cpW3h9m/i9sIqkqLmzY10hSiYeRdrfEqPt7i0d4M3djlrCc mIIPRimgKcecp5JzhAIVm49v3p9qiP2BEr5/m+bihpxyN3CCqsnTB3XO7qM3g1MElSGt MzEnG/m0KidF5McRFA+tfW4ytXyLYKfkMD3npC0UCxVitRHR5EyJs0ganxcZLW2QK44m kDTlA9mfFZTzl7KY0UqfbA58Oxf3vSfXSyHAIpDPC21LEgkWqJLU/GrKDTwXm+GNAf3f 7xEkH7zTACr7uLi1yJMuEXgbKBfM8TFPLVAequCRooz54GEsWmqsla9FpQQ3IAe/4i5r gMVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NTib0i3ZmZmHWf0sfEYyRftDJz7/bDCOOfO8RltpuB8=; b=lTwNK041ojgERjI53MoGBx+i9hS+zO4NOHdlvTNd1IcQIOXaqt7mf85o8Hrrd4XlE+ 3to+MSo5CMPwgvKJqKuhygtPTj8u6HuRqQeRIe591831DqqMcES5wKojg/Wl9yBkrJZ4 sHXS64SoiRE33fAknxQremU9aFqa0hBD8aEbnKYJCj1vlevzVq7kQYqgn8KHqdOhmXEh xSHflXBFsJbj+5dsh3KeaB/A2WTF3dRBTH0ZpYSp3ewvfthccU89O0hYRHUjfgcZ3ZIf ypxu8SPQy9IoIVvTkn7IFWzjqRz5mjb18WG9cId1+O+GV6HK6FzFQsqfcwx0vGTFajT7 MhKg== X-Gm-Message-State: APjAAAVz/wH8sZla0XQrRGdh6NaGmO7PLA0JNY5ZNz7T2QgjBsqbWFi6 FuHApj6e0/umpFEKBNMWbI5uGMvJCD37vOl1j+If7gAp X-Google-Smtp-Source: APXvYqztOgP3dWfKlOCNkj4Y+7/icLT9nyUeBa45jhdHCNrkz3JSWrUPO5xU3tzM/7XXhpZrPoa9wVKpHq2sVfKB0So= X-Received: by 2002:a05:6808:3b2:: with SMTP id n18mr2868214oie.146.1582221157756; Thu, 20 Feb 2020 09:52:37 -0800 (PST) MIME-Version: 1.0 References: <20200214181547.21408-1-richard.henderson@linaro.org> In-Reply-To: <20200214181547.21408-1-richard.henderson@linaro.org> From: Peter Maydell Date: Thu, 20 Feb 2020 17:52:26 +0000 Message-ID: Subject: Re: [PATCH 00/19] target/arm: vfp feature and decodetree cleanup To: Richard Henderson Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::244 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 14 Feb 2020 at 18:15, Richard Henderson wrote: > > The main goal of the patchset is to move the ARM_FEATURE_VFP > test from outside of the disas_vfp_insn() to inside each of > the trans_* functions, so that we get the proper ISA check > for each case. > > At the end of that, it is easy to eliminate all of the remaining > tests vs ARM_FEATURE_VFP* in favor of the preferred ISAR tests. > > Finally, there are a couple of cleanups to vfp.decode to make > things a bit more legible. > > > r~ > > > Richard Henderson (19): > target/arm: Fix field extract from MVFR[0-2] > target/arm: Rename isar_feature_aa32_simd_r32 > target/arm: Use isar_feature_aa32_simd_r32 more places > target/arm: Set MVFR0.FPSP for ARMv5 cpus > target/arm: Add isar_feature_aa32_simd_r16 > target/arm: Rename isar_feature_aa32_fpdp_v2 > target/arm: Add isar_feature_aa32_{fpsp_v2,fpsp_v3,fpdp_v3} > target/arm: Perform fpdp_v2 check first > target/arm: Replace ARM_FEATURE_VFP3 checks with fp{sp,dp}_v3 > target/arm: Add missing checks for fpsp_v2 > target/arm: Replace ARM_FEATURE_VFP4 with isar_feature_aa32_simdfmac > target/arm: Remove ARM_FEATURE_VFP check from disas_vfp_insn > target/arm: Move VLLDM and VLSTM to vfp.decode > target/arm: Move the vfp decodetree calls next to the base isa > linux-user/arm: Replace ARM_FEATURE_VFP* tests for HWCAP > target/arm: Remove ARM_FEATURE_VFP* > target/arm: Add formats for some vfp 2 and 3-register insns > target/arm: Split VFM decode > target/arm: Split VMINMAXNM decode Hi; patch 1 here already has a version in my PMU patchset. I've applied patches 2-10 to target-arm.next, with one or two minor fixups for things like the checkpatch long-line warning and a typo here or there in commit message or comment (expect a pullreq either today or tomorrow). Patches 11-19 I've sent reviewed-by tags or comments on. thanks -- PMM