From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1244C4338F for ; Tue, 3 Aug 2021 18:02:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFBFC60F48 for ; Tue, 3 Aug 2021 18:02:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EFBFC60F48 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:58722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAykM-0005y2-1W for qemu-devel@archiver.kernel.org; Tue, 03 Aug 2021 14:02:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAyjH-0005Eb-87 for qemu-devel@nongnu.org; Tue, 03 Aug 2021 14:01:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27064) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAyjF-0002NX-Ie for qemu-devel@nongnu.org; Tue, 03 Aug 2021 14:01:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628013684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zfHHJt5pyhCzXI3y3CpLgGKpgRUs7s9AtpKBBX0o+VE=; b=Xk1LvsH3/rt4mmmq/xeF+iR9K4AecbIZpWqaG1Kl60E3C+93DZGaoqT35q9493r6KdRTCl JoaKNEhfvRJZ2BuC8ecD6uXss/CHViba8Gs/o6PZPdacsQ0aZR0IOJK62iSSqI359KpP7Q PwD5eK0ABpTcfF5OpoPkSRUjVU1X8t4= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-285-YFXniUk6My2m8cjkSZn6dA-1; Tue, 03 Aug 2021 14:01:22 -0400 X-MC-Unique: YFXniUk6My2m8cjkSZn6dA-1 Received: by mail-oi1-f198.google.com with SMTP id w16-20020a0568081410b029025c350a89fdso8975415oiv.11 for ; Tue, 03 Aug 2021 11:01:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zfHHJt5pyhCzXI3y3CpLgGKpgRUs7s9AtpKBBX0o+VE=; b=LE5CEYzgwitKYkvOfA6+uagJQAeSSbWK0qM7APMMGBN47xJxX1Y7OGPOKZS9XS7clM 9e8rjW9Yi4qVkP88ZLPoH21ceCbdOdyRrrdu8yoIr2XYjaEP1r1di6fAiiBwyBg+2pIP MM0G0WjBW7xG+zZubdnHX25ZC1+vAgDpRbP9e6W/hKWRDSyNVgptwGdT3/bB0H3Glkml uGPDGqBHQwyJAAb9l5/om3OhbFJlDE2v+CJTOMz4UVfhOvAlNXHWetWHkeaMqeZYO2cw 3jHWYcqJc8p6lMMGil/KHmpTy7xo9GuZ8FRpNO988wiaSSOgd65sNNaqJPkUu1NLxGbh PQrw== X-Gm-Message-State: AOAM532CVJB0oX4dnclJOZH4I9C3OAn1ii1Asto96Toeh43Ri7w0WUZe 8vnv40/YxanpjinPnWHbAtDUx7Q521q4RbizDu/g2XcQ33NCyUvu+alsVRsM95HNB8P1M283Bdf stqrN91tYiIZv8MidUbW+Q5OdfCrff8A= X-Received: by 2002:a9d:2782:: with SMTP id c2mr16477522otb.323.1628013681903; Tue, 03 Aug 2021 11:01:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxks7CZyhKmzodzIRWONkVyuIZqANjKCgaPt96nc2/SkR8dotTUyLqyYN25Y1ewjQfBoeHL8Np223vjbAoMYoo= X-Received: by 2002:a9d:2782:: with SMTP id c2mr16477505otb.323.1628013681728; Tue, 03 Aug 2021 11:01:21 -0700 (PDT) MIME-Version: 1.0 References: <20210717003253.457418-1-jsnow@redhat.com> <20210717003253.457418-3-jsnow@redhat.com> <20210803160129.e63u5lylorivgjov@redhat.com> <20210803174043.cncgw62hfsdckwua@redhat.com> In-Reply-To: <20210803174043.cncgw62hfsdckwua@redhat.com> From: John Snow Date: Tue, 3 Aug 2021 14:01:10 -0400 Message-ID: Subject: Re: [PATCH v2 02/24] python/aqmp: add error classes To: Eric Blake Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000003079c505c8ab7903" Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Stefan Hajnoczi , Markus Armbruster , Wainer dos Santos Moschetta , qemu-devel , "Niteesh G . S ." , Willian Rampazzo , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000003079c505c8ab7903 Content-Type: text/plain; charset="UTF-8" On Tue, Aug 3, 2021 at 1:40 PM Eric Blake wrote: > On Tue, Aug 03, 2021 at 01:34:32PM -0400, John Snow wrote: > > Got it. I was *just* about to send a refreshed version of this patchset > > because I found a new bug while on my way to making a sync compatibility > > shim for iotests -- Do you have more feedback cooking, or should I hit > the > > send button? > > I spotted another typo while browsing the web page (disconnect() "If > there were was an exception"), but I'm fine if you re-send, and I'll > Thanks for spotting that. Your proofreading ability is admired and appreciated :) > resume looking at the series on the updated v3. For 1-6, you can add: > > Reviewed-by: Eric Blake > > although my python is weak enough that you may want another set of > eyes as well. > > Thanks! Review on overall design, documentation, layout, organization and presentation is plenty helpful even if you aren't necessarily eagle-eyed on minutiae of Python. (Maybe especially if?) I've written quite a few tests and have used this library to run our entire iotests suite, plus Niteesh has been banging the bits pretty hard while working on aqmp-shell, so I am not too fearful of mechanical errors. --0000000000003079c505c8ab7903 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Tue, Aug 3, 2021 at 1:40 PM Eric Blake= <eblake@redhat.com> wrote:<= br>
On Tue, Aug 03, = 2021 at 01:34:32PM -0400, John Snow wrote:
> Got it. I was *just* about to send a refreshed version of this patchse= t
> because I found a new bug while on my way to making a sync compatibili= ty
> shim for iotests -- Do you have more feedback cooking, or should I hit= the
> send button?

I spotted another typo while browsing the web page (disconnect() "If there were was an exception"), but I'm fine if you re-send, and I&= #39;ll

Thanks for spotting that. Your p= roofreading ability is admired and appreciated :)
=C2=A0
resume looking at the series on the updated v3.=C2=A0 For 1-6, you can add:=

Reviewed-by: Eric Blake <eblake@redhat.com>

although my python is weak enough that you may want another set of
eyes as well.


Thanks! Review on overall design, docu= mentation, layout, organization and presentation is plenty helpful even if = you aren't necessarily eagle-eyed on minutiae of Python. (Maybe especia= lly if?)
I've written quite a few tests and have used this li= brary to run our entire iotests suite, plus Niteesh has been banging the bi= ts pretty hard while working on aqmp-shell, so I am not too fearful of mech= anical errors.
--0000000000003079c505c8ab7903--