From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCEC8C433F5 for ; Tue, 26 Oct 2021 19:47:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D30860C4A for ; Tue, 26 Oct 2021 19:47:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5D30860C4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:48546 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfSQ7-0000fq-7R for qemu-devel@archiver.kernel.org; Tue, 26 Oct 2021 15:47:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfSOm-0008Av-Hn for qemu-devel@nongnu.org; Tue, 26 Oct 2021 15:46:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:59715) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfSOj-0003N9-Bs for qemu-devel@nongnu.org; Tue, 26 Oct 2021 15:46:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635277571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A+JrhHmtAy3A79UqCNmaJUKBlyOQ7MBGPDnnGxAcagk=; b=J737Y/koxkqzMFTVGQul5Hzs6Ufc1mxK2mjG7uDwC5BOgFtWlTmLDBTc1oXvOLgLkrhvss Njju1LVdL/LZA+mxADaBWZcUsMql6J2oMrq0Fdezz5ZmPKj9XNgtv8eHxDB5pbyVwPIUVE y68l2+vEjQJ7jSjcTmXLUWg+G0W8fQY= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-174-32w0nZdvMSGZbzWryFcYMQ-1; Tue, 26 Oct 2021 15:46:09 -0400 X-MC-Unique: 32w0nZdvMSGZbzWryFcYMQ-1 Received: by mail-vk1-f199.google.com with SMTP id d11-20020ac5c54b000000b002dc649cb6b7so263739vkl.8 for ; Tue, 26 Oct 2021 12:46:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A+JrhHmtAy3A79UqCNmaJUKBlyOQ7MBGPDnnGxAcagk=; b=xusCZqSg5xl/mVmg0Zofw3KZ6KyYSLgveTyNS2/4J8NuethS52DXEq2IkxzWgD25eV xBBY1uGiNph1NkwDiRFMmt9qWWWOa7bh/FJBFT5QopUyKLmhty8lyJJIHJXcVbRWu6vr EEd3S52z7XSWKHGO4Dxu7gZ1YcApgsT6XnfOgPGZRvIKzGrlwQfL2Qc4HFaai/1g0jdK nJuurT2jdcvb1X6exGKOvj59vDpbdbTRB9q8Qn0nzVfzoRne7v/405nnXty9n2Q+Imq1 8vsIfT2bbXIlcXhxp5arkF1qoSW/blsty4cLJ/MEyIa4371z5q/zNMd0FiDdC1mPDB4r 26Tg== X-Gm-Message-State: AOAM531DNTbJrxUE3WDBd6FpVMFDX7c2dfSfLkRA4xs1MlyTJuejvXB7 BHlVBJJCHZnlC0peYFex1V2yNyQ/3vAWqntMLbNkCLai3cm+M93utI4ryQPZioZoSm6CicEbUWt ngBO0x4ZdeO/5VyRKbolq7Scd6VtX0is= X-Received: by 2002:a67:f685:: with SMTP id n5mr25721097vso.31.1635277569150; Tue, 26 Oct 2021 12:46:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyU9TifzMEQV4LUkOr1FTuFJpGRWJfrNdYDSyvBRmyuRL505nMzYpRQg3GB2D5oXwonkG0J1sqrMesqIRCULAg= X-Received: by 2002:a67:f685:: with SMTP id n5mr25721055vso.31.1635277568899; Tue, 26 Oct 2021 12:46:08 -0700 (PDT) MIME-Version: 1.0 References: <20211019144918.3159078-1-jsnow@redhat.com> <20211019144918.3159078-13-jsnow@redhat.com> In-Reply-To: From: John Snow Date: Tue, 26 Oct 2021 15:45:58 -0400 Message-ID: Subject: Re: [PATCH v2 12/15] iotests/linters: Add entry point for linting via Python CI To: Hanna Reitz Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000009a8d6205cf46ba8a" Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_BL_SPAMCOP_NET=1.347, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Eduardo Habkost , qemu-devel , qemu-block@nongnu.org, Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000009a8d6205cf46ba8a Content-Type: text/plain; charset="UTF-8" On Tue, Oct 26, 2021 at 2:36 PM John Snow wrote: > > > On Tue, Oct 26, 2021 at 6:57 AM Hanna Reitz wrote: > >> On 19.10.21 16:49, John Snow wrote: >> > We need at least a tiny little shim here to join test file discovery >> > with test invocation. This logic could conceivably be hosted somewhere >> > in python/, but I felt it was strictly the least-rude thing to keep the >> > test logic here in iotests/, even if this small function isn't itself an >> > iotest. >> > >> > Note that we don't actually even need the executable bit here, we'll be >> > relying on the ability to run this module as a script using Python CLI >> > arguments. No chance it gets misunderstood as an actual iotest that way. >> > >> > (It's named, not in tests/, doesn't have the execute bit, and doesn't >> > have an execution shebang.) >> > >> > Signed-off-by: John Snow >> > --- >> > tests/qemu-iotests/linters.py | 27 +++++++++++++++++++++++++++ >> > 1 file changed, 27 insertions(+) >> >> Reviewed-by: Hanna Reitz >> >> > Thanks! I'll endeavor to try and clean up the list of exempted files to > continue cleaning up this mess, but it's not a top priority right now. I'll > put it on the backburner after I finish typing the QAPI generator. A lot of > the weird compatibility goop will go away over time as I consolidate more > of the venv logic. > > (I think this series is good to go, now? I think it could be applied in > any order vs my other series. If you want, if/when you give the go-ahead > for the other series, I could just stage them both myself and make sure > they work well together and save you the headache.) > Update: I pre-emptively staged both series (the iotests one first, followed by the AQMP one) to jsnow/python and verified that all of the python tests pass for each commit between: [14] python-add-iotest-linters-to # python: Add iotest linters to test suite ... [22] python-iotests-replace-qmp # python, iotests: replace qmp with aqmp and I'm running the CI on all of that now at https://gitlab.com/jsnow/qemu/-/pipelines/396002744 (I just wanted to double-check they didn't conflict with each other in any unanticipated ways. Let me know if I should send the PR or if that'll just create hassle for you.) --js --0000000000009a8d6205cf46ba8a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Oct 26, 2021 at 2:36 PM John = Snow <jsnow@redhat.com> wrote= :


On Tue, Oct 26, 2021 at 6:57 AM Hanna Reitz <hreitz@redhat.com&g= t; wrote:
On 19.= 10.21 16:49, John Snow wrote:
> We need at least a tiny little shim here to join test file discovery > with test invocation. This logic could conceivably be hosted somewhere=
> in python/, but I felt it was strictly the least-rude thing to keep th= e
> test logic here in iotests/, even if this small function isn't its= elf an
> iotest.
>
> Note that we don't actually even need the executable bit here, we&= #39;ll be
> relying on the ability to run this module as a script using Python CLI=
> arguments. No chance it gets misunderstood as an actual iotest that wa= y.
>
> (It's named, not in tests/, doesn't have the execute bit, and = doesn't
> have an execution shebang.)
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>=C2=A0 =C2=A0tests/qemu-iotests/linters.py | 27 +++++++++++++++++++++++= ++++
>=C2=A0 =C2=A01 file changed, 27 insertions(+)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>


Thanks! I'll endeavor to try and c= lean up the list of exempted files to continue cleaning up this mess, but i= t's not a top priority right now. I'll put it on the backburner aft= er I finish typing the QAPI generator. A lot of the weird compatibility goo= p will go away over time as I consolidate more of the venv logic.

(I think this series is good to go, now? I think it could be appli= ed in any order vs my other series. If you want, if/when you give the go-ah= ead for the other series, I could just stage them both myself and make sure= they work well together and save you the headache.)
<= /blockquote>

Update: I pre-emptively staged both series = (the iotests one first, followed by the AQMP one) to jsnow/python and verif= ied that all of the python tests pass for each commit between:
[14] python-add-iotest-linters-to =C2=A0 # python: Add iotest = linters to test suite
...
[22] python-iotests-replace-qmp =C2= =A0 =C2=A0 # python, iotests: replace qmp with aqmp

and I'm running the CI on all of that now at https://gitlab.com/jsnow/qemu/-/pip= elines/396002744

(I just wanted to double-chec= k they didn't conflict with each other in any unanticipated ways. Let m= e know if I should send the PR or if that'll just create hassle for you= .)

--js
--0000000000009a8d6205cf46ba8a--