From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1899EC433F5 for ; Thu, 16 Dec 2021 17:11:28 +0000 (UTC) Received: from localhost ([::1]:60464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mxuHt-0003gf-KZ for qemu-devel@archiver.kernel.org; Thu, 16 Dec 2021 12:11:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxu8W-0000GT-Mk for qemu-devel@nongnu.org; Thu, 16 Dec 2021 12:01:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26489) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxu8T-00030f-6C for qemu-devel@nongnu.org; Thu, 16 Dec 2021 12:01:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639674100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6lhwKMkj8yactnSgHrI0ddH37aU2Wm4/1hxRogh5hLI=; b=htgkGYOelzEP8+DgIjO+7e9NncvXU//ddx1aAvKbmeXBSlMJPi7n2xi9G6dgdkWSdR1ZmR kM527ESmm+OBC4UsNMPK5mlNjXa/81PCyZI1fX5Ek9aIoBiH5IlfapFbuMujMMXYj14NAW OzAlQb7iHeEu+tpPXnIk+0Gwmf73w0c= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-528-YniEaB_SNMCNFntJMxMh9A-1; Thu, 16 Dec 2021 12:01:38 -0500 X-MC-Unique: YniEaB_SNMCNFntJMxMh9A-1 Received: by mail-ua1-f70.google.com with SMTP id v19-20020ab06793000000b002f305c90b69so15826316uar.18 for ; Thu, 16 Dec 2021 09:01:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6lhwKMkj8yactnSgHrI0ddH37aU2Wm4/1hxRogh5hLI=; b=lB/qHHbX1Ut1QKn7CPL+Xbf5eQ8q7XMQUHBeoOHym2qJmfqqU8/EZTHTsRrYGGVBaf 06WvPsMr4jK8xt+9W4MzKEmtjbYL+I6Hzy2Wl3pFHJXY0bteYAYhE/Sispivw9gVfx1c r1P/7y0pqJ1CMTQJGVTb5AX3/N/attKAM4l+eBPpKw9c/PxFdoT0YZEGUU1Yab6Kk83X Pu9aSpusXyxiK4gIPDPCgMUuO9v+7pupkvFvnbNb7qSR1545+vTqLlLgy/cD+cXJefPz tZDuCr5NzMqj0SN8kcRWP4FtbBh/nTFUhDCCChlbdgI+18mtsoznIqBRyUqvy9L6vN4M e3Tw== X-Gm-Message-State: AOAM533UFPsbTQ/qPrnC9nd/QJaMmp9StbJOceeqlLaDgaYxH2adUE/F fMZkJDdqee8F+/rii3gyr4v7BNynleryDBT9V+e9rUHejqsT+AVvflEgQX1TJg3HHP0enpulMtA oLMSbsX7q6/QX2XaCvtXNbanyUmPWLJs= X-Received: by 2002:a05:6102:1ca:: with SMTP id s10mr6071891vsq.61.1639674097219; Thu, 16 Dec 2021 09:01:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJxYfRuCZ/+cze2LVc+RbyWX6Nh6ArZcDc4P5hsX7s/1C7ZFNN6e3TBWS5+VziKjhWsxUCs86KUX/4xyeerfjAo= X-Received: by 2002:a05:6102:1ca:: with SMTP id s10mr6071863vsq.61.1639674096991; Thu, 16 Dec 2021 09:01:36 -0800 (PST) MIME-Version: 1.0 References: <20211215193939.3768033-1-jsnow@redhat.com> <20211215193939.3768033-6-jsnow@redhat.com> In-Reply-To: From: John Snow Date: Thu, 16 Dec 2021 12:01:26 -0500 Message-ID: Subject: Re: [PATCH v2 05/25] python/aqmp: rename AQMPError to QMPError To: Vladimir Sementsov-Ogievskiy Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000019578105d346607f" Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.718, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Kevin Wolf , Daniel Berrange , Beraldo Leal , Qemu-block , Markus Armbruster , qemu-devel , Wainer Moschetta , Andrea Bolognani , Hanna Reitz , Gerd Hoffmann , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000019578105d346607f Content-Type: text/plain; charset="UTF-8" On Thu, Dec 16, 2021 at 5:09 AM Vladimir Sementsov-Ogievskiy < vsementsov@virtuozzo.com> wrote: > 15.12.2021 22:39, John Snow wrote: > > This is in preparation for renaming qemu.aqmp to qemu.qmp. I should have > > done this from this from the very beginning, but it's a convenient time > > to make sure this churn is taken care of. > > > > Signed-off-by: John Snow > > Honestly, I don't want to check how it intersects with exising QMPError > from old library, as it's going to be removed anyway. Hope, everything is > OK: > > it's all namespaced, and it doesn't appear to conflict in practice. > Reviewed-by: Vladimir Sementsov-Ogievskiy > > --- > > python/qemu/aqmp/__init__.py | 6 +++--- > > python/qemu/aqmp/error.py | 12 ++++++------ > > python/qemu/aqmp/events.py | 4 ++-- > > python/qemu/aqmp/legacy.py | 4 ++-- > > python/qemu/aqmp/protocol.py | 8 ++++---- > > python/qemu/aqmp/qmp_client.py | 8 ++++---- > > 6 files changed, 21 insertions(+), 21 deletions(-) > > > > diff --git a/python/qemu/aqmp/__init__.py b/python/qemu/aqmp/__init__.py > > index c6fa2dda58..e1efab00af 100644 > > --- a/python/qemu/aqmp/__init__.py > > +++ b/python/qemu/aqmp/__init__.py > > @@ -6,7 +6,7 @@ > > QEMU Guest Agent, and the QEMU Storage Daemon. > > > > `QMPClient` provides the main functionality of this package. All errors > > -raised by this library dervive from `AQMPError`, see `aqmp.error` for > > +raised by this library dervive from `QMPError`, see `aqmp.error` for > > preexisting: s/dervive/derive/ > > Whoops. I'll add a patch to fix it. Thanks. --00000000000019578105d346607f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Dec 16, 2021 at 5:09 AM Vladi= mir Sementsov-Ogievskiy <vse= mentsov@virtuozzo.com> wrote:
15.12.2021 22:39, John Snow wrote:
> This is in preparation for renaming qemu.aqmp to qemu.qmp. I should ha= ve
> done this from this from the very beginning, but it's a convenient= time
> to make sure this churn is taken care of.
>
> Signed-off-by: John Snow <jsnow@redhat.com>

Honestly, I don't want to check how it intersects with exising QMPError= from old library, as it's going to be removed anyway. Hope, everything= is OK:


it's all namespaced, and it doesn&= #39;t appear to conflict in practice.
=C2=A0
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>=C2=A0 =C2=A0python/qemu/aqmp/__init__.py=C2=A0 =C2=A0|=C2=A0 6 +++---<= br> >=C2=A0 =C2=A0python/qemu/aqmp/error.py=C2=A0 =C2=A0 =C2=A0 | 12 ++++++-= -----
>=C2=A0 =C2=A0python/qemu/aqmp/events.py=C2=A0 =C2=A0 =C2=A0|=C2=A0 4 ++= --
>=C2=A0 =C2=A0python/qemu/aqmp/legacy.py=C2=A0 =C2=A0 =C2=A0|=C2=A0 4 ++= --
>=C2=A0 =C2=A0python/qemu/aqmp/protocol.py=C2=A0 =C2=A0|=C2=A0 8 ++++---= -
>=C2=A0 =C2=A0python/qemu/aqmp/qmp_client.py |=C2=A0 8 ++++----
>=C2=A0 =C2=A06 files changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/python/qemu/aqmp/__init__.py b/python/qemu/aqmp/__init__.= py
> index c6fa2dda58..e1efab00af 100644
> --- a/python/qemu/aqmp/__init__.py
> +++ b/python/qemu/aqmp/__init__.py
> @@ -6,7 +6,7 @@
>=C2=A0 =C2=A0QEMU Guest Agent, and the QEMU Storage Daemon.
>=C2=A0 =C2=A0
>=C2=A0 =C2=A0`QMPClient` provides the main functionality of this packag= e. All errors
> -raised by this library dervive from `AQMPError`, see `aqmp.error` for=
> +raised by this library dervive from `QMPError`, see `aqmp.error` for<= br>
preexisting: s/dervive/derive/


Whoops. I'll add a patch to fix it= . Thanks.
--00000000000019578105d346607f--