From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32514C4338F for ; Wed, 4 Aug 2021 18:06:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D74660C41 for ; Wed, 4 Aug 2021 18:06:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9D74660C41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:58246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBLHL-0000CX-Pc for qemu-devel@archiver.kernel.org; Wed, 04 Aug 2021 14:06:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBJb4-0004SJ-00 for qemu-devel@nongnu.org; Wed, 04 Aug 2021 12:18:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:49357) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBJan-0006tu-TU for qemu-devel@nongnu.org; Wed, 04 Aug 2021 12:18:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628093876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dHcj71k7Ng8+HRI7S+50vRSgPLdtMqRxdHSl5n21Yn0=; b=TXA1DhLioukG89V40ELe2mqNf0Lf/mreZY6MHwp9SfCcGI4hAW4ApXTKFGp5h3+UgoomIS fQcTRGji4LFq7+XJkbaJjYFH0jZXfDc+41D2kZ1OCPg+8k77QWU/mZ1/6K/Ytul1nHRhrw YqBeKoNYRRaQXvkp6J7d/UxVJHpqwSk= Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-170-ZtS9tP4HOGmlf6JpeGUMeA-1; Wed, 04 Aug 2021 12:17:52 -0400 X-MC-Unique: ZtS9tP4HOGmlf6JpeGUMeA-1 Received: by mail-ot1-f71.google.com with SMTP id z11-20020a056830290bb02904d1d78ee61cso999869otu.3 for ; Wed, 04 Aug 2021 09:17:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dHcj71k7Ng8+HRI7S+50vRSgPLdtMqRxdHSl5n21Yn0=; b=M6VqxTefhjyAaYMypJfv9t7yhHFLmKyHsltnySJqfv5/VvAchrzNwFoE6XzuiRTXoI kzxqUDgrVYKlLrYafopsCzWgulx7J35kjsbBOSX7KqlyNnbEvTY0STHIA4C8g8JBwFTW 4Uk0RusLL5QQnwv8cXfqwTgRhpYXe6B3QSnIW8TgSpz5kJSwNMyYLaTGp0A0/nCrUXWn FWWjBNeOSTOABH3YQKacnPHUq7gAw9G962aXAAITrLt7CMZk08nPI3u+dsK+GDn7ZwJj dOVYlL6qg+10v9gJu2hKlLWGj7g+E0f0dymVdBp6n9ylX+/4TR+UX1Usn/VGY2/A3RzR bx5A== X-Gm-Message-State: AOAM53328NMG2C0kl3uE1uT41JD7LiodCyRiZ5RcrsDKazUrnfg+m4wp ZG8E5kNECnbov0BF3rn+69hw7gS/SDZGuklUYE0Hi+NUCMbM9ib1HIo/reFtsdRqgPYQMZmG2UP wHFrjm9A+qHGztcr4OpXdf4IlAb6ygC8= X-Received: by 2002:a05:6830:1604:: with SMTP id g4mr407247otr.45.1628093872037; Wed, 04 Aug 2021 09:17:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0Ru1j5JHnMcXaI/UoQEcWTq6pEzL/HK8C/ixxupnEU4CmiK6K4Xel0FVoZjL2DPYUjUg41pUw+6KUeGy0u+s= X-Received: by 2002:a05:6830:1604:: with SMTP id g4mr407237otr.45.1628093871843; Wed, 04 Aug 2021 09:17:51 -0700 (PDT) MIME-Version: 1.0 References: <20210804093813.20688-1-vsementsov@virtuozzo.com> <20210804093813.20688-30-vsementsov@virtuozzo.com> In-Reply-To: <20210804093813.20688-30-vsementsov@virtuozzo.com> From: John Snow Date: Wed, 4 Aug 2021 12:17:41 -0400 Message-ID: Subject: Re: [PATCH v7 29/33] iotests.py: hmp_qemu_io: support qdev To: Vladimir Sementsov-Ogievskiy Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000e47b8805c8be24be" Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Daniel Berrange , Eduardo Habkost , qemu-block@nongnu.org, qemu-devel , Markus Armbruster , Cleber Rosa , Paolo Bonzini , Max Reitz , Eric Blake Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000e47b8805c8be24be Content-Type: text/plain; charset="UTF-8" On Wed, Aug 4, 2021 at 5:39 AM Vladimir Sementsov-Ogievskiy < vsementsov@virtuozzo.com> wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > --- > tests/qemu-iotests/iotests.py | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py > index 025e288ddd..9d0031a0e8 100644 > --- a/tests/qemu-iotests/iotests.py > +++ b/tests/qemu-iotests/iotests.py > @@ -655,9 +655,10 @@ def resume_drive(self, drive: str) -> None: > self.hmp(f'qemu-io {drive} "remove_break bp_{drive}"') > > def hmp_qemu_io(self, drive: str, cmd: str, > - use_log: bool = False) -> QMPMessage: > + use_log: bool = False, qdev: bool = False) -> > QMPMessage: > """Write to a given drive using an HMP command""" > - return self.hmp(f'qemu-io {drive} "{cmd}"', use_log=use_log) > + d = '-d ' if qdev else '' > + return self.hmp(f'qemu-io {d}{drive} "{cmd}"', use_log=use_log) > > def flatten_qmp_object(self, obj, output=None, basestr=''): > if output is None: > -- > 2.29.2 > > Guess that's really the only flag that this HMP command supports. I was gonna suggest abstracting to {args} ... but, uh, that's the only one, so... sure! Reviewed-by: John Snow --000000000000e47b8805c8be24be Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Wed, Aug 4, 2021 at 5:39 AM Vladimir S= ementsov-Ogievskiy <vsements= ov@virtuozzo.com> wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com= >
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
=C2=A0tests/qemu-iotests/iotests.py | 5 +++--
=C2=A01 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py<= br> index 025e288ddd..9d0031a0e8 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -655,9 +655,10 @@ def resume_drive(self, drive: str) -> None:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.hmp(f'qemu-io {drive} "remo= ve_break bp_{drive}"')

=C2=A0 =C2=A0 =C2=A0def hmp_qemu_io(self, drive: str, cmd: str,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 use_= log: bool =3D False) -> QMPMessage:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 use_= log: bool =3D False, qdev: bool =3D False) -> QMPMessage:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""Write to a given drive = using an HMP command"""
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 return self.hmp(f'qemu-io {drive} "{c= md}"', use_log=3Duse_log)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 d =3D '-d ' if qdev else '' +=C2=A0 =C2=A0 =C2=A0 =C2=A0 return self.hmp(f'qemu-io {d}{drive} "= ;{cmd}"', use_log=3Duse_log)

=C2=A0 =C2=A0 =C2=A0def flatten_qmp_object(self, obj, output=3DNone, basest= r=3D''):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if output is None:
--
2.29.2


Guess that's really the only flag = that this HMP command supports. I was gonna suggest abstracting to {args} .= .. but, uh, that's the only one, so... sure!

R= eviewed-by: John Snow <jsnow@redhat.= com>

--000000000000e47b8805c8be24be--