From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FBB0C433F5 for ; Fri, 24 Sep 2021 18:16:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B7D861164 for ; Fri, 24 Sep 2021 18:16:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0B7D861164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:57228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTpkC-0002z6-Vi for qemu-devel@archiver.kernel.org; Fri, 24 Sep 2021 14:16:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTphV-0000GT-Gc for qemu-devel@nongnu.org; Fri, 24 Sep 2021 14:13:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27604) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTphN-0001VE-WC for qemu-devel@nongnu.org; Fri, 24 Sep 2021 14:13:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632507205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b6Wf/TckMBSw2ULqGU1Lcy3DNNBXDI2aInXYO+6nBAo=; b=Yy8AKJlvOwkgXLKmulrpmA01GSI03p9QxFpV7CFHjinbfzc8sKNb9zWDumCaMi9x30lXIH R/2MEIPHPr/MT6lWFq4Ta3OnwKwjT4F0nukMUidBRxRjzTVcVc07fxVYM+oIRjFa+kE1D/ I4rGu/gQTXy4Jfi4N+FOnLdFGGzrmV4= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-vgjszvUzNHyOcVGhfscsZg-1; Fri, 24 Sep 2021 14:13:23 -0400 X-MC-Unique: vgjszvUzNHyOcVGhfscsZg-1 Received: by mail-ot1-f69.google.com with SMTP id i7-20020a9d6507000000b0051c10643794so6946769otl.22 for ; Fri, 24 Sep 2021 11:13:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b6Wf/TckMBSw2ULqGU1Lcy3DNNBXDI2aInXYO+6nBAo=; b=dSw+kuzUf6x+goX8007zPWCbFkR4v6W6zLspMu3Y36JadRjl0wD5Qc9OqubJrhE2ih FP5/7w+CPwQL//sSACEx/8WduYst6QLrwjxVAR1rs9o1+snP/9Ms3NkIUCOI73gYfIzw f0nmRftn5dJRAubErTOSM5j96SYKJlki2bTTuL+wPhkzjBpIJmEbcWHE6GIDAq98rCBC Nj/3ejr9iIcerFsy+SQ9fRrPihmFM1dt8g3CyjTQrfoKnbP72ch5DvXzVIhxQwAPD4VV 6UyH5Xrs5U75pkzGnk4eSRhW7TOHOK95xDf6bfMFoKuHKJYMhvUFXWEirHwRa5z2HwV6 +4VA== X-Gm-Message-State: AOAM532YTJ1SH1NB7ZUQScwX9SaMIE2ynjkX/PwVR9XXr+DUIKWKSuXu w9RggvHzK+tESsPP35t6Pn0edzZ7pY8CWicVa80SAAbKxBP7RifVO7tGiPZ6L2lgVcbN2kngJ9H uiYVT/pnwel2ivhPWN0K1LVwlYSQSoro= X-Received: by 2002:a05:6830:13c5:: with SMTP id e5mr5200133otq.374.1632507202534; Fri, 24 Sep 2021 11:13:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAALhsuOO2efwjH5x0WohHKFtasA6++DNKd+2XA4bTHl67LzVoXJj2Ur0lP98Qud+sfFHTy9cUwbPkYqOjg/A= X-Received: by 2002:a05:6830:13c5:: with SMTP id e5mr5200117otq.374.1632507202308; Fri, 24 Sep 2021 11:13:22 -0700 (PDT) MIME-Version: 1.0 References: <20210923180715.4168522-1-jsnow@redhat.com> In-Reply-To: <20210923180715.4168522-1-jsnow@redhat.com> From: John Snow Date: Fri, 24 Sep 2021 14:13:11 -0400 Message-ID: Subject: Re: [PATCH v2 0/6] iotests: update environment and linting configuration To: Kevin Wolf Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000e325e205ccc1b3c9" Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.473, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hanna Reitz , Vladimir Sementsov-Ogievskiy , Daniel Berrange , qemu-devel , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000e325e205ccc1b3c9 Content-Type: text/plain; charset="UTF-8" On Thu, Sep 23, 2021 at 2:07 PM John Snow wrote: > GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-package-iotest-pt1 > CI: https://gitlab.com/jsnow/qemu/-/pipelines/376236687 > > This series partially supersedes: > [PATCH v3 00/16] python/iotests: Run iotest linters during Python CI' > > Howdy, this is good stuff we want even if we aren't yet in agreement > about the best way to run iotest 297 from CI. > > - Update linting config to tolerate pylint 2.11.1 > - Eliminate sys.path hacking in individual test files > - make mypy execution in test 297 faster > > The rest of the actual "run at CI time" stuff can get handled separately > and later pending some discussion on the other series. > > V2: > > 001/6:[0011] [FC] 'iotests: add 'qemu' package location to PYTHONPATH in > testenv' > 002/6:[0025] [FC] 'iotests: add warning for rogue 'qemu' packages' > > - Squashed in a small optimization from Vladimir to 001, kept R-Bs. > - Fixed the package detection logic to not panic if it can't find > 'qemu' at all (kwolf) > - Updated commit messages for the first two patches. > > --js > > John Snow (6): > iotests: add 'qemu' package location to PYTHONPATH in testenv > iotests: add warning for rogue 'qemu' packages > iotests/linters: check mypy files all at once > iotests/mirror-top-perms: Adjust imports > iotests/migrate-bitmaps-test: delint > iotests: Update for pylint 2.11.1 > > tests/qemu-iotests/235 | 2 - > tests/qemu-iotests/297 | 50 ++++++++----------- > tests/qemu-iotests/300 | 7 ++- > tests/qemu-iotests/iotests.py | 2 - > tests/qemu-iotests/pylintrc | 6 ++- > tests/qemu-iotests/testenv.py | 39 ++++++++++++--- > tests/qemu-iotests/testrunner.py | 7 +-- > tests/qemu-iotests/tests/migrate-bitmaps-test | 50 +++++++++++-------- > tests/qemu-iotests/tests/mirror-top-perms | 12 ++--- > 9 files changed, 99 insertions(+), 76 deletions(-) > > -- > 2.31.1 > > > Patch 2 can just be dropped, and everything else is reviewed, so I think this can be staged at your leisure. --js --000000000000e325e205ccc1b3c9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Sep 23, 2021 at 2:07 PM John = Snow <jsnow@redhat.com> wrote= :
GitLab: https://gitlab.com/jsnow/qemu/-/commits/p= ython-package-iotest-pt1
CI: https://gitlab.com/jsnow/qemu/-/pipelines/376= 236687

This series partially supersedes:
=C2=A0 [PATCH v3 00/16] python/iotests: Run iotest linters during Python CI= '

Howdy, this is good stuff we want even if we aren't yet in agreement about the best way to run iotest 297 from CI.

- Update linting config to tolerate pylint 2.11.1
- Eliminate sys.path hacking in individual test files
- make mypy execution in test 297 faster

The rest of the actual "run at CI time" stuff can get handled sep= arately
and later pending some discussion on the other series.

V2:

001/6:[0011] [FC] 'iotests: add 'qemu' package location to PYTH= ONPATH in testenv'
002/6:[0025] [FC] 'iotests: add warning for rogue 'qemu' packag= es'

- Squashed in a small optimization from Vladimir to 001, kept R-Bs.
- Fixed the package detection logic to not panic if it can't find
=C2=A0 'qemu' at all (kwolf)
- Updated commit messages for the first two patches.

--js

John Snow (6):
=C2=A0 iotests: add 'qemu' package location to PYTHONPATH in testen= v
=C2=A0 iotests: add warning for rogue 'qemu' packages
=C2=A0 iotests/linters: check mypy files all at once
=C2=A0 iotests/mirror-top-perms: Adjust imports
=C2=A0 iotests/migrate-bitmaps-test: delint
=C2=A0 iotests: Update for pylint 2.11.1

=C2=A0tests/qemu-iotests/235=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 2 -
=C2=A0tests/qemu-iotests/297=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 50 ++++++++-----------
=C2=A0tests/qemu-iotests/300=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 7 ++-
=C2=A0tests/qemu-iotests/iotests.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 2 -
=C2=A0tests/qemu-iotests/pylintrc=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 6 ++-
=C2=A0tests/qemu-iotests/testenv.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0| 39 ++++++++++++---
=C2=A0tests/qemu-iotests/testrunner.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 |=C2=A0 7 +--
=C2=A0tests/qemu-iotests/tests/migrate-bitmaps-test | 50 +++++++++++-------= -
=C2=A0tests/qemu-iotests/tests/mirror-top-perms=C2=A0 =C2=A0 =C2=A0| 12 ++-= --
=C2=A09 files changed, 99 insertions(+), 76 deletions(-)

--
2.31.1



Patch 2 can just be dropped, and every= thing else is reviewed, so I think this can be staged at your leisure.
<= /div>

--js
--000000000000e325e205ccc1b3c9--