Re: [PATCH v2 09/12] python: add 'make check-dev' invocation

[John Snow <jsnow@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2113 bytes --]

On Tue, Jun 29, 2021 at 1:34 PM Wainer dos Santos Moschetta <
wainersm@redhat.com> wrote:

>
> On 6/29/21 1:42 PM, John Snow wrote:
> > This is a *third* way to run the Python tests. Unlike the first two
> > (check-pipenv, check-tox), this version does not require any specific
> > interpreter version -- making it a lot easier to tell people to run it
> > as a quick smoketest prior to submission to GitLab CI.
> >
> > Summary:
> >
> >    Checked via GitLab CI:
> >      - check-pipenv: tests our oldest python & dependencies
> >      - check-tox: tests newest dependencies on all non-EOL python
> versions
> >    Executed only incidentally:
> >      - check-dev: tests newest dependencies on whichever python version
> >
> > ('make check' does not set up any environment at all, it just runs the
> > tests in your current environment. All four invocations perform the
> > exact same tests, just in different execution environments.)
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> >   python/Makefile | 35 +++++++++++++++++++++++++++++++++--
> >   1 file changed, 33 insertions(+), 2 deletions(-)
> >
> > diff --git a/python/Makefile b/python/Makefile
> > index d34c4e35d9..8f8e1999c0 100644
> > --- a/python/Makefile
> > +++ b/python/Makefile
> > @@ -1,3 +1,5 @@
> > +QEMU_VENV_DIR=.dev-venv
> > +
>
> I gave `make check-dev` a try and `tests/flake8.sh` failed, because it
> is checking the python sources from the $QEMU_VENV_DIR itself.
>
> Either we keep $QEMU_VENV_DIR outside (as in the v1 series) or ...
>
>    diff --git a/python/tests/flake8.sh b/python/tests/flake8.sh
>    index 51e0788462..1cd7d40fad 100755
>    --- a/python/tests/flake8.sh
>    +++ b/python/tests/flake8.sh
>    @@ -1,2 +1,2 @@
>     #!/bin/sh -e
>    -python3 -m flake8
>    +python3 -m flake8 qemu/
>
> ... to ensure flake8 parses only the files from the 'qemu' directory
> (btw, this is how tests/pylint.sh is configured). I prefer the later.
>

Augh, oops. Good spot ...

OK, i'll just update the canonical flake8 invocation instead. I can remove
the .venv and .tox stuff in the flake8 section in setup.cfg, too.

[-- Attachment #2: Type: text/html, Size: 2835 bytes --]