From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A728C3A5A6 for ; Mon, 23 Sep 2019 08:48:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4631D20820 for ; Mon, 23 Sep 2019 08:48:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="itq2CRxz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4631D20820 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=nongnu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCK0l-0006bQ-7j for qemu-devel@archiver.kernel.org; Mon, 23 Sep 2019 04:47:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45590) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCJdU-0000Bg-C4 for qemu-devel@nongnu.org; Mon, 23 Sep 2019 04:23:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCJdS-0005zC-VO for qemu-devel@nongnu.org; Mon, 23 Sep 2019 04:23:56 -0400 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]:36313) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iCJdS-0005yc-P6 for qemu-devel@nongnu.org; Mon, 23 Sep 2019 04:23:54 -0400 Received: by mail-qk1-x741.google.com with SMTP id y189so14472153qkc.3 for ; Mon, 23 Sep 2019 01:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zup5OGjRbCC5y3n0ahrU1EueS2lu3LX/Bqx9s4Gt/2g=; b=itq2CRxzraAJu+//qZiNpTMbhEXJSLP8V1lALxxFWSKAkS310btzkD70mLZ3lMFhah yFRspVPO4cteyqJPcoDhlIrcKPNKT7XJ3UCjdAB+qTwm1aqpWhM19mR4Ppe9BEnkQ/I8 T37BLQdnkP4ZcHr/I5cakIbVnHAjcCbOlO3np+uITURD1jpx92GsMl4Axys1PDy4bglM PswXpHYCS2edC06nSuAsuCMSC2bOjB7k3HRDCY56DY/Uped9XcM3Ab+ezTGeiOLdfhcJ oEhd4wR5xIN8Z6QE1192VErk3bFAfCku4vnF7moGVhUfA+Dun9297g17PDMjWu8ecEp8 1GJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zup5OGjRbCC5y3n0ahrU1EueS2lu3LX/Bqx9s4Gt/2g=; b=Kkm23akj5DQsIpqrgNmeCOylWBWPDj9aUCq21N0O39vYzl4a+odhG32OnBKNjMMr/G zTYpYxITagYRk7vPHWuViQJPxAs2N0FHFPeKs4lwcN1s0E50e/u5tTq6kOR8qpazZNvn VPDBRbB3bqCRTxQNuCQufIBJY9iEGrrRJzv9vrZqm5FAZL8V03CRicdFrNUxJYSStiAK 6RDboFG/OoI+pHuPMTI8cCJkEkjaOpdk5R1oGHTYWeYT3wyktNa28fLuU9wv84x2XpjQ Vs726TGFVJKBygA97Jr9/a1MB3bz88NCOyEf3N0XlXH7D9KAU9zhKQdNFSOmwlsOd4O4 xfnQ== X-Gm-Message-State: APjAAAXe/d+oivDKtdyDXE2W8vx1ZtRKyEIsssM35reu1m3cE8+8gyey xrEVAISY4pc/TzAdB5zWZC8r3Pxk+JjZ5u6oRodWrEUU X-Google-Smtp-Source: APXvYqyB6HCUztMzv7U2NekC9ZcVe5ksO/AStIyrWwFmODwWjwEd/pcZeN4AUc/n2zNrmELLSCtmoZsCAZMtJgU9Rvw= X-Received: by 2002:a37:bd45:: with SMTP id n66mr15420969qkf.272.1569227032943; Mon, 23 Sep 2019 01:23:52 -0700 (PDT) MIME-Version: 1.0 References: <20190827082427.64280-1-sameid@google.com> In-Reply-To: Date: Mon, 23 Sep 2019 11:23:41 +0300 Message-ID: Subject: Re: [PATCH v6 0/8] Add Qemu to SeaBIOS LCHS interface To: qemu-devel@nongnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::741 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-block@nongnu.org, seabios@seabios.org, Kevin OConnor , liran.alon@oracle.com, kraxel@redhat.com, Karl Heubaum Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: Sam Eiderman From: Sam Eiderman via Gentle ping On Wed, Sep 11, 2019 at 5:36 PM Sam Eiderman wrote: > > Gentle ping > > On Tue, Aug 27, 2019, 11:24 Sam Eiderman wrote: >> >> v1: >> >> Non-standard logical geometries break under QEMU. >> >> A virtual disk which contains an operating system which depends on >> logical geometries (consistent values being reported from BIOS INT13 >> AH=08) will most likely break under QEMU/SeaBIOS if it has non-standard >> logical geometries - for example 56 SPT (sectors per track). >> No matter what QEMU will guess - SeaBIOS, for large enough disks - will >> use LBA translation, which will report 63 SPT instead. >> >> In addition we can not enforce SeaBIOS to rely on phyiscal geometries at >> all. A virtio-blk-pci virtual disk with 255 phyiscal heads can not >> report more than 16 physical heads when moved to an IDE controller, the >> ATA spec allows a maximum of 16 heads - this is an artifact of >> virtualization. >> >> By supplying the logical geometies directly we are able to support such >> "exotic" disks. >> >> We will use fw_cfg to do just that. >> >> v2: >> >> Fix missing parenthesis check in >> "hd-geo-test: Add tests for lchs override" >> >> v3: >> >> * Rename fw_cfg key to "bios-geometry". >> * Remove "extendible" interface. >> * Add cpu_to_le32 fix as Laszlo suggested or big endian hosts >> * Fix last qtest commit - automatic docker tester for some reason does not have qemu-img set >> >> v4: >> >> * Change fw_cfg interface from mixed textual/binary to textual only >> >> v5: >> >> * Fix line > 80 chars in tests/hd-geo-test.c >> >> v6: >> >> * Small fixes for issues pointed by Max >> * (&conf->conf)->lcyls to conf->conf.lcyls and so on >> * Remove scsi_unrealize from everything other than scsi-hd >> * Add proper include to sysemu.h >> * scsi_device_unrealize() after scsi_device_purge_requests() >> >> Sam Eiderman (8): >> block: Refactor macros - fix tabbing >> block: Support providing LCHS from user >> bootdevice: Add interface to gather LCHS >> scsi: Propagate unrealize() callback to scsi-hd >> bootdevice: Gather LCHS from all relevant devices >> bootdevice: Refactor get_boot_devices_list >> bootdevice: FW_CFG interface for LCHS values >> hd-geo-test: Add tests for lchs override >> >> bootdevice.c | 148 ++++++++-- >> hw/block/virtio-blk.c | 6 + >> hw/ide/qdev.c | 7 +- >> hw/nvram/fw_cfg.c | 14 +- >> hw/scsi/scsi-bus.c | 16 ++ >> hw/scsi/scsi-disk.c | 12 + >> include/hw/block/block.h | 22 +- >> include/hw/scsi/scsi.h | 1 + >> include/sysemu/sysemu.h | 4 + >> tests/Makefile.include | 2 +- >> tests/hd-geo-test.c | 582 +++++++++++++++++++++++++++++++++++++++ >> 11 files changed, 773 insertions(+), 41 deletions(-) >> >> -- >> 2.23.0.187.g17f5b7556c-goog >>