From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2FC9C43331 for ; Wed, 13 Nov 2019 15:05:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA5B3222D3 for ; Wed, 13 Nov 2019 15:05:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mt4jMJD6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA5B3222D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUuD6-0006eY-TZ for qemu-devel@archiver.kernel.org; Wed, 13 Nov 2019 10:05:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59834) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUuBy-0006BR-Ja for qemu-devel@nongnu.org; Wed, 13 Nov 2019 10:04:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUuBs-0007np-CT for qemu-devel@nongnu.org; Wed, 13 Nov 2019 10:04:21 -0500 Received: from mail-qv1-xf41.google.com ([2607:f8b0:4864:20::f41]:36501) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iUuBs-0007mc-08 for qemu-devel@nongnu.org; Wed, 13 Nov 2019 10:04:16 -0500 Received: by mail-qv1-xf41.google.com with SMTP id cv8so772765qvb.3 for ; Wed, 13 Nov 2019 07:04:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9BzBQdGpdDldyAJp0pfSmKIoynEYxRw2R3kxt4neugk=; b=mt4jMJD6WMdbir6vXTPqHeiy+dzhbI58QNZladSjKT5Kifh/V41EVMEY953FoPwWAp AaBWzHiCZNbtMsxbU3jkDNWU3TFolpiMrT0iTeuBn3ER3lgC2ZjO/nTaPQ4HREMVpRtx wiS456Wpa7styW9aokGoPMPyGQe+mnvsey6pQMZ/c1FwISFg0k2nZQ0VebRZizJdX7nR UM8hZsJ67rsgPhe+ESK3A6OcBLXuLPNDqio6dpWqTyj1zRmWN2amZ7CBHj7vf0kNV0kG KXhHmFoOXHHA/+7P4mCkvExvTF1b9+qmuRNjnRa7AYFPoFlhf3waNAuXzclquQidXC33 abHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9BzBQdGpdDldyAJp0pfSmKIoynEYxRw2R3kxt4neugk=; b=FqcZEfZzD1MsbWVcwGRqW+RRsYfn2TneP8bixtsaRwbMtD2/4j6obyuy6MMPLH2l2Q gRaVL0hT25Bana5ghnPcFQYt9f9ske2iDZK3AG7O/A5bLEtCk/K6wrwwiZUyNKGLnDCw vDon6n/NCTcVnt2h8DddkhrlF96QTveEDq5OQn/e9eWC8CPZNnJCES4xZ1Ci3kH/RmUl 5ywaTnLYPXJdHPxvUuHHQ3qH7LqEGFe1V8k2O+dJW1QRju7Czn9rK4qmGFWoPxmX+kzv cO9LfbkxSnIBFNW3FXXT4IPuozSGdd5Z8K+fEk5yrA6R0LJ/dyrW0kQJmHkX8SJDyb0W 0mFg== X-Gm-Message-State: APjAAAW/aDM2tZNauMHmEeJfDDMkNn3qas/ujVEVdz+710AfHg3eTMwZ rRFFhf8ghtw3hf1/B+uvzq5OYOloRWX3SwSEh/hXZw== X-Google-Smtp-Source: APXvYqwwYozt2tyKkgeedoW75m9/KTbcIjod/oR3LCzA7SCU3dcXD1z/skn4fvIOidf34vSYqpSBMw/xIBUyjfCJc+0= X-Received: by 2002:ad4:4092:: with SMTP id l18mr3085552qvp.114.1573657451648; Wed, 13 Nov 2019 07:04:11 -0800 (PST) MIME-Version: 1.0 References: <20191113091809.31365-1-kraxel@redhat.com> <84d3a1aa-bbb2-d831-0abc-fe1169f8a860@redhat.com> <20191113140057.2ocwfa3rqqfkbg3r@sirius.home.kraxel.org> In-Reply-To: <20191113140057.2ocwfa3rqqfkbg3r@sirius.home.kraxel.org> From: Sam Eiderman Date: Wed, 13 Nov 2019 17:03:58 +0200 Message-ID: Subject: Re: [SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct To: Gerd Hoffmann Cc: Laszlo Ersek , seabios@seabios.org, Peter Maydell , qemu-devel@nongnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::f41 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, Does this fix a bug that actually happened? I just noticed that in my lchs patches I assumed that lchs struct is zeroed out in all devices (not only ahci): 9caa19be0e53 (geometry: Apply LCHS values for boot devices) Seems like this is not the case but why only ahci is affected? The list of devices is at least: * ata * ahci * scsi * esp * lsi * megasas * mpt * pvscsi * virtio * virtio-blk As specified in the commit message. Also Gerd it seems that my lchs patches were not committed in the latest submitted version (v4)!!! The ABI of the fw config key is completely broken. On Wed, Nov 13, 2019 at 4:02 PM Gerd Hoffmann wrote: > > On Wed, Nov 13, 2019 at 10:35:03AM +0100, Laszlo Ersek wrote: > > On 11/13/19 10:18, Gerd Hoffmann wrote: > > > Specifically port->driver.lchs needs clearing, otherwise seabios will > > > > s/driver/drive/ > > > Reviewed-by: Laszlo Ersek > > Typo fixed & pushed. > > thanks, > Gerd > _______________________________________________ > SeaBIOS mailing list -- seabios@seabios.org > To unsubscribe send an email to seabios-leave@seabios.org