From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWjkF-0000wR-2R for qemu-devel@nongnu.org; Fri, 19 Feb 2016 07:01:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWjkA-0003rG-T8 for qemu-devel@nongnu.org; Fri, 19 Feb 2016 07:01:10 -0500 Received: from mail-io0-x236.google.com ([2607:f8b0:4001:c06::236]:35324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWjkA-0003r8-IZ for qemu-devel@nongnu.org; Fri, 19 Feb 2016 07:01:06 -0500 Received: by mail-io0-x236.google.com with SMTP id g203so106745426iof.2 for ; Fri, 19 Feb 2016 04:01:06 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <87twl4diwv.fsf@linaro.org> References: <1454059965-23402-1-git-send-email-a.rigo@virtualopensystems.com> <87twl4diwv.fsf@linaro.org> Date: Fri, 19 Feb 2016 13:01:05 +0100 Message-ID: From: alvise rigo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC v7 00/16] Slow-path for atomic instruction translation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QWxleCBCZW5uw6ll?= Cc: MTTCG Devel , Claudio Fontana , QEMU Developers , Paolo Bonzini , Jani Kokkonen , VirtualOpenSystems Technical Team , Richard Henderson On Fri, Feb 19, 2016 at 12:44 PM, Alex Benn=C3=A9e = wrote: > > Alvise Rigo writes: > >> This is the seventh iteration of the patch series which applies to the >> upstream branch of QEMU (v2.5.0-rc4). >> >> Changes versus previous versions are at the bottom of this cover letter. >> >> The code is also available at following repository: >> https://git.virtualopensystems.com/dev/qemu-mt.git >> branch: >> slowpath-for-atomic-v7-no-mttcg > > OK I'm done on this review pass. I think generally we are in pretty good > shape although I await to see what extra needs to be done for the MTTCG > case. Hi Alex, Thank you for this review. Regarding the extra needs and integration with the MTTCG code, I've made available at this address [1] a working branch with the two patch series merged together. The branch boots fine Linux on both aarch64 and arm architectures. There is still that known issue with virtio, that Fred should fix soon. Let me know your first impressions. [1] https://git.virtualopensystems.com/dev/qemu-mt.git (branch "merging-slowpath-v7-mttcg-v8-wip") Thank you, alvise > > We are coming up to soft-freeze on 1/3/16 and it would be nice to get > this merged by then. As it is a fairly major chunk of work it would need > to get the initial commit by that date. > > However before we can get to that stage we need some review from the > maintainers. For your next version can you please: > > - Drop the RFC tag, I think we have had enough comment ;-) > - Make sure you CC the TCG maintainers (Paolo, Peter C and Richard Hend= erson) > - Also CC the ARM maintainers (Peter M) > - Be ready for a fast turnaround > > Paolo/Richard, > > Do you have any comments on this iteration? > > -- > Alex Benn=C3=A9e