From: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
To: Ahmed Karaman <ahmedkhaledkaraman@gmail.com>
Cc: "Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Richard Henderson" <richard.henderson@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Laurent Vivier" <laurent@vivier.eu>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH 0/2] Update use_goto_tb() in hppa and rx targets
Date: Tue, 26 May 2020 19:38:47 +0200 [thread overview]
Message-ID: <CAHiYmc70D2xo4m9zx16EbVH+om+04cqJz3O+Wa9pq7S=6LF-3A@mail.gmail.com> (raw)
In-Reply-To: <CAHiYmc7r0GBLytokN=cyonrQAC6S8J=SpPf9KroPgG+ACJPV5Q@mail.gmail.com>
> >
> > I think your last sentence in the bug report is not entirely correct.
> > It is not known what would be performance results in case of
> > correcting mmap.c. So, if possible, and unless Richard or someone else
> > disagrees, please change that last sentence to: "By doing so, a better
> > performance results could be achieved, compared to the case of the
> > workaround described above."
> >
> > Also, please add the tag "linux-user".
> >
Ahmed, since rx target supports system only mode at the moment, they
must include page crossing check in use_goto_tb(), which is missing
right now. So, since the rx bug is of a little bit of different
nature, please file another bug for rx target only - they have the bug
in system mode too, as opposed to other targets. Their fix should and
could be applied independently on any user-mode modifications for any
other target.
Sincerely,
Aleksandar
prev parent reply other threads:[~2020-05-26 17:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 16:21 [PATCH 0/2] Update use_goto_tb() in hppa and rx targets Ahmed Karaman
2020-05-19 16:21 ` [PATCH 1/2] target/hppa: Check page crossings in use_goto_tb() only in system mode Ahmed Karaman
2020-05-19 16:21 ` [PATCH 2/2] target/rx: Check for page crossings in use_goto_tb() Ahmed Karaman
2020-05-19 18:01 ` [PATCH 0/2] Update use_goto_tb() in hppa and rx targets Richard Henderson
2020-05-19 18:38 ` Alex Bennée
2020-05-19 18:51 ` Richard Henderson
2020-05-21 11:32 ` Ahmed Karaman
2020-05-22 3:12 ` Richard Henderson
2020-05-25 18:39 ` Aleksandar Markovic
2020-05-26 14:14 ` Aleksandar Markovic
2020-05-26 16:08 ` Ahmed Karaman
2020-05-26 16:29 ` Aleksandar Markovic
2020-05-26 16:45 ` Aleksandar Markovic
2020-05-26 17:38 ` Aleksandar Markovic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHiYmc70D2xo4m9zx16EbVH+om+04cqJz3O+Wa9pq7S=6LF-3A@mail.gmail.com' \
--to=aleksandar.qemu.devel@gmail.com \
--cc=ahmedkhaledkaraman@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).