From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38D78C6FA82 for ; Mon, 26 Sep 2022 21:49:02 +0000 (UTC) Received: from localhost ([::1]:38848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocvyH-0001zr-3h for qemu-devel@archiver.kernel.org; Mon, 26 Sep 2022 17:49:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocvqD-0001bp-2K for qemu-devel@nongnu.org; Mon, 26 Sep 2022 17:40:42 -0400 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]:53194) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocvqA-00060s-11 for qemu-devel@nongnu.org; Mon, 26 Sep 2022 17:40:40 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B2198B811ED for ; Mon, 26 Sep 2022 21:40:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 508F3C43140 for ; Mon, 26 Sep 2022 21:40:34 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="OdKntwZJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1664228431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f5aU5u3Myy655MFFq3viGw7i4p24peoKpxpAuPXCo2c=; b=OdKntwZJmsNpujdWawrgQTPKXcund/LA6Lff5oGkKwxr1K5/6fLPuy/K09OIsxFagdkjb/ UeGzzlc/ZugvSf7Ym3CT0BlYvcJWTockcvTa2JTVik9F4qxXSg7Ac4STRSox4a4Nr+WhkO kQ/5NnAfLNzCl1+9RbIodg6ZKVtU1qQ= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id edf5df97 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Mon, 26 Sep 2022 21:40:31 +0000 (UTC) Received: by mail-vs1-f43.google.com with SMTP id k2so7903548vsk.8 for ; Mon, 26 Sep 2022 14:40:30 -0700 (PDT) X-Gm-Message-State: ACrzQf3Vb47xrL3tCKQJ/72y8Z/BP9qBkzH1KSMxFINFk9bm5QEcFbll s6XfF7X1CfsSKz1Mm7jZ7IaKPPJ2DwfP+JIg0L4= X-Google-Smtp-Source: AMsMyM5DjiirOf7vDVF9J2wyRWm1Moy+VLllZ768pmWdZV809C59bQiuh9YBKXZQHA2qRxlMc0FRWUmTHPrdQtgGPGw= X-Received: by 2002:a67:d81e:0:b0:398:2c98:229b with SMTP id e30-20020a67d81e000000b003982c98229bmr9502201vsj.73.1664228430344; Mon, 26 Sep 2022 14:40:30 -0700 (PDT) MIME-Version: 1.0 References: <20220926113900.1256630-1-Jason@zx2c4.com> <20220926113900.1256630-2-Jason@zx2c4.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Mon, 26 Sep 2022 23:40:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH qemu v2 2/2] m68k: align bootinfo strings and data to 4 bytes To: Laurent Vivier Cc: linux-m68k@lists.linux-m68k.org, qemu-devel@nongnu.org, Geert Uytterhoeven Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2604:1380:4601:e00::1; envelope-from=SRS0=WzR3=Z5=zx2c4.com=Jason@kernel.org; helo=ams.source.kernel.org X-Spam_score_int: -67 X-Spam_score: -6.8 X-Spam_bar: ------ X-Spam_report: (-6.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Sep 26, 2022 at 11:37 PM Laurent Vivier wrote: > > Le 26/09/2022 =C3=A0 13:39, Jason A. Donenfeld a =C3=A9crit : > > Various tools, such as kexec-tools and m68k-bootinfo, expect each > > bootinfo entry to be aligned to 4 bytes, not 2 bytes. So adjust the > > padding to fill this out as such. > > > > Also, break apart the padding additions from the other field length > > additions, so that it's more clear why these magic numbers are being > > added, and comment them too. > > > > Reported-by: Geert Uytterhoeven > > Cc: Laurent Vivier > > Signed-off-by: Jason A. Donenfeld > > --- > > hw/m68k/bootinfo.h | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > Applied to my m68k-for-7.2 branch What about 1/2? Jason