From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF21C47082 for ; Tue, 8 Jun 2021 20:36:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B701A61208 for ; Tue, 8 Jun 2021 20:36:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B701A61208 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqiSu-00056L-T7 for qemu-devel@archiver.kernel.org; Tue, 08 Jun 2021 16:36:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqiSI-0004MV-Ia for qemu-devel@nongnu.org; Tue, 08 Jun 2021 16:36:10 -0400 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:44016) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqiSG-0006oP-IS for qemu-devel@nongnu.org; Tue, 08 Jun 2021 16:36:10 -0400 Received: by mail-ed1-x534.google.com with SMTP id s6so26042223edu.10 for ; Tue, 08 Jun 2021 13:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mRMbcgEkrVlWgn/EHSYgKjxSkDzL+RBD82gZD8gP/+I=; b=u1L4qB2RHMKYCwngiT8DCc/VwEqjgqBRwbrVcrZiE7rt/QDDNAFiuYPCx0ae5lnOgh iJifLtBqUoiNB/nr1DjP7A1K9Lsgbc8au5alPONjKQvO4IpYtB6rS4/PpyAoWLMSbBhH vpdSN0Cq4LmDGoWGj4PGNsjj6a3ayi0Fcn3CqT8vJJTapOL4eyb1uy1wyBMWycgmk9wQ w4Mpsdwdgk5Wrt6VOylgn9A2KSzPQxPD8SS1DwELMqdbdgVPXJWOL/rRDsQYZPyYzqLw ydxRBwysy45O436CSuXMVpdjzRJbHYBl1+Gd/JYAz3wDn8bKuuwF2m7L3IjDHpjFfrsI 54UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mRMbcgEkrVlWgn/EHSYgKjxSkDzL+RBD82gZD8gP/+I=; b=gwjCG69mG9+OdQmi55Yzv2w5UxwPqwLbKGyaT66r1MGiNnPSx4BR+H0EFCGcGjvEf7 fghakFc95Dw7R7jdX1zoa0o2At8MOan5Bh6UQ7bTPLohurQaoyuppPyMWE1h44Pkat9P wpU1cDX/mNpWUDCdJCC7MNh7ip5zD11F3rP1h/x2gnTWHMTcEbxFFCHPH6fboaTtIy9D 8Fy3CUSsLKH2zvlFUMg9nO+RWI+CvYPceXJIsRHqRGy5NCSaJHcKv/L0LSNaMjrcgzJY CGgz+2m40Jsz29wgUNvhxDG8G6VTHelqfuypNkP/mZzq77E3r6Uk2AEesNZpazEWgG8x iWNA== X-Gm-Message-State: AOAM533Q/FFZzV+vCFjWdN4NxifIjrUD6F30GKHztYLra01pZxqkfLx4 4saTYXhhY/OR4tfdf1nB96F3ryoG4AGLFW6zkZg= X-Google-Smtp-Source: ABdhPJxcG04UVpx70qE4GhkRrncWF/4hlfK5DpyuI36h1iFWx191Sx8cjDtcseRceYcIBIOP+Rq2MgYMxzmVwrGJkUo= X-Received: by 2002:aa7:ca1a:: with SMTP id y26mr27162807eds.314.1623184565723; Tue, 08 Jun 2021 13:36:05 -0700 (PDT) MIME-Version: 1.0 References: <20210529185522.78816-1-marcandre.lureau@redhat.com> In-Reply-To: From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Wed, 9 Jun 2021 00:35:53 +0400 Message-ID: Subject: Re: [PULL 0/2] Libslirp patches To: Peter Maydell Content-Type: multipart/alternative; boundary="00000000000071e75e05c4471bd1" Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=marcandre.lureau@gmail.com; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , QEMU Developers , Samuel Thibault Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000071e75e05c4471bd1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Tue, Jun 8, 2021 at 8:55 PM Peter Maydell wrote: > On Tue, 8 Jun 2021 at 16:55, Marc-Andr=C3=A9 Lureau > wrote: > > > > Hi > > > > On Mon, Jun 7, 2021 at 4:17 PM Peter Maydell > wrote: > > >> >> clang sanitizer build: link failure: > >> >> subprojects/libslirp/libslirp.so.0.3.0.p/src_arp_table.c.o: In > >> >> function `arp_table_add': > >> >> > /home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libsl= irp/src/arp_table.c:51: > >> >> undefined reference to `__ubsan_handle_type_mismatch_v1' > >> >> > /home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libsl= irp/src/arp_table.c:51: > >> >> undefined reference to `__ubsan_handle_type_mismatch_v1' > >> >> > /home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libsl= irp/src/arp_table.c:51: > >> >> undefined reference to `__ubsan_handle_type_mismatch_v1' > >> >> > /home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libsl= irp/src/arp_table.c:34: > >> >> undefined reference to `__ubsan_handle_type_mismatch_v1' > >> >> > /home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libsl= irp/src/arp_table.c:34: > >> >> undefined reference to `__ubsan_handle_type_mismatch_v1' > >> >> (and lots more similar) > >> > >> > I don't get this when running make vm-build-netbsd. What else am I > missing? > >> > >> > >> This isn't NetBSD related, it's just a clang sanitizer build on Linux. > > > > > > > > I am running configure with '--enable-sanitizers' --cc=3Dclang > --cxx=3Dclang++ --host-cc=3Dclang, I can't reproduce. > > > > What's your distro? (or meson + clang versions) > > Ubuntu 18.04.5 LTS (bionic); configure arguments > '--cc=3Dclang' '--cxx=3Dclang++' '--enable-gtk' > '--extra-cflags=3D-fsanitize=3Dundefined -fno-sanitize=3Dshift-base > -Werror' > clang version 6.0.0-1ubuntu2 Per subproject `default_library` was added in 0.54, and we require 0.55.3. Why is it trying to build libslirp.so? I tried to make vm-build-ubuntu.i386 with the following changes: diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386 index 47681b6f87..21d0b64eb1 100755 --- a/tests/vm/ubuntu.i386 +++ b/tests/vm/ubuntu.i386 @@ -18,7 +18,7 @@ import ubuntuvm DEFAULT_CONFIG =3D { 'install_cmds' : "apt-get update,"\ "apt-get build-dep -y qemu,"\ - "apt-get install -y libfdt-dev language-pack-en ninja-build", + "apt-get install -y libfdt-dev language-pack-en ninja-build clang", } class UbuntuX86VM(ubuntuvm.UbuntuVM): @@ -32,7 +32,7 @@ class UbuntuX86VM(ubuntuvm.UbuntuVM): cd $(mktemp -d); sudo chmod a+r /dev/vdb; tar -xf /dev/vdb; - ./configure {configure_opts}; + ./configure {configure_opts} --cc=3Dclang --cxx=3Dclang++ --host-cc=3Dclang --extra-cflags=3D'-fsanitize=3Dundefined -fno-sanitize=3Dshift-base -Werror'; make --output-sync {target} -j{jobs} {verbose}; """ (or with EXTRA_CONFIGURE_OPTS) And it failed with: [2363/9207] Linking target qemu-system-aarch64 FAILED: qemu-system-aarch64 clang++ @qemu-system-aarch64.rsp libqemu-aarch64-softmmu.fa.p/accel_tcg_cputlb.c.o: In function `helper_atomic_cmpxchgq_le_mmu': /tmp/tmp.VkWONZ62bA/build/../accel/tcg/atomic_template.h:86: undefined reference to `__atomic_compare_exchange_8' libqemu-aarch64-softmmu.fa.p/accel_tcg_cputlb.c.o: In function `helper_atomic_xchgq_le_mmu': /tmp/tmp.VkWONZ62bA/build/../accel/tcg/atomic_template.h:134: undefined reference to `__atomic_exchange_8' libqemu-aarch64-softmmu.fa.p/accel_tcg_cputlb.c.o: In function `helper_atomic_fetch_addq_le_mmu': Any idea what I am missing? thanks --=20 Marc-Andr=C3=A9 Lureau --00000000000071e75e05c4471bd1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Tue, Jun 8, 2021 at 8:55 PM Pete= r Maydell <peter.maydell@linaro.org> wrote:
On Tue, 8 Jun 2021 at 16:55, Marc-Andr=C3=A9 Lurea= u
<marcand= re.lureau@gmail.com> wrote:
>
> Hi
>
> On Mon, Jun 7, 2021 at 4:17 PM Peter Maydell <peter.maydell@linaro.org> w= rote:

>> >> clang sanitizer build: link failure:
>> >> subprojects/libslirp/libslirp.so.0.3.0.p/src_arp_table.c.= o: In
>> >> function `arp_table_add':
>> >> /home/petmay01/linaro/qemu-for-merges/build/clang/../../s= ubprojects/libslirp/src/arp_table.c:51:
>> >> undefined reference to `__ubsan_handle_type_mismatch_v1&#= 39;
>> >> /home/petmay01/linaro/qemu-for-merges/build/clang/../../s= ubprojects/libslirp/src/arp_table.c:51:
>> >> undefined reference to `__ubsan_handle_type_mismatch_v1&#= 39;
>> >> /home/petmay01/linaro/qemu-for-merges/build/clang/../../s= ubprojects/libslirp/src/arp_table.c:51:
>> >> undefined reference to `__ubsan_handle_type_mismatch_v1&#= 39;
>> >> /home/petmay01/linaro/qemu-for-merges/build/clang/../../s= ubprojects/libslirp/src/arp_table.c:34:
>> >> undefined reference to `__ubsan_handle_type_mismatch_v1&#= 39;
>> >> /home/petmay01/linaro/qemu-for-merges/build/clang/../../s= ubprojects/libslirp/src/arp_table.c:34:
>> >> undefined reference to `__ubsan_handle_type_mismatch_v1&#= 39;
>> >> (and lots more similar)
>>
>> > I don't get this=C2=A0 when running make vm-build-netbsd.= What else am I missing?
>>
>>
>> This isn't NetBSD related, it's just a clang sanitizer bui= ld on Linux.
>
>
>
> I am running configure with '--enable-sanitizers' --cc=3Dclang= --cxx=3Dclang++ --host-cc=3Dclang, I can't reproduce.
>
> What's your distro? (or meson + clang versions)

Ubuntu 18.04.5 LTS (bionic); configure arguments
'--cc=3Dclang' '--cxx=3Dclang++' '--enable-gtk'
'--extra-cflags=3D-fsanitize=3Dundefined=C2=A0 -fno-sanitize=3Dshift-ba= se
-Werror'
clang version 6.0.0-1ubuntu2

Per subproject= `default_library` was added in 0.54, and we require 0.55.3. Why is it tryi= ng to build libslirp.so?

I tried to make vm-build-= ubuntu.i386 with the following changes:

=C2=A0diff= --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386
index 47681b6f87..2= 1d0b64eb1 100755
--- a/tests/vm/ubuntu.i386
+++ b/tests/vm/ubuntu.i38= 6
@@ -18,7 +18,7 @@ import ubuntuvm
=C2=A0DEFAULT_CONFIG =3D {
=C2= =A0 =C2=A0 =C2=A0'install_cmds' : "apt-get update,"\
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 "apt-get build-dep -y qemu,"\
- =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "apt-get install -y libf= dt-dev language-pack-en ninja-build",
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "apt-get install -y libfdt-= dev language-pack-en ninja-build clang",
=C2=A0}
=C2=A0
=C2= =A0class UbuntuX86VM(ubuntuvm.UbuntuVM):
@@ -32,7 +32,7 @@ class UbuntuX= 86VM(ubuntuvm.UbuntuVM):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0cd $(mktemp -= d);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0sudo chmod a+r /dev/vdb;
=C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0tar -xf /dev/vdb;
- =C2=A0 =C2=A0 =C2=A0 =C2= =A0./configure {configure_opts};
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0./configur= e {configure_opts} --cc=3Dclang --cxx=3Dclang++ --host-cc=3Dclang --extra-c= flags=3D'-fsanitize=3Dundefined =C2=A0-fno-sanitize=3Dshift-base -Werro= r';
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0make --output-sync {target} -j= {jobs} {verbose};
=C2=A0 =C2=A0 =C2=A0"""

<= /div>
(or with EXTRA_CONFIGURE_OPTS)

And it fa= iled with:

[2363/9207] Linking target qemu-system-= aarch64
FAILED: qemu-system-aarch64
clang++ @qemu-system-aarch64.rsp=
libqemu-aarch64-softmmu.fa.p/accel_tcg_cputlb.c.o: In function `helper_= atomic_cmpxchgq_le_mmu':
/tmp/tmp.VkWONZ62bA/build/../accel/tcg/atom= ic_template.h:86: undefined reference to `__atomic_compare_exchange_8'<= br>libqemu-aarch64-softmmu.fa.p/accel_tcg_cputlb.c.o: In function `helper_a= tomic_xchgq_le_mmu':
/tmp/tmp.VkWONZ62bA/build/../accel/tcg/atomic_t= emplate.h:134: undefined reference to `__atomic_exchange_8'
libqemu-= aarch64-softmmu.fa.p/accel_tcg_cputlb.c.o: In function `helper_atomic_fetch= _addq_le_mmu':

Any idea what I am mi= ssing?

thanks

--
Marc-Andr=C3=A9 Lureau
--00000000000071e75e05c4471bd1--