From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: Re: [PATCH 2/4] configure: remove variable bogus_os
Date: Thu, 17 Dec 2020 14:21:46 +0400 [thread overview]
Message-ID: <CAJ+F1C+KOz1GHuwE=gk4ijr=MZ7OvHCgHmwABcyNDOLo4iKxtA@mail.gmail.com> (raw)
In-Reply-To: <20201217085005.10644-3-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]
On Thu, Dec 17, 2020 at 12:50 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> The condition can be tested also from $targetos, clean up.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
> configure | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index 085a5ad7ff..18af8207d9 100755
> --- a/configure
> +++ b/configure
> @@ -467,7 +467,6 @@ gettext="auto"
> fuse="auto"
> fuse_lseek="auto"
>
> -bogus_os="no"
> malloc_trim="auto"
>
> # parse CC options second
> @@ -620,7 +619,6 @@ else
> # might be going to just print the --help text, or it might
> # be the result of a missing compiler.
> targetos='bogus'
> - bogus_os='yes'
> fi
>
> # Some host OSes need non-standard checks for which CPU to use.
> @@ -2016,7 +2014,7 @@ if test -z "$werror" ; then
> fi
> fi
>
> -if test "$bogus_os" = "yes"; then
> +if test "$targetos" = "bogus"; then
> # Now that we know that we're not printing the help and that
> # the compiler works (so the results of the check_defines we used
> # to identify the OS are reliable), if we didn't recognize the
> --
> 2.29.2
>
>
>
>
--
Marc-André Lureau
[-- Attachment #2: Type: text/html, Size: 2205 bytes --]
next prev parent reply other threads:[~2020-12-17 10:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 8:50 [PATCH 0/4] First batch of configure cleanups Paolo Bonzini
2020-12-17 8:50 ` [PATCH 1/4] configure: remove useless code to check for Xen PCI passthrough Paolo Bonzini
2020-12-17 10:20 ` Marc-André Lureau
2020-12-17 8:50 ` [PATCH 2/4] configure: remove variable bogus_os Paolo Bonzini
2020-12-17 9:04 ` Thomas Huth
2020-12-17 10:21 ` Marc-André Lureau [this message]
2020-12-17 8:50 ` [PATCH 3/4] configure: accept --enable-slirp Paolo Bonzini
2020-12-17 9:06 ` Thomas Huth
2020-12-17 10:22 ` Marc-André Lureau
2020-12-17 8:50 ` [PATCH 4/4] configure: remove CONFIG_FILEVERSION and CONFIG_PRODUCTVERSION Paolo Bonzini
2020-12-17 10:30 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ+F1C+KOz1GHuwE=gk4ijr=MZ7OvHCgHmwABcyNDOLo4iKxtA@mail.gmail.com' \
--to=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).