Re: [PATCH 1/1] qga: Add "guest-get-memory-block-info" to blacklist

["Marc-André Lureau" <marcandre.lureau@gmail.com>]

On Thu, Oct 17, 2019 at 2:35 PM Basil Salman <basil@daynix.com> wrote:
>
> From: Basil Salman <bsalman@redhat.com>
>
> Memory block commands are only supported for linux with sysfs,
> "guest-get-memory-block-info" was not in blacklist for other
> cases.
>
> Reported on:
> https://bugzilla.redhat.com/show_bug.cgi?id=1751431
>
> Signed-off-by: Basil Salman <bsalman@redhat.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  qga/commands-posix.c | 3 ++-
>  qga/commands-win32.c | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index dfc05f5b8a..1c1a165dae 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -2730,7 +2730,8 @@ GList *ga_command_blacklist_init(GList *blacklist)
>              "guest-suspend-hybrid", "guest-network-get-interfaces",
>              "guest-get-vcpus", "guest-set-vcpus",
>              "guest-get-memory-blocks", "guest-set-memory-blocks",
> -            "guest-get-memory-block-size", NULL};
> +            "guest-get-memory-block-size", "guest-get-memory-block-info",
> +            NULL};
>          char **p = (char **)list;
>
>          while (*p) {
> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
> index 6b67f16faf..1c9ec9c094 100644
> --- a/qga/commands-win32.c
> +++ b/qga/commands-win32.c
> @@ -1894,7 +1894,7 @@ GList *ga_command_blacklist_init(GList *blacklist)
>          "guest-suspend-hybrid",
>          "guest-set-vcpus",
>          "guest-get-memory-blocks", "guest-set-memory-blocks",
> -        "guest-get-memory-block-size",
> +        "guest-get-memory-block-size", "guest-get-memory-block-info",
>          NULL};
>      char **p = (char **)list_unsupported;
>
> --
> 2.17.2
>
>


-- 
Marc-André Lureau