From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A003C433ED for ; Fri, 21 May 2021 10:52:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3C79613BF for ; Fri, 21 May 2021 10:52:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3C79613BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lk2lC-00057t-UB for qemu-devel@archiver.kernel.org; Fri, 21 May 2021 06:52:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lk2jl-0003bQ-Qp for qemu-devel@nongnu.org; Fri, 21 May 2021 06:50:37 -0400 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:44706) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lk2jj-0001WK-Ul for qemu-devel@nongnu.org; Fri, 21 May 2021 06:50:37 -0400 Received: by mail-ed1-x52c.google.com with SMTP id t15so22828564edr.11 for ; Fri, 21 May 2021 03:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jUKVAlON+TRyg78D+J4utTSwXrgEEE3UtS5N6OuFq7w=; b=qFdfkS14f73M+usjgi2UknfNzda8zRN2CSeIf8YsREvNaaKQiJWzuopO4bnNKw2iUA +jn6HV/K9YLGa151H8TfIOEk02HDGJBXHcnwMIJKtv9XZW9cBjpaP0wELI3G8LRcnm/w ur5qCA94ft/nBMxbIEoNOQBEomhBQG76Xi0YwO4XYMUiTYFN5qQhtjv/M6YHJzB8/uhp YaEneelHaTTbod5hcEFs3e0+zf0kx46OXydpE7PuVdr3Yoi+2P1FjqUTxQpHF2OyGG4b DbPGNgWDscULIwsAvIKrjli9LpHrS2y3OUlj+ouv131RK7aF+/pWUnhomQ5ji6Mr3ysf bUNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jUKVAlON+TRyg78D+J4utTSwXrgEEE3UtS5N6OuFq7w=; b=HL3NVr0Ll0dhHnZJw17zDtQ13dVP34dJF4OUhYCh3IBDJrYluWteRMSKTFOOB77/HR nud3r53nwhWvusJHVYWez0j5eXWkNxWhfPam6kbR3O/oyJzE2ZeQN+SlZMuyRK5Ooj1V rWfi0wRIC1Ee5bGV+zRpKcP97CnWmyeV9gUUy9/jwnmoRa4JCMQDiaU0+J/qk8ddiAKM mjHHaQTQA9Lw09zGGjlvP8U47x/AD/vN/xx+AU3UeWQZgsb5dynLOTVFsEeiIb1XdmzJ CE2ltoYH4FZ+QLL7lIewnSUkXQ+dK2S6iIZtWVuiUSOxoxIxaqOkOj+swxFFi9LHALue UZEA== X-Gm-Message-State: AOAM531YFVkpplW0aAzwW+qNfsLZ/kroO/OMZb1P+JBEsoB0WAMGH6vm TZNjsI34sjXBET1Btqxi/QdPygRxAGUmb2E9oNE= X-Google-Smtp-Source: ABdhPJzMIScj6o+te9oqnApnWb0e4XvkuQ+Lq5bWJKAac4Thl1srJFlUHQnEU8V57qGGOZW23xbRn9WSvlGhrjkH7/I= X-Received: by 2002:a05:6402:1d2c:: with SMTP id dh12mr7127041edb.237.1621594233743; Fri, 21 May 2021 03:50:33 -0700 (PDT) MIME-Version: 1.0 References: <20210510132051.2208563-1-kraxel@redhat.com> <20210510132051.2208563-13-kraxel@redhat.com> In-Reply-To: From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Fri, 21 May 2021 14:50:22 +0400 Message-ID: Subject: Re: [PULL 12/25] virtio-gpu: move virgl realize + properties To: =?UTF-8?B?TWljaGFsIFByw612b3puw61r?= Content-Type: multipart/alternative; boundary="00000000000045ac0205c2d4d4cf" Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=marcandre.lureau@gmail.com; helo=mail-ed1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , "Michael S. Tsirkin" , Gerd Hoffmann , QEMU Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000045ac0205c2d4d4cf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Fri, May 21, 2021 at 1:34 PM Michal Pr=C3=ADvozn=C3=ADk wrote: > On 5/10/21 3:20 PM, Gerd Hoffmann wrote: > > Move device init (realize) and properties. > > > > Drop the virgl property, the virtio-gpu-gl-device has virgl enabled no > > matter what. Just use virtio-gpu-device instead if you don't want > > enable virgl and opengl. This simplifies the logic and reduces the tes= t > > matrix. > > > > Signed-off-by: Gerd Hoffmann > > Message-id: 20210430113547.1816178-1-kraxel@redhat.com > > Message-Id: <20210430113547.1816178-4-kraxel@redhat.com> > > --- > > include/hw/virtio/virtio-gpu.h | 1 + > > hw/display/virtio-gpu-gl.c | 33 +++++++++++++++++++++++++++++++++ > > hw/display/virtio-gpu.c | 23 +---------------------- > > 3 files changed, 35 insertions(+), 22 deletions(-) > > > > > @@ -1251,12 +1236,6 @@ static Property virtio_gpu_properties[] =3D { > > VIRTIO_GPU_BASE_PROPERTIES(VirtIOGPU, parent_obj.conf), > > DEFINE_PROP_SIZE("max_hostmem", VirtIOGPU, conf_max_hostmem, > > 256 * MiB), > > -#ifdef CONFIG_VIRGL > > - DEFINE_PROP_BIT("virgl", VirtIOGPU, parent_obj.conf.flags, > > - VIRTIO_GPU_FLAG_VIRGL_ENABLED, true), > > - DEFINE_PROP_BIT("stats", VirtIOGPU, parent_obj.conf.flags, > > - VIRTIO_GPU_FLAG_STATS_ENABLED, false), > > -#endif > > DEFINE_PROP_END_OF_LIST(), > > }; > > > > > > Sorry for catching this a bit late, but libvirt is looking for "virgl" > property when guest XML has 3D acceleration enabled: > >