From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Cleber Rosa <crosa@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
QEMU <qemu-devel@nongnu.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Auger Eric" <eric.auger@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Willian Rampazzo" <wrampazz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH 5/6] tests/acceptance/virtio-gpu.py: use virtio-vga-gl
Date: Tue, 20 Jul 2021 13:36:01 +0400 [thread overview]
Message-ID: <CAJ+F1C+sMruEZe-3eWYz68s6gQ-n-sxAj7=QJvySFp=uLq7yeQ@mail.gmail.com> (raw)
In-Reply-To: <20210714174051.28164-6-crosa@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1524 bytes --]
On Wed, Jul 14, 2021 at 9:47 PM Cleber Rosa <crosa@redhat.com> wrote:
> Since 49afbca3b, the use of an optional virgl renderer is not
> available anymore, and since b36eb8860f, the way to choose a GL based
> rendered is to use the "virtio-vga-gl" device.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
> tests/acceptance/virtio-gpu.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/acceptance/virtio-gpu.py
> b/tests/acceptance/virtio-gpu.py
> index fbde278705..0f84affe82 100644
> --- a/tests/acceptance/virtio-gpu.py
> +++ b/tests/acceptance/virtio-gpu.py
> @@ -56,7 +56,7 @@ def wait_for_console_pattern(self, success_message,
> vm=None):
>
> def test_virtio_vga_virgl(self):
> """
> - :avocado: tags=device:virtio-vga
> + :avocado: tags=device:virtio-vga-gl
> """
> # FIXME: should check presence of virtio, virgl etc
> self.require_accelerator('kvm')
> @@ -67,7 +67,7 @@ def test_virtio_vga_virgl(self):
> self.vm.set_console()
> self.vm.add_args("-m", "2G")
> self.vm.add_args("-machine", "pc,accel=kvm")
> - self.vm.add_args("-device", "virtio-vga,virgl=on")
> + self.vm.add_args("-device", "virtio-vga-gl")
> self.vm.add_args("-display", "egl-headless")
> self.vm.add_args(
> "-kernel",
> --
> 2.31.1
>
>
>
--
Marc-André Lureau
[-- Attachment #2: Type: text/html, Size: 2474 bytes --]
next prev parent reply other threads:[~2021-07-20 9:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 17:40 [PATCH for 6.1 0/6] virtio-gpu acceptance test: use current device name Cleber Rosa
2021-07-14 17:40 ` [PATCH 1/6] tests/acceptance/virtio-gpu.py: use require_accelerator() Cleber Rosa
2021-07-14 21:51 ` Willian Rampazzo
2021-07-14 17:40 ` [PATCH 2/6] tests/acceptance/virtio-gpu.py: combine x86_64 arch tags Cleber Rosa
2021-07-14 21:52 ` Willian Rampazzo
2021-07-14 17:40 ` [PATCH 3/6] tests/acceptance/virtio-gpu.py: combine CPU tags Cleber Rosa
2021-07-14 21:53 ` Willian Rampazzo
2021-07-14 17:40 ` [PATCH 4/6] tests/acceptance/virtio-gpu.py: combine kernel command line Cleber Rosa
2021-07-14 21:54 ` Willian Rampazzo
2021-07-14 17:40 ` [PATCH 5/6] tests/acceptance/virtio-gpu.py: use virtio-vga-gl Cleber Rosa
2021-07-14 21:55 ` Willian Rampazzo
2021-07-20 9:36 ` Marc-André Lureau [this message]
2021-07-21 12:14 ` Gerd Hoffmann
2021-07-14 17:40 ` [PATCH 6/6] tests/acceptance/virtio-gpu.py: provide kernel and initrd hashes Cleber Rosa
2021-07-14 21:56 ` Willian Rampazzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ+F1C+sMruEZe-3eWYz68s6gQ-n-sxAj7=QJvySFp=uLq7yeQ@mail.gmail.com' \
--to=marcandre.lureau@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=eric.auger@redhat.com \
--cc=kraxel@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).