From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B19DEC433E7 for ; Tue, 20 Oct 2020 10:01:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C620D22242 for ; Tue, 20 Oct 2020 10:01:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fLjiKN1A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C620D22242 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUoRz-00061K-N7 for qemu-devel@archiver.kernel.org; Tue, 20 Oct 2020 06:01:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUoQV-0005VN-S3 for qemu-devel@nongnu.org; Tue, 20 Oct 2020 05:59:31 -0400 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:40635) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUoQT-00064X-TQ for qemu-devel@nongnu.org; Tue, 20 Oct 2020 05:59:31 -0400 Received: by mail-lf1-x133.google.com with SMTP id a9so1362764lfc.7 for ; Tue, 20 Oct 2020 02:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3M99JTkIFEixHdxk6ZYa3yXOpidnjbVahkMrmshiRus=; b=fLjiKN1A6fQMZDaCMrvBj/qVf7vqaT9dFbbIQAVM8eIccoQphOtf3P9SwstAbXZjf2 PzN0c5+Bu2WBS7YZC//sLh2tJiv1si9aslTTx1xU5dQWk9W7r8Saij8KjdysqXb6xWAj w5IxOlomAe5iOGSa6qaIE4+yMR1z9ca2Irl+LGH4Ir9jLl1pt6TuohgbS/THW0egddiU fx6H0RgdIsjSFL+kehG7A09MHQehI0bet2eN06cgpLQ4m+U6CfXNpI5hsKwDjGvR0ZLr X6ca+Uh8bocOjMMGvjO2pTM+kERh6ZRizrZPeQ27vkP2jcKUO7vxynbKtKLP6b1J3yXH r8/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3M99JTkIFEixHdxk6ZYa3yXOpidnjbVahkMrmshiRus=; b=HxmUZa0TNvJjPygxL+9tNgdDtBi5NO682nGm40PKOqiZRu+84Q6SpJy7LTFo1W4mLQ 4AN7ZcfGHiLXtO9MYzFGykmrUPDuDqkmnADW5ZHKkh241LXY0gCPuZlWXlgfZntW/2DM hYSESQGy8SBlwc7mSaNRIHwBNoUsPRxJcEe53o2wi3x89OOHLcg4coR2Lo/Vrm62+ftc 7VdgcOeWbwXKaZinu+NwsVfAXxzBkxia0qxem8SuwIqIJ7F/3Z0//TSdJaSUPvoZa/QF ytzbitPFXCV4VZ5iqyMiCoU1FBgkSbb/PPDoikGK82RbSaOti07cDAKY2hbcceRTuDjA OqAA== X-Gm-Message-State: AOAM533a7YZFX6Xg/ic0kNMPaQgx1t2ClJQZ21k6sIUvdQ7TW4Dfqscj FBSNKfdGyS0fDR6CTUAjdDqUATyHsDvGlZo4ebU= X-Google-Smtp-Source: ABdhPJyHDb6L5lan7Lm+oHM2rOkfnwrtyMTUL0+AC655fgFZjX11C1ZL7c+mjjY/T3gIa2d5byoHZ05GsZ44lT6J0iE= X-Received: by 2002:a19:185:: with SMTP id 127mr717267lfb.356.1603187967613; Tue, 20 Oct 2020 02:59:27 -0700 (PDT) MIME-Version: 1.0 References: <20201019075224.14803-1-kraxel@redhat.com> In-Reply-To: <20201019075224.14803-1-kraxel@redhat.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Tue, 20 Oct 2020 13:59:15 +0400 Message-ID: Subject: Re: [PATCH 00/14] ui: build spice and opengl as module. To: Gerd Hoffmann Content-Type: multipart/alternative; boundary="000000000000515e4605b2174912" Received-SPF: pass client-ip=2a00:1450:4864:20::133; envelope-from=marcandre.lureau@gmail.com; helo=mail-lf1-x133.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , QEMU , "Dr. David Alan Gilbert" , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000515e4605b2174912 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Mon, Oct 19, 2020 at 12:06 PM Gerd Hoffmann wrote: > - Add QemuSpiceOps, reorganize spice stubs. > - Add support for module dependencies. > - Build spice-core modular, and make the existing spice > modules (audio, chardev, qxl) depend on spice-core. > - Build egl-headless display and opengl helpers modular > (pretty easy thanks to module dependencies). > > Gerd Hoffmann (14): > spice: add module helpers > spice: add QemuSpiceOps, move migrate_info > spice: move qemu_spice_init() to QemuSpiceOps. > spice: move display_init() to QemuSpiceOps. > spice: move add_interface() to QemuSpiceOps. > spice: move auth functions to QemuSpiceOps. > spice: move display_add_client() to QemuSpiceOps. > spice: wire up monitor in QemuSpiceOps. > spice: load module when enabled on the cmdline > modules: dependencies infrastructure > modules: add spice dependencies > spice: flip modules switch > opengl: build egl-headless display modular > opengl: build opengl helper code modular > Reviewed-by: Marc-Andr=C3=A9 Lureau thanks! > include/ui/qemu-spice-module.h | 44 ++++++++++++++++++ > include/ui/qemu-spice.h | 42 +---------------- > audio/spiceaudio.c | 4 +- > chardev/spice.c | 2 +- > monitor/misc.c | 2 +- > monitor/qmp-cmds.c | 6 +-- > softmmu/vl.c | 10 ++-- > ui/spice-core.c | 31 +++++++++---- > ui/spice-input.c | 6 +-- > ui/spice-module.c | 85 ++++++++++++++++++++++++++++++++++ > util/module.c | 44 ++++++++++++++++-- > ui/meson.build | 28 +++++++++-- > 12 files changed, 232 insertions(+), 72 deletions(-) > create mode 100644 include/ui/qemu-spice-module.h > create mode 100644 ui/spice-module.c > > -- > 2.27.0 > > > > --=20 Marc-Andr=C3=A9 Lureau --000000000000515e4605b2174912 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Mon, Oct 19, 2020 at 12:06 PM Ge= rd Hoffmann <kraxel@redhat.com&= gt; wrote:
- Add= QemuSpiceOps, reorganize spice stubs.
- Add support for module dependencies.
- Build spice-core modular, and make the existing spice
=C2=A0 modules (audio, chardev, qxl) depend on spice-core.
- Build egl-headless display and opengl helpers modular
=C2=A0 (pretty easy thanks to module dependencies).

Gerd Hoffmann (14):
=C2=A0 spice: add module helpers
=C2=A0 spice: add QemuSpiceOps, move migrate_info
=C2=A0 spice: move qemu_spice_init() to QemuSpiceOps.
=C2=A0 spice: move display_init() to QemuSpiceOps.
=C2=A0 spice: move add_interface() to QemuSpiceOps.
=C2=A0 spice: move auth functions to QemuSpiceOps.
=C2=A0 spice: move display_add_client() to QemuSpiceOps.
=C2=A0 spice: wire up monitor in QemuSpiceOps.
=C2=A0 spice: load module when enabled on the cmdline
=C2=A0 modules: dependencies infrastructure
=C2=A0 modules: add spice dependencies
=C2=A0 spice: flip modules switch
=C2=A0 opengl: build egl-headless display modular
=C2=A0 opengl: build opengl helper code modular

Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>

thanks!


=C2=A0include/ui/qemu-spice-module.h | 44 ++++++++++++++++++
=C2=A0include/ui/qemu-spice.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 | 42 +------------= ----
=C2=A0audio/spiceaudio.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|= =C2=A0 4 +-
=C2=A0chardev/spice.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 |=C2=A0 2 +-
=C2=A0monitor/misc.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0|=C2=A0 2 +-
=C2=A0monitor/qmp-cmds.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|= =C2=A0 6 +--
=C2=A0softmmu/vl.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0| 10 ++--
=C2=A0ui/spice-core.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 | 31 +++++++++----
=C2=A0ui/spice-input.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0|=C2=A0 6 +--
=C2=A0ui/spice-module.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 8= 5 ++++++++++++++++++++++++++++++++++
=C2=A0util/module.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 | 44 ++++++++++++++++--
=C2=A0ui/meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0| 28 +++++++++--
=C2=A012 files changed, 232 insertions(+), 72 deletions(-)
=C2=A0create mode 100644 include/ui/qemu-spice-module.h
=C2=A0create mode 100644 ui/spice-module.c

--
2.27.0





--
Marc-Andr=C3=A9 Lureau
--000000000000515e4605b2174912--