From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3D21C64E7A for ; Tue, 1 Dec 2020 06:40:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A86C520757 for ; Tue, 1 Dec 2020 06:40:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J/sY8Wz/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A86C520757 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjzL6-0006fw-3M for qemu-devel@archiver.kernel.org; Tue, 01 Dec 2020 01:40:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjzIp-0005l8-2L for qemu-devel@nongnu.org; Tue, 01 Dec 2020 01:38:19 -0500 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]:46756) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kjzIm-0005lh-QZ for qemu-devel@nongnu.org; Tue, 01 Dec 2020 01:38:18 -0500 Received: by mail-ed1-x544.google.com with SMTP id b2so1465736edy.13 for ; Mon, 30 Nov 2020 22:38:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IcaK1k9vWL279nO8ZCLXQ3aRQiZ4ZR/s4kb0Kv4+h5I=; b=J/sY8Wz/9+/fZogBHIhK+euZQANeyDS/c+4fNpXntL3exuNaE90rTVHxJ9Uc6TupDn 757R79R6O+VeClJR/4wE9ZXI/GDkjfjYq4uAzfDec070Qpx65ue5uNjNqKjsAZj+Zpc+ ri3BvX/vpaKwFzuu+UGp8RPhpnTHGVBEJirF6lBUOqr0U/PBvh75AEm6dEuGW9jqfIpo h0QphDMNrgaQgDyFGxc8Z7k4bVAbMIJg1+DtWjA77o2ZrYcQ3DdWHxPzB8Tu5diRTpiy rGnPLpVNTCib10pfnLZYtDGl6nZXxAAujhTtAmnc8EssF2/EmEkscvJiZ/xCpLKDnDtD kmww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IcaK1k9vWL279nO8ZCLXQ3aRQiZ4ZR/s4kb0Kv4+h5I=; b=VTxcjXEZaoHw1giO4CZIcIpY4GtGG3PeARSVzX5zI7ZUM8+FEUIzZOznU9Avt7kXzT OH7fbBhqC9mxyofPZfoWNylkVUs7I5RCxlQMiQnqliIwGjJbgBs/AWEJek30US4pscxo fzCmsPtAra8P3NU5Y8RPa+IhkQrZ+r/C8Pzlq8PKa4Ho7n7t3GcF07LAf5KyTSWtlNdx EwXz+HaSubrrcH6iODDgM/oeJnOJ+7v92QK3Z9B7YjXzWAtSWiDJuFsAYTJMtPxQ+BV/ Uz88xEzKzxPYxpGDOk/HhNsbavzTLz+KfZlFmryaiJsPIC4BIJTIWGfW7fK5zlfYOBgE V8iA== X-Gm-Message-State: AOAM531cRt9qHbptH/ISaMQMe+aiPO/w2fuHXsXlwEy7KRld/3oJs6hw LUG5CKMEmchryvh0by+gRSKhhq642TZO2iyv/1s= X-Google-Smtp-Source: ABdhPJxxn8hyF1aR3IRK3/nppLzVGhFBgJGu8m+QvFFg5kI+YtKbSIis4FX/oJG91M1eYs5vb6pq2Bim9wUW2fBZOE4= X-Received: by 2002:a50:a6dd:: with SMTP id f29mr1504895edc.257.1606804694882; Mon, 30 Nov 2020 22:38:14 -0800 (PST) MIME-Version: 1.0 References: <20201201061356.18438-1-lma@suse.com> In-Reply-To: <20201201061356.18438-1-lma@suse.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Tue, 1 Dec 2020 10:38:02 +0400 Message-ID: Subject: Re: [PATCH v4] qga: Correct loop count in qmp_guest_get_vcpus() To: Lin Ma Content-Type: multipart/alternative; boundary="0000000000000fdf8f05b5615fda" Received-SPF: pass client-ip=2a00:1450:4864:20::544; envelope-from=marcandre.lureau@gmail.com; helo=mail-ed1-x544.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU , Michael Roth Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000000fdf8f05b5615fda Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Tue, Dec 1, 2020 at 10:14 AM Lin Ma wrote: > The guest-get-vcpus returns incorrect vcpu info in case we hotunplug > vcpus(not > the last one). > e.g.: > A VM has 4 VCPUs: cpu0 + 3 hotunpluggable online vcpus(cpu1, cpu2 and > cpu3). > Hotunplug cpu2, Now only cpu0, cpu1 and cpu3 are present & online. > > ./qmp-shell /tmp/qmp-monitor.sock > (QEMU) query-hotpluggable-cpus > {"return": [ > {"props": {"core-id": 0, "thread-id": 0, "socket-id": 3}, "vcpus-count": = 1, > "qom-path": "/machine/peripheral/cpu3", "type": "host-x86_64-cpu"}, > {"props": {"core-id": 0, "thread-id": 0, "socket-id": 2}, "vcpus-count": = 1, > "qom-path": "/machine/peripheral/cpu2", "type": "host-x86_64-cpu"}, > {"props": {"core-id": 0, "thread-id": 0, "socket-id": 1}, "vcpus-count": = 1, > "qom-path": "/machine/peripheral/cpu1", "type": "host-x86_64-cpu"}, > {"props": {"core-id": 0, "thread-id": 0, "socket-id": 0}, "vcpus-count": = 1, > "qom-path": "/machine/unattached/device[0]", "type": "host-x86_64-cpu"} > ]} > > (QEMU) device_del id=3Dcpu2 > {"return": {}} > > (QEMU) query-hotpluggable-cpus > {"return": [ > {"props": {"core-id": 0, "thread-id": 0, "socket-id": 3}, "vcpus-count": = 1, > "qom-path": "/machine/peripheral/cpu3", "type": "host-x86_64-cpu"}, > {"props": {"core-id": 0, "thread-id": 0, "socket-id": 2}, "vcpus-count": = 1, > "type": "host-x86_64-cpu"}, > {"props": {"core-id": 0, "thread-id": 0, "socket-id": 1}, "vcpus-count": = 1, > "qom-path": "/machine/peripheral/cpu1", "type": "host-x86_64-cpu"}, > {"props": {"core-id": 0, "thread-id": 0, "socket-id": 0}, "vcpus-count": = 1, > "qom-path": "/machine/unattached/device[0]", "type": "host-x86_64-cpu"} > ]} > > Before: > ./qmp-shell -N /tmp/qmp-ga.sock > Welcome to the QMP low-level shell! > Connected > (QEMU) guest-get-vcpus > {"return": [ > {"online": true, "can-offline": false, "logical-id": 0}, > {"online": true, "can-offline": true, "logical-id": 1}]} > > After: > ./qmp-shell -N /tmp/qmp-ga.sock > Welcome to the QMP low-level shell! > Connected > (QEMU) guest-get-vcpus > {"return": [ > {"online": true, "can-offline": false, "logical-id": 0}, > {"online": true, "can-offline": true, "logical-id": 1}, > {"online": true, "can-offline": true, "logical-id": 3}]} > > Signed-off-by: Lin Ma > --- > qga/commands-posix.c | 44 +++++++++++++++----------------------------- > 1 file changed, 15 insertions(+), 29 deletions(-) > > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > index c089e38120..48dcdae239 100644 > --- a/qga/commands-posix.c > +++ b/qga/commands-posix.c > @@ -2376,24 +2376,6 @@ error: > return NULL; > } > > -#define SYSCONF_EXACT(name, errp) sysconf_exact((name), #name, (errp)) > - > -static long sysconf_exact(int name, const char *name_str, Error **errp) > -{ > - long ret; > - > - errno =3D 0; > - ret =3D sysconf(name); > - if (ret =3D=3D -1) { > - if (errno =3D=3D 0) { > - error_setg(errp, "sysconf(%s): value indefinite", name_str); > - } else { > - error_setg_errno(errp, errno, "sysconf(%s)", name_str); > - } > - } > - return ret; > -} > - > /* Transfer online/offline status between @vcpu and the guest system. > * > * On input either @errp or *@errp must be NULL. > @@ -2464,24 +2446,28 @@ static void transfer_vcpu(GuestLogicalProcessor > *vcpu, bool sys2vcpu, > > GuestLogicalProcessorList *qmp_guest_get_vcpus(Error **errp) > { > - int64_t current; > GuestLogicalProcessorList *head, **link; > - long sc_max; > + const char *cpu_dir =3D "/sys/devices/system/cpu"; > + const gchar *line; > + GDir *cpu_gdir =3D NULL; > Error *local_err =3D NULL; > > - current =3D 0; > head =3D NULL; > link =3D &head; > - sc_max =3D SYSCONF_EXACT(_SC_NPROCESSORS_CONF, &local_err); > + cpu_gdir =3D g_dir_open(cpu_dir, 0, NULL); > + > + if (cpu_gdir =3D=3D NULL) { > + error_setg_errno(errp, errno, "failed to list entries: %s", > cpu_dir); > + return NULL; > + } > > - while (local_err =3D=3D NULL && current < sc_max) { > + while (local_err =3D=3D NULL && (line =3D g_dir_read_name(cpu_gdir))= !=3D > NULL) { > GuestLogicalProcessor *vcpu; > GuestLogicalProcessorList *entry; > - int64_t id =3D current++; > - char *path =3D g_strdup_printf("/sys/devices/system/cpu/cpu%" > PRId64 "/", > - id); > - > - if (g_file_test(path, G_FILE_TEST_EXISTS)) { > + int64_t id; > + if (sscanf(line, "cpu%ld", &id)) { > + g_autofree char *path =3D > g_strdup_printf("/sys/devices/system/cpu/" > + "cpu%" PRId64 "/", > id); > vcpu =3D g_malloc0(sizeof *vcpu); > vcpu->logical_id =3D id; > vcpu->has_can_offline =3D true; /* lolspeak ftw */ > @@ -2491,8 +2477,8 @@ GuestLogicalProcessorList *qmp_guest_get_vcpus(Erro= r > **errp) > *link =3D entry; > link =3D &entry->next; > } > - g_free(path); > } > + g_dir_close(cpu_gdir); > You could use g_autoptr(GDir) instead. Other than that: Reviewed-by: Marc-Andr=C3=A9 Lureau > if (local_err =3D=3D NULL) { > /* there's no guest with zero VCPUs */ > -- > 2.26.0 > > --=20 Marc-Andr=C3=A9 Lureau --0000000000000fdf8f05b5615fda Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Tue, Dec 1, 2020 at 10:14 AM Lin= Ma <lma@suse.com> wrote:
The guest-get-vcpus ret= urns incorrect vcpu info in case we hotunplug vcpus(not
the last one).
e.g.:
A VM has 4 VCPUs: cpu0 + 3 hotunpluggable online vcpus(cpu1, cpu2 and cpu3)= .
Hotunplug cpu2,=C2=A0 Now only cpu0, cpu1 and cpu3 are present & online= .

./qmp-shell /tmp/qmp-monitor.sock
(QEMU) query-hotpluggable-cpus
{"return": [
{"props": {"core-id": 0, "thread-id": 0, &quo= t;socket-id": 3}, "vcpus-count": 1,
=C2=A0"qom-path": "/machine/peripheral/cpu3", "typ= e": "host-x86_64-cpu"},
{"props": {"core-id": 0, "thread-id": 0, &quo= t;socket-id": 2}, "vcpus-count": 1,
=C2=A0"qom-path": "/machine/peripheral/cpu2", "typ= e": "host-x86_64-cpu"},
{"props": {"core-id": 0, "thread-id": 0, &quo= t;socket-id": 1}, "vcpus-count": 1,
=C2=A0"qom-path": "/machine/peripheral/cpu1", "typ= e": "host-x86_64-cpu"},
{"props": {"core-id": 0, "thread-id": 0, &quo= t;socket-id": 0}, "vcpus-count": 1,
=C2=A0"qom-path": "/machine/unattached/device[0]", &quo= t;type": "host-x86_64-cpu"}
]}

(QEMU) device_del id=3Dcpu2
{"return": {}}

(QEMU) query-hotpluggable-cpus
{"return": [
{"props": {"core-id": 0, "thread-id": 0, &quo= t;socket-id": 3}, "vcpus-count": 1,
=C2=A0"qom-path": "/machine/peripheral/cpu3", "typ= e": "host-x86_64-cpu"},
{"props": {"core-id": 0, "thread-id": 0, &quo= t;socket-id": 2}, "vcpus-count": 1,
=C2=A0"type": "host-x86_64-cpu"},
{"props": {"core-id": 0, "thread-id": 0, &quo= t;socket-id": 1}, "vcpus-count": 1,
=C2=A0"qom-path": "/machine/peripheral/cpu1", "typ= e": "host-x86_64-cpu"},
{"props": {"core-id": 0, "thread-id": 0, &quo= t;socket-id": 0}, "vcpus-count": 1,
=C2=A0"qom-path": "/machine/unattached/device[0]", &quo= t;type": "host-x86_64-cpu"}
]}

Before:
./qmp-shell -N /tmp/qmp-ga.sock
Welcome to the QMP low-level shell!
Connected
(QEMU) guest-get-vcpus
{"return": [
{"online": true, "can-offline": false, "logical-id= ": 0},
{"online": true, "can-offline": true, "logical-id&= quot;: 1}]}

After:
./qmp-shell -N /tmp/qmp-ga.sock
Welcome to the QMP low-level shell!
Connected
(QEMU) guest-get-vcpus
{"return": [
{"online": true, "can-offline": false, "logical-id= ": 0},
{"online": true, "can-offline": true, "logical-id&= quot;: 1},
{"online": true, "can-offline": true, "logical-id&= quot;: 3}]}

Signed-off-by: Lin Ma <lma@suse.com>
---
=C2=A0qga/commands-posix.c | 44 +++++++++++++++----------------------------= -
=C2=A01 file changed, 15 insertions(+), 29 deletions(-)

diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index c089e38120..48dcdae239 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -2376,24 +2376,6 @@ error:
=C2=A0 =C2=A0 =C2=A0return NULL;
=C2=A0}

-#define SYSCONF_EXACT(name, errp) sysconf_exact((name), #name, (errp))
-
-static long sysconf_exact(int name, const char *name_str, Error **errp) -{
-=C2=A0 =C2=A0 long ret;
-
-=C2=A0 =C2=A0 errno =3D 0;
-=C2=A0 =C2=A0 ret =3D sysconf(name);
-=C2=A0 =C2=A0 if (ret =3D=3D -1) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (errno =3D=3D 0) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 error_setg(errp, "sysconf(%= s): value indefinite", name_str);
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 } else {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 error_setg_errno(errp, errno, &q= uot;sysconf(%s)", name_str);
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 }
-=C2=A0 =C2=A0 }
-=C2=A0 =C2=A0 return ret;
-}
-
=C2=A0/* Transfer online/offline status between @vcpu and the guest system.=
=C2=A0 *
=C2=A0 * On input either @errp or *@errp must be NULL.
@@ -2464,24 +2446,28 @@ static void transfer_vcpu(GuestLogicalProcessor *vc= pu, bool sys2vcpu,

=C2=A0GuestLogicalProcessorList *qmp_guest_get_vcpus(Error **errp)
=C2=A0{
-=C2=A0 =C2=A0 int64_t current;
=C2=A0 =C2=A0 =C2=A0GuestLogicalProcessorList *head, **link;
-=C2=A0 =C2=A0 long sc_max;
+=C2=A0 =C2=A0 const char *cpu_dir =3D "/sys/devices/system/cpu";=
+=C2=A0 =C2=A0 const gchar *line;
+=C2=A0 =C2=A0 GDir *cpu_gdir =3D NULL;
=C2=A0 =C2=A0 =C2=A0Error *local_err =3D NULL;

-=C2=A0 =C2=A0 current =3D 0;
=C2=A0 =C2=A0 =C2=A0head =3D NULL;
=C2=A0 =C2=A0 =C2=A0link =3D &head;
-=C2=A0 =C2=A0 sc_max =3D SYSCONF_EXACT(_SC_NPROCESSORS_CONF, &local_er= r);
+=C2=A0 =C2=A0 cpu_gdir =3D g_dir_open(cpu_dir, 0, NULL);
+
+=C2=A0 =C2=A0 if (cpu_gdir =3D=3D NULL) {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 error_setg_errno(errp, errno, "failed to = list entries: %s", cpu_dir);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 return NULL;
+=C2=A0 =C2=A0 }

-=C2=A0 =C2=A0 while (local_err =3D=3D NULL && current < sc_max)= {
+=C2=A0 =C2=A0 while (local_err =3D=3D NULL && (line =3D g_dir_read= _name(cpu_gdir)) !=3D NULL) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0GuestLogicalProcessor *vcpu;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0GuestLogicalProcessorList *entry;
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 int64_t id =3D current++;
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 char *path =3D g_strdup_printf("/sys/devi= ces/system/cpu/cpu%" PRId64 "/",
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0id);
-
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (g_file_test(path, G_FILE_TEST_EXISTS)) { +=C2=A0 =C2=A0 =C2=A0 =C2=A0 int64_t id;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (sscanf(line, "cpu%ld", &id))= {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 g_autofree char *path =3D g_strd= up_printf("/sys/devices/system/cpu/"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "cpu%" PRId64 "/", i= d);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vcpu =3D g_malloc0(sizeof *= vcpu);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vcpu->logical_id =3D id;=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vcpu->has_can_offline = =3D true; /* lolspeak ftw */
@@ -2491,8 +2477,8 @@ GuestLogicalProcessorList *qmp_guest_get_vcpus(Error = **errp)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*link =3D entry;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0link =3D &entry->nex= t;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 g_free(path);
=C2=A0 =C2=A0 =C2=A0}
+=C2=A0 =C2=A0 g_dir_close(cpu_gdir);

Y= ou could use g_autoptr(GDir) instead.

Other than t= hat:
Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
=

=C2=A0 =C2=A0 =C2=A0if (local_err =3D=3D NULL) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/* there's no guest with zero VCPUs *= /
--
2.26.0



--
Marc-Andr=C3=A9 Lureau
--0000000000000fdf8f05b5615fda--