From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93D2AC432BE for ; Fri, 27 Aug 2021 09:12:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CE2160E99 for ; Fri, 27 Aug 2021 09:12:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0CE2160E99 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:37338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJXuN-0006kD-8S for qemu-devel@archiver.kernel.org; Fri, 27 Aug 2021 05:12:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJXsm-0005c9-5s for qemu-devel@nongnu.org; Fri, 27 Aug 2021 05:10:40 -0400 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:45695) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJXsj-0006wi-NK for qemu-devel@nongnu.org; Fri, 27 Aug 2021 05:10:39 -0400 Received: by mail-ed1-x52c.google.com with SMTP id g22so8899896edy.12 for ; Fri, 27 Aug 2021 02:10:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0YNWCCSx/Dlih5oGnmhKK8xxLs+azTe7SM03hLxDWS8=; b=YQ3Ta+yf9Rquanqcf0xt8AuzPh6sMOspO+J02ejUormLkb8jIu53JZGFMZPaAJaR01 or+EPFt4tKX9GeTBU+JQVOCNWxly1pv/+4KpNlhpSWkucRVLsEYOyxzY9hkiXTdD/QcD Z2WdJrsfPet/GUw8kzNY89PtqfWcHknciiNexOoIPGvneogbSkhcnBhda3JaYhX+uiMU +G44MgoDPzQAcDdLRI7x5MODo2cwDvanK0BZYVSx0UdnZqyROMrHXkjhFNx5hofzhzj/ lQfRPV4NM7EanBUm4rXh9+QGd5MFg5zOreIgbHXrbA6m4o+1BkO2aX5xaf35+YPTw1so 0K3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0YNWCCSx/Dlih5oGnmhKK8xxLs+azTe7SM03hLxDWS8=; b=b0rGoX3ZEJOaK0NGpnFUOuxaL155uA1fUuCQAb1bMNT/U9TrNDA4kkyqBtzE1aFgla IyDnt0eSIRTBmPQbBrI3ddVGXKfviae5jgPIq0nAC8RFKX1/TvzhCf0zjZMsHC0znPEY Opom25+QOH38T+GmbjExSDaTkaRlczxJ916R/t819Dd+b7UmrmUjqQAec3p1N2opvZHD W5A7wDMuvnm44zXxv+CbirgnQE0jSr8OSVs1aV5fLbUPj2Yx/gXEKvzD5dJDR59TwpvL iQpSaPfCPgfpC/ORfFqzrxWhHY472D44YCTBEA1pGyM6egJwWnH68xxFQG4W/VtGM8G3 a7+w== X-Gm-Message-State: AOAM533r/WwkgGVn9eGzWEDJByuej15VqnkomNEEjacLam1QNYe3nR+a 7+oIGUzZCroAP3l6BC71FN0nsu4G5lMMLb1yD7c= X-Google-Smtp-Source: ABdhPJxIARFTeVd7Iqxx7rg1XP6HGQVuik5/QPc6FrlTuSzKKFofOZH9l4EWZ807WKZYExA1TjbezCm+24C2o6TiUHc= X-Received: by 2002:a50:ed09:: with SMTP id j9mr8807731eds.164.1630055433282; Fri, 27 Aug 2021 02:10:33 -0700 (PDT) MIME-Version: 1.0 References: <20210825124309.223622-1-marcandre.lureau@redhat.com> In-Reply-To: From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Fri, 27 Aug 2021 13:10:21 +0400 Message-ID: Subject: Re: [PATCH] RFC: build-sys: drop dtc submodule To: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= Content-Type: multipart/alternative; boundary="00000000000010a9ed05ca86db85" Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=marcandre.lureau@gmail.com; helo=mail-ed1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , QEMU Developers , David Gibson , John Paul Adrian Glaubitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000010a9ed05ca86db85 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Fri, Aug 27, 2021 at 1:03 PM Daniel P. Berrang=C3=A9 wrote: > On Wed, Aug 25, 2021 at 07:12:10PM +0100, Peter Maydell wrote: > > On Wed, 25 Aug 2021 at 14:28, Philippe Mathieu-Daud=C3=A9 > wrote: > > > > > > On 8/25/21 2:43 PM, marcandre.lureau@redhat.com wrote: > > > > From: Marc-Andr=C3=A9 Lureau > > > > > > > > DTC is widely available, we could consider to stop bundling it. > > > > > > > > curl -s 'https://repology.org/api/v1/project/dtc' | \ > > > > jq -r 'group_by(.repo) | .[] | "\(.[0].repo): \(map(.version))"' > | \ > > > > egrep -i > 'ubuntu_18|debian_old|rhel|centos|bsd|suse_leap_15_2|sles|homebrew|pkgsrc= ' > > > > > > > > centos_8: ["1.6.0","1.6.0"] > > > > debian_oldstable: ["1.4.7"] > > > > freebsd: ["1.6.0"] > > > > homebrew: ["1.6.1"] > > > > openbsd: ["1.6.0"] > > > > opensuse_leap_15_2: ["1.5.1","1.5.1"] > > > > pkgsrc_current: ["1.4.7"] > > > > ubuntu_18_04: ["1.4.5"] > > > > > > > > MinGW package on Fedora pending review. > > > > (https://bugzilla.redhat.com/show_bug.cgi?id=3D1997511) > > > > > > > > Debian is lacking the MinGW package. > > > > > > > > Signed-off-by: Marc-Andr=C3=A9 Lureau > > > > --- > > > > configure | 22 +------------------- > > > > meson.build | 53 > ++++++++--------------------------------------- > > > > .gitmodules | 3 --- > > > > dtc | 1 - > > > > meson_options.txt | 3 --- > > > > 5 files changed, 10 insertions(+), 72 deletions(-) > > > > delete mode 160000 dtc > > > > > > Does this fix https://gitlab.com/qemu-project/qemu/-/issues/255 ? > > > "Build on sparc64 fails with "undefined reference to `fdt_check_full'= " > > > > That bug sounds like it indicates that we can't use this patch: > > a comment in the bug says that fdt_check_full() (which we use) > > was only added in libfdt 1.5.1. So the libfdt version we need > > is still not available in several of the distros we care about. > > > > I suspect the bug you link to may have been fixed -- certainly > > meson.build appears to be specifically looking for fdt_check_full() > > so we should never try to compile with a libfdt that doesn't have it. > > It is slightly more complicated - the fdt_check_full function exists > in all the distros we target AFAICT, but libfdt's ELF symbols file > never recorded its existance. So if you static link to libfdt you > get fdt_check_full but if you dynamic link it is inaccessible :-( > > I see, that's where the 1.5.1 version comes from then. commit eac2ad495b29f15d78daa2a7226653f36515cd7a Author: David Gibson Date: Mon Mar 25 14:52:47 2019 +1100 Update version.lds again git describe --contains eac2ad495b29f15d78daa2a7226653f36515cd7a v1.5.1~40 Regards, > Daniel > -- > |: https://berrange.com -o- > https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- > https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- > https://www.instagram.com/dberrange :| > > > --=20 Marc-Andr=C3=A9 Lureau --00000000000010a9ed05ca86db85 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Fri, Aug 27, 2021 at 1:03 PM Dan= iel P. Berrang=C3=A9 <berrange@re= dhat.com> wrote:
On Wed, Aug 25, 2021 at 07:12:10PM +0100, Peter Maydell wrote:
> On Wed, 25 Aug 2021 at 14:28, Philippe Mathieu-Daud=C3=A9 <f4bug@amsat.org> wrote= :
> >
> > On 8/25/21 2:43 PM, marcandre.lureau@redhat.com wrote:
> > > From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com> > > >
> > > DTC is widely available, we could consider to stop bundling = it.
> > >
> > > curl -s 'https://repology.org/api/v1/proje= ct/dtc' |=C2=A0 \
> > >=C2=A0 =C2=A0 jq -r 'group_by(.repo) | .[] | "\(.[0]= .repo): \(map(.version))"' | \
> > >=C2=A0 =C2=A0 egrep -i 'ubuntu_18|debian_old|rhel|centos|= bsd|suse_leap_15_2|sles|homebrew|pkgsrc'
> > >
> > > centos_8: ["1.6.0","1.6.0"]
> > > debian_oldstable: ["1.4.7"]
> > > freebsd: ["1.6.0"]
> > > homebrew: ["1.6.1"]
> > > openbsd: ["1.6.0"]
> > > opensuse_leap_15_2: ["1.5.1","1.5.1"] > > > pkgsrc_current: ["1.4.7"]
> > > ubuntu_18_04: ["1.4.5"]
> > >
> > > MinGW package on Fedora pending review.
> > > (https://bugzilla.redhat.com/sho= w_bug.cgi?id=3D1997511)
> > >
> > > Debian is lacking the MinGW package.
> > >
> > > Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com<= /a>>
> > > ---
> > >=C2=A0 configure=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 22 +-----= --------------
> > >=C2=A0 meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0| 53 ++++++++---= ------------------------------------
> > >=C2=A0 .gitmodules=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 3 --- > > >=C2=A0 dtc=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0|=C2=A0 1 -
> > >=C2=A0 meson_options.txt |=C2=A0 3 ---
> > >=C2=A0 5 files changed, 10 insertions(+), 72 deletions(-)
> > >=C2=A0 delete mode 160000 dtc
> >
> > Does this fix https://gitlab.com/qemu-pro= ject/qemu/-/issues/255 ?
> > "Build on sparc64 fails with "undefined reference to `f= dt_check_full'"
>
> That bug sounds like it indicates that we can't use this patch: > a comment in the bug says that fdt_check_full() (which we use)
> was only added in libfdt 1.5.1. So the libfdt version we need
> is still not available in several of the distros we care about.
>
> I suspect the bug you link to may have been fixed -- certainly
> meson.build appears to be specifically looking for fdt_check_full() > so we should never try to compile with a libfdt that doesn't have = it.

It is slightly more complicated - the fdt_check_full function exists
in all the distros we target AFAICT, but libfdt's ELF symbols file
never recorded its existance. So if you static link to libfdt you
get fdt_check_full but if you dynamic link it is inaccessible :-(


I see, that's where the 1.5.1 vers= ion comes from then.

commit eac2ad495b29f15d78= daa2a7226653f36515cd7a
Author: David Gibson <david@gibson.dropbear.id.au>
Date: =C2=A0 = Mon Mar 25 14:52:47 2019 +1100

=C2=A0 =C2=A0 Update version.lds agai= n

git describe --contains eac2ad495b29f15d78daa2a7= 226653f36515cd7a
v1.5.1~40

Regards,
Daniel
--
|: ht= tps://berrange.com=C2=A0 =C2=A0 =C2=A0 -o-=C2=A0 =C2=A0 h= ttps://www.flickr.com/photos/dberrange :|
|: htt= ps://libvirt.org=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-o-=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 https://fstop138.berrange.com :|
|: https://entangle-photo.org=C2=A0 =C2=A0 -o-=C2=A0 =C2=A0 = https://www.instagram.com/dberrange :|




--
Marc-Andr=C3=A9 Lureau
--00000000000010a9ed05ca86db85--