From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: kuhn.chenqun@huawei.com
Cc: qemu trival <qemu-trivial@nongnu.org>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
QEMU <qemu-devel@nongnu.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH] monitor: fix memory leak in monitor_fdset_dup_fd_find_remove
Date: Wed, 15 Jan 2020 11:32:47 +0400 [thread overview]
Message-ID: <CAJ+F1CJfTobGjTJm3nqdqJeh0fnHBs7dbucrq6m7otuMXYd=yg@mail.gmail.com> (raw)
In-Reply-To: <20200115072016.167252-1-kuhn.chenqun@huawei.com>
On Wed, Jan 15, 2020 at 11:21 AM <kuhn.chenqun@huawei.com> wrote:
>
> From: Chen Qun <kuhn.chenqun@huawei.com>
>
> When remove dup_fd in monitor_fdset_dup_fd_find_remove function,
> we need to free mon_fdset_fd_dup. ASAN shows memory leak stack:
>
> Direct leak of 96 byte(s) in 3 object(s) allocated from:
> #0 0xfffd37b033b3 in __interceptor_calloc (/lib64/libasan.so.4+0xd33b3)
> #1 0xfffd375c71cb in g_malloc0 (/lib64/libglib-2.0.so.0+0x571cb)
> #2 0xaaae25bf1c17 in monitor_fdset_dup_fd_add /qemu/monitor/misc.c:1724
> #3 0xaaae265cfd8f in qemu_open /qemu/util/osdep.c:315
> #4 0xaaae264e2b2b in qmp_chardev_open_file_source /qemu/chardev/char-fd.c:122
> #5 0xaaae264e47cf in qmp_chardev_open_file /qemu/chardev/char-file.c:81
> #6 0xaaae264e118b in qemu_char_open /qemu/chardev/char.c:237
> #7 0xaaae264e118b in qemu_chardev_new /qemu/chardev/char.c:964
> #8 0xaaae264e1543 in qemu_chr_new_from_opts /qemu/chardev/char.c:680
> #9 0xaaae25e12e0f in chardev_init_func /qemu/vl.c:2083
> #10 0xaaae26603823 in qemu_opts_foreach /qemu/util/qemu-option.c:1170
> #11 0xaaae258c9787 in main /qemu/vl.c:4089
> #12 0xfffd35b80b9f in __libc_start_main (/lib64/libc.so.6+0x20b9f)
> #13 0xaaae258d7b63 (/qemu/build/aarch64-softmmu/qemu-system-aarch64+0x8b7b63)
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> monitor/misc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/monitor/misc.c b/monitor/misc.c
> index a04d7edde0..cf79d36100 100644
> --- a/monitor/misc.c
> +++ b/monitor/misc.c
> @@ -1744,6 +1744,7 @@ static int64_t monitor_fdset_dup_fd_find_remove(int dup_fd, bool remove)
> if (mon_fdset_fd_dup->fd == dup_fd) {
> if (remove) {
> QLIST_REMOVE(mon_fdset_fd_dup, next);
> + g_free(mon_fdset_fd_dup);
> if (QLIST_EMPTY(&mon_fdset->dup_fds)) {
> monitor_fdset_cleanup(mon_fdset);
> }
> --
> 2.23.0
>
>
>
--
Marc-André Lureau
next prev parent reply other threads:[~2020-01-15 7:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 7:20 [PATCH] monitor: fix memory leak in monitor_fdset_dup_fd_find_remove kuhn.chenqun
2020-01-15 7:32 ` Marc-André Lureau [this message]
2020-02-06 9:41 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ+F1CJfTobGjTJm3nqdqJeh0fnHBs7dbucrq6m7otuMXYd=yg@mail.gmail.com' \
--to=marcandre.lureau@gmail.com \
--cc=dgilbert@redhat.com \
--cc=kuhn.chenqun@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).