From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CCF5C07E9D for ; Mon, 26 Sep 2022 13:17:19 +0000 (UTC) Received: from localhost ([::1]:53480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocnz4-00047l-JE for qemu-devel@archiver.kernel.org; Mon, 26 Sep 2022 09:17:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocns3-00058m-4v for qemu-devel@nongnu.org; Mon, 26 Sep 2022 09:10:03 -0400 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]:40541) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ocns1-00019o-DV for qemu-devel@nongnu.org; Mon, 26 Sep 2022 09:10:02 -0400 Received: by mail-lf1-x129.google.com with SMTP id s6so10743936lfo.7 for ; Mon, 26 Sep 2022 06:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=r177CvEfbmARPqyeNorBerUxLwLsLXcWhfnWCPP+m5M=; b=d6qMRhXg+xRyniFg3Wdr9LYojaBelOFDG7OI/OQxlpKcJVwwfuFQ7IYRoMr2hzYWFy R9NdxoAkza4wHy9qiqowdMyMgG/whTUhTqJDf25aHBXX8bS5idmSccfAsyPURc2LRPZk huW9wyAPl0a9vqCjkY+8Cu8sJm3MBeZ+pZwWIOYu4ndAqdd4jkYWkvRt/lvWfLhsx0RR heGDjBhLa09Pi9HplcR6PcCV2wnj3wmdTUJba1gqyL4L1wvUJMC7Hafq1domDUh7jAmd B+f375st4ID/0c0Jsu9ueQNKkz6BfvHSAtICrmMpQxVHFvmXe9v0dkJ/I1/S/GMiqD/e peoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=r177CvEfbmARPqyeNorBerUxLwLsLXcWhfnWCPP+m5M=; b=hiOpEUQ/AcPvUJUPooiVqesvUGY/9V3LDCrbiQznXqxulXTBZhshK69Q8iqILKx72/ gB0Ux9q1uaKhmgh28qF9OKC9ot7keajwa6ZegtehNiO0KARcfZgRDoDK34JqUWs8qKuk 30KN+EEF13kJcXJTfv6bJ7EceqgZM0NanP3IvZknD2LWTC+muK1jFzhO4wdD+cK3DwPN srhfclOvKVe5k6ljE75paFTbPkQfkAzdXVHEzQrb5/4O/CstjmzOgGqhKe5n2eYD75bf 8Z7nRDjU4aIlvUZ0RKb9zjNS7iL4KxFlazkaENETmWaV+sK8Zc7qQ6o12gOUlyAF340B RYVw== X-Gm-Message-State: ACrzQf21AkknCKhsVTArF7PDYPbK1j8nu5WBbafPrKEl5iD7Bu+Ca+kV yBBNVJzYAFTHnlwFBaNG8wtAeCK9vxOurTQih0w= X-Google-Smtp-Source: AMsMyM6cX/aN+PykUiicZKIcQfRdE9+agfmwG/TrFln0BwZw5Oaj060DRVWp/pBOZuRUdBmERiykt3jaoQSDReUEn1U= X-Received: by 2002:a05:6512:3d18:b0:498:fafb:229f with SMTP id d24-20020a0565123d1800b00498fafb229fmr9724024lfv.356.1664197799325; Mon, 26 Sep 2022 06:09:59 -0700 (PDT) MIME-Version: 1.0 References: <20220925113032.1949844-1-bmeng.cn@gmail.com> <20220925113032.1949844-11-bmeng.cn@gmail.com> In-Reply-To: <20220925113032.1949844-11-bmeng.cn@gmail.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Mon, 26 Sep 2022 17:09:47 +0400 Message-ID: Subject: Re: [PATCH v3 10/54] tests/qtest: generic_fuzz: Avoid using hardcoded /tmp To: Bin Meng Cc: qemu-devel@nongnu.org, Bin Meng , Alexander Bulekov , Bandan Das , Darren Kenny , Laurent Vivier , Paolo Bonzini , Qiuhao Li , Stefan Hajnoczi , Thomas Huth Content-Type: multipart/alternative; boundary="000000000000aa329905e9943edf" Received-SPF: pass client-ip=2a00:1450:4864:20::129; envelope-from=marcandre.lureau@gmail.com; helo=mail-lf1-x129.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000aa329905e9943edf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Sep 25, 2022 at 3:37 PM Bin Meng wrote: > From: Bin Meng > > This case was written to use hardcoded /tmp directory for temporary > files. Update to use g_dir_make_tmp() for a portable implementation. > > Signed-off-by: Bin Meng > --- > > Changes in v3: > - Split to a separate patch > > tests/qtest/fuzz/generic_fuzz_configs.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h > b/tests/qtest/fuzz/generic_fuzz_configs.h > index 0775e6702b..a825b78c14 100644 > --- a/tests/qtest/fuzz/generic_fuzz_configs.h > +++ b/tests/qtest/fuzz/generic_fuzz_configs.h > @@ -20,8 +20,8 @@ typedef struct generic_fuzz_config { > } generic_fuzz_config; > > static inline gchar *generic_fuzzer_virtio_9p_args(void){ > - char tmpdir[] =3D "/tmp/qemu-fuzz.XXXXXX"; > - g_assert_nonnull(g_mkdtemp(tmpdir)); > + g_autofree char *tmpdir =3D g_dir_make_tmp("qemu-fuzz.XXXXXX", NULL)= ; > + g_assert_nonnull(tmpdir); > Reviewed-by: Marc-Andr=C3=A9 Lureau > > return g_strdup_printf("-machine q35 -nodefaults " > "-device virtio-9p,fsdev=3Dhshare,mount_tag=3Dhshare " > -- > 2.34.1 > > > --=20 Marc-Andr=C3=A9 Lureau --000000000000aa329905e9943edf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sun, Sep 25, 2022 at 3:37 PM Bin M= eng <bmeng.cn@gmail.com> wr= ote:
From: Bin M= eng <bin.men= g@windriver.com>

This case was written to use hardcoded /tmp directory for temporary
files. Update to use g_dir_make_tmp() for a portable implementation.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
---

Changes in v3:
- Split to a separate patch

=C2=A0tests/qtest/fuzz/generic_fuzz_configs.h | 4 ++--
=C2=A01 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/gen= eric_fuzz_configs.h
index 0775e6702b..a825b78c14 100644
--- a/tests/qtest/fuzz/generic_fuzz_configs.h
+++ b/tests/qtest/fuzz/generic_fuzz_configs.h
@@ -20,8 +20,8 @@ typedef struct generic_fuzz_config {
=C2=A0} generic_fuzz_config;

=C2=A0static inline gchar *generic_fuzzer_virtio_9p_args(void){
-=C2=A0 =C2=A0 char tmpdir[] =3D "/tmp/qemu-fuzz.XXXXXX";
-=C2=A0 =C2=A0 g_assert_nonnull(g_mkdtemp(tmpdir));
+=C2=A0 =C2=A0 g_autofree char *tmpdir =3D g_dir_make_tmp("qemu-fuzz.X= XXXXX", NULL);
+=C2=A0 =C2=A0 g_assert_nonnull(tmpdir);

Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>

= =C2=A0

=C2=A0 =C2=A0 =C2=A0return g_strdup_printf("-machine q35 -nodefaults &= quot;
=C2=A0 =C2=A0 =C2=A0"-device virtio-9p,fsdev=3Dhshare,mount_tag=3Dhsha= re "
--
2.34.1




--
Marc-Andr=C3=A9 Lureau
--000000000000aa329905e9943edf--