From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 394EAC4708F for ; Tue, 1 Jun 2021 11:03:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9101613AD for ; Tue, 1 Jun 2021 11:03:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9101613AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lo2Am-0002hb-U1 for qemu-devel@archiver.kernel.org; Tue, 01 Jun 2021 07:03:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo29p-0000xg-UB for qemu-devel@nongnu.org; Tue, 01 Jun 2021 07:02:01 -0400 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:41479) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lo29n-0001zi-JH for qemu-devel@nongnu.org; Tue, 01 Jun 2021 07:02:01 -0400 Received: by mail-ed1-x52e.google.com with SMTP id j10so16727172edw.8 for ; Tue, 01 Jun 2021 04:01:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7bUDoz9djyiLt2+gFZab8MQ5LfFw7QRXQlLdrWBjpyU=; b=hfHAY+zsIivVRubuNo0f524VrPDXtYl6rg9f7BPbAsBjEuKHR/yK8358yFwnUvtekB 16ZvLDv9X2jP6dr6EBzQIxn3v/GOuFoCok13rPzzJMXLNyg7MSDF2/jCnRgyK+LYoxcl /qUeDnbHpOGGAfPRqooOcPUPOx+5+2kztaH0IfYrNVdNxZEC+Oq3eYS4+WOgZZlSqESG wb5KhGb3CkGHPtbr9+WkcqYqMeQDXoZwmsWJwujH0SO0/Rl3Vs9raZak3Vhby69Z6ILY lC0P86pqfrg9UFrxHgt5GTHCA72nyPV46FFGpgYFIiYtB6vX/E6q+v3VlMcF29uWTiZL 4aGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7bUDoz9djyiLt2+gFZab8MQ5LfFw7QRXQlLdrWBjpyU=; b=OJEHju19BOgWim8OAuZQp0Kh8lHOatY1yNCS+y64DrVqgIYCJp+HlYounOMQHfdUPy IIuMc5AuRvp8NWXeac45/FpvCDxasRKKlzgbN0/pO8vItpLlNxKnV0yS+TAPEFaQBpJ2 crwPmxo2VfQC+8tdSz8KRUJqkI+kneTTSN5ZqMdGuuKYULagwDwqO0/tMa7aUaigC0XM XHDNMsBViYsuvGY96nSKl8McIfope0GDgSD079hPR0H53qZ8lFhRzLmYwz5JKKqzQpRk DV/rCkXZSEZiYyNl2paeqdBKqYoPPD+23NsOZAqrb9FtwBzEZeQE4IiOjSgJi/pof6GB V84Q== X-Gm-Message-State: AOAM530D4bw+GIoL7FVnby2mSCB7HHxgjDluwhwsb5F9c+qc4qvmukvW UrCB20g2Qb0dRBdPb8zCLvpagc2lY9YxqFfoDt7863Gw9MfiTw== X-Google-Smtp-Source: ABdhPJx62QXMMhs4koMz55mhbpEloAuPYfRP5oovpmoB/0/8nUqenVPNONyqlUdzSo5SDe8dhVm+vX5lU8rSax9LAhE= X-Received: by 2002:aa7:cfd4:: with SMTP id r20mr8205097edy.237.1622545316484; Tue, 01 Jun 2021 04:01:56 -0700 (PDT) MIME-Version: 1.0 References: <20210529185522.78816-1-marcandre.lureau@redhat.com> In-Reply-To: From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Tue, 1 Jun 2021 15:01:44 +0400 Message-ID: Subject: Re: [PULL 0/2] Libslirp patches To: Peter Maydell Content-Type: multipart/alternative; boundary="00000000000038987f05c3b2457f" Received-SPF: pass client-ip=2a00:1450:4864:20::52e; envelope-from=marcandre.lureau@gmail.com; helo=mail-ed1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Thibault , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000038987f05c3b2457f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Peter On Tue, Jun 1, 2021 at 1:17 PM Peter Maydell wrote: > On Sat, 29 May 2021 at 19:55, wrote: > > > > From: Marc-Andr=C3=A9 Lureau > > > > The following changes since commit > 62c0ac5041e9130b041adfa13a41583d3c3ddd24: > > > > Merge remote-tracking branch > 'remotes/rth-gitlab/tags/pull-tcg-20210526' into staging (2021-05-28 > 16:25:21 +0100) > > > > are available in the Git repository at: > > > > git@github.com:elmarco/qemu.git tags/libslirp-pull-request > > > > for you to fetch changes up to b060428091c758781acc4d42849accc036d3c816= : > > > > build-sys: make libslirp a meson subproject (2021-05-29 22:52:37 +040= 0) > > > > ---------------------------------------------------------------- > > Update libslirp & make it a subproject > > > > ---------------------------------------------------------------- > > All hosts, odd warnings on checkout and running configure: > > warning: unable to rmdir 'slirp': Directory not empty > This one is from git itself. It doesn't clean up old submodule locations, even though they are actually "clean". git submodule "(re)move" has its limits I guess. make: Entering directory '/home/pm/qemu/build/all' > config-host.mak is out-of-date, running configure > GIT ui/keycodemapdb meson tests/fp/berkeley-testfloat-3 > tests/fp/berkeley-softfloat-3 dtc capstone slirp > warn: ignoring non-existent submodule slirp > However, I don't get this when simply running make. Maybe you run make in parallel, and config-host.mak didn't have the time to regenerate with a new GIT_SUBMODULES. I wonder if we miss a dependency like "git-submodule-update: config-host.mak" ? Running configure before make should also prevent this from happening. > BSD VMs: error message just before launching the VM (though the VM did > seem to then launch OK): > > Found ninja-1.8.2 at /usr/bin/ninja > ninja: no work to do. > (GIT=3D"git" "/home/peter.maydell/qemu-netbsd/scripts/git-submodule.sh" > update ui/keycodemapdb meson tests/fp/berkeley-testfloat-3 tests/fp/be > rkeley-softfloat-3 dtc capstone slirp) > warn: ignoring non-existent submodule slirp > /usr/bin/python3 -B /home/peter.maydell/qemu-netbsd/tests/vm/netbsd > --debug --jobs 8 --verbose --image > "/home/peter.maydell/.cache/qemu > -vm/images/netbsd.img" --snapshot --build-qemu > /home/peter.maydell/qemu-netbsd -- > DEBUG:root:Creating archive > /home/peter.maydell/qemu-netbsd/build/vm-test-6kefrq76.tmp/data-f706c.tar > for src_dir dir: /home/peter.maydell/q > emu-netbsd > error: pathspec 'slirp' did not match any file(s) known to git. > > clang sanitizer build: link failure: > subprojects/libslirp/libslirp.so.0.3.0.p/src_arp_table.c.o: In > function `arp_table_add': > > /home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libsl= irp/src/arp_table.c:51: > undefined reference to `__ubsan_handle_type_mismatch_v1' > > /home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libsl= irp/src/arp_table.c:51: > undefined reference to `__ubsan_handle_type_mismatch_v1' > > /home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libsl= irp/src/arp_table.c:51: > undefined reference to `__ubsan_handle_type_mismatch_v1' > > /home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libsl= irp/src/arp_table.c:34: > undefined reference to `__ubsan_handle_type_mismatch_v1' > > /home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libsl= irp/src/arp_table.c:34: > undefined reference to `__ubsan_handle_type_mismatch_v1' > (and lots more similar) > > I don't get this when running make vm-build-netbsd. What else am I missing= ? > > OSX: linker warnings linking libslirp.0.dylib: > > > [34/1977] Linking target subprojects/libslirp/libslirp.0.dylib > ld: warning: dylib > (/usr/local/Cellar/glib/2.68.0/lib/libgthread-2.0.dylib) was built for > newer macOS version (10.15) than being linked (10.4) > ld: warning: dylib > (/usr/local/Cellar/glib/2.68.0/lib/libglib-2.0.dylib) was built for > newer macOS version (10.15) than being linked (10.4) > ld: warning: dylib (/usr/local/opt/gettext/lib/libintl.dylib) was > built for newer macOS version (10.14) than being linked (10.4) > > This looks related to: https://gitlab.freedesktop.org/slirp/libslirp/-/commit/410e296a52fb274648f8= ecf53561eaab4b33c52c It could be that we need to use the version information from glib (or from any libraries used). It looks safe to ignore although I re-opened: https://gitlab.freedesktop.org/slirp/libslirp/-/issues/36#note_940695 --=20 Marc-Andr=C3=A9 Lureau --00000000000038987f05c3b2457f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Peter

On Tue, Jun 1, 2021 at 1:17 P= M Peter Maydell <peter.mayde= ll@linaro.org> wrote:
On Sat, 29 May 2021 at 19:55, <marcandre.lureau@redhat.com> wr= ote:
>
> From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>
> The following changes since commit 62c0ac5041e9130b041adfa13a41583d3c3= ddd24:
>
>=C2=A0 =C2=A0Merge remote-tracking branch 'remotes/rth-gitlab/tags/= pull-tcg-20210526' into staging (2021-05-28 16:25:21 +0100)
>
> are available in the Git repository at:
>
>=C2=A0 =C2=A0git@github.com:elmarco/qemu.git tags/libslirp-pull-request=
>
> for you to fetch changes up to b060428091c758781acc4d42849accc036d3c81= 6:
>
>=C2=A0 =C2=A0build-sys: make libslirp a meson subproject (2021-05-29 22= :52:37 +0400)
>
> ----------------------------------------------------------------
> Update libslirp & make it a subproject
>
> ----------------------------------------------------------------

All hosts, odd warnings on checkout and running configure:

warning: unable to rmdir 'slirp': Directory not empty

This one is from git itself. It doesn't clean up= old submodule locations, even though they are actually "clean". = git submodule "(re)move" has its limits I guess.
<= br>
make: Entering directory '/home/pm/qemu/build/all'
config-host.mak is out-of-date, running configure
=C2=A0 GIT=C2=A0 =C2=A0 =C2=A0ui/keycodemapdb meson tests/fp/berkeley-testf= loat-3
tests/fp/berkeley-softfloat-3 dtc capstone slirp
warn: ignoring non-existent submodule slirp

=
=C2=A0However, I don't get this when simply running make. Maybe yo= u run make in parallel, and config-host.mak didn't have the time to reg= enerate with a new GIT_SUBMODULES.

I wonder i= f we miss a dependency like "git-submodule-update: config-host.mak&quo= t; ?

Running configure before make shoul= d also prevent this from happening.


BSD VMs: error message just before launching the VM (though the VM did
seem to then launch OK):

Found ninja-1.8.2 at /usr/bin/ninja
ninja: no work to do.
(GIT=3D"git" "/home/peter.maydell/qemu-netbsd/scripts/git-su= bmodule.sh"
update ui/keycodemapdb meson tests/fp/berkeley-testfloat-3 tests/fp/be
rkeley-softfloat-3 dtc capstone slirp)
warn: ignoring non-existent submodule slirp
/usr/bin/python3 -B /home/peter.maydell/qemu-netbsd/tests/vm/netbsd
--debug=C2=A0 --jobs 8 --verbose=C2=A0 =C2=A0 --image
"/home/peter.maydell/.cache/qemu
-vm/images/netbsd.img"=C2=A0 --snapshot --build-qemu
/home/peter.maydell/qemu-netbsd --
DEBUG:root:Creating archive
/home/peter.maydell/qemu-netbsd/build/vm-test-6kefrq76.tmp/data-f706c.tar for src_dir dir: /home/peter.maydell/q
emu-netbsd
error: pathspec 'slirp' did not match any file(s) known to git.
=

clang sanitizer build: link failure:
subprojects/libslirp/libslirp.so.0.3.0.p/src_arp_table.c.o: In
function `arp_table_add':
/home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libslir= p/src/arp_table.c:51:
undefined reference to `__ubsan_handle_type_mismatch_v1'
/home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libslir= p/src/arp_table.c:51:
undefined reference to `__ubsan_handle_type_mismatch_v1'
/home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libslir= p/src/arp_table.c:51:
undefined reference to `__ubsan_handle_type_mismatch_v1'
/home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libslir= p/src/arp_table.c:34:
undefined reference to `__ubsan_handle_type_mismatch_v1'
/home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libslir= p/src/arp_table.c:34:
undefined reference to `__ubsan_handle_type_mismatch_v1'
(and lots more similar)


I don't get this=C2=A0 when r= unning make vm-build-netbsd. What else am I missing?
=C2=A0
OSX: linker warnings linking libslirp.0.dylib:


[34/1977] Linking target subprojects/libslirp/libslirp.0.dylib
ld: warning: dylib
(/usr/local/Cellar/glib/2.68.0/lib/libgthread-2.0.dylib) was built for
newer macOS version (10.15) than being linked (10.4)
ld: warning: dylib
(/usr/local/Cellar/glib/2.68.0/lib/libglib-2.0.dylib) was built for
newer macOS version (10.15) than being linked (10.4)
ld: warning: dylib (/usr/local/opt/gettext/lib/libintl.dylib) was
built for newer macOS version (10.14) than being linked (10.4)


This looks related to:
<= a href=3D"https://gitlab.freedesktop.org/slirp/libslirp/-/commit/410e296a52= fb274648f8ecf53561eaab4b33c52c">https://gitlab.freedesktop.org/slirp/libsli= rp/-/commit/410e296a52fb274648f8ecf53561eaab4b33c52c

It could be that we need to use the version information from glib (o= r from any libraries used).

It looks safe to ignor= e although I re-opened:

--
Marc-Andr=C3=A9 Lureau
--00000000000038987f05c3b2457f--