From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E66C4743F for ; Tue, 8 Jun 2021 11:43:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88DD361358 for ; Tue, 8 Jun 2021 11:43:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88DD361358 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqa96-0004Xi-Oy for qemu-devel@archiver.kernel.org; Tue, 08 Jun 2021 07:43:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqa47-0005IH-UE for qemu-devel@nongnu.org; Tue, 08 Jun 2021 07:38:39 -0400 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]:33404) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqa46-00009a-22 for qemu-devel@nongnu.org; Tue, 08 Jun 2021 07:38:39 -0400 Received: by mail-ej1-x62b.google.com with SMTP id g20so32145715ejt.0 for ; Tue, 08 Jun 2021 04:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vi86xr/Q+WrsTdXv4exGJJ7urNIZbrdiA75YHHjJXYo=; b=OUR5MflmR3KXZrgHsQhh0ebwPhCppJd4t5HlwYrgpcTaqFyTv8y9Y/95esRIMac2ve j2gcIjYOdL5hJ1SqyPIYVHlBP/dxxkVRvdfwMB04k0SKYvtMlsoXXT5ta++qQ42oktJ6 Gk+F7KMY+xbQWEvHqFDRRuuo3mgsKsCwXBjfSWRDXmGsPTuQVpKm145AHVuepYUeC5d2 cRzrbu/yr7dfYefZ4QKwPklmO2UzB3rtfpm4WgDV94l/0Awz+FZguiqwWWlZS9XtqH+k 0BHzNMXKYXgmHD2I41ZgAn4myOGLTuRxVlc3sMC24JEQlp0MgpiPFttvhkZpPKBQ7Ak8 eVRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vi86xr/Q+WrsTdXv4exGJJ7urNIZbrdiA75YHHjJXYo=; b=sF8urg3AYoJgEhCaObuIpG6Iu9CQc44aiO1XJdFo9Llnq2eGcKv7IRHD97IbzM42oI 1H7G0iH9xBppUWirG9DEDfdriUEHkBkwCgQ4V5ffMHi4eV8jpy0Qcl/FQGR70MINz7aW bWHzQKTrnhEt0lkya+XRJ9RVY3nL6fqsCImW/pI4gsO5sUY6/PDt8Go0ure5virIGUe3 VehkziXLYCxo0ZEFpYCbbdWwcMJYDCCHCGVdkRxr6KIo4VR6bHjY/c6sTU8gf7AjbbYE y5KN7gxVsOiBRNHWWfKzRQEc2Zf7ZRcwwl2Bditw59ixwn1ZWWHnnarYtz/dnzmpwsmE GOiw== X-Gm-Message-State: AOAM530hOXm4Aj9QheqGM/xPmo1Hq0daXmd7EcsbynOnTr/TPf6gI/UX D0UoHmty56u92JJvy3La1a2gTrKWWw2eZfdlJOM= X-Google-Smtp-Source: ABdhPJwOa3w55tezVSpDP8NySXPdreWKer8DZNLpD0mwpg1lA9c7dYS+LR1gQ0XarnxHtHMolQKVGTSQ0H1mavpT6zA= X-Received: by 2002:a17:907:7b9e:: with SMTP id ne30mr23180592ejc.389.1623152316136; Tue, 08 Jun 2021 04:38:36 -0700 (PDT) MIME-Version: 1.0 References: <20210517163040.2308926-1-marcandre.lureau@redhat.com> <20210517163040.2308926-2-marcandre.lureau@redhat.com> <20210607141835.jh3vevk6oqgyd5vx@redhat.com> In-Reply-To: <20210607141835.jh3vevk6oqgyd5vx@redhat.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Tue, 8 Jun 2021 15:38:24 +0400 Message-ID: Subject: Re: [PATCH v4 1/9] qapi: replace List[str] by QAPISchemaIfCond To: Eric Blake Content-Type: multipart/alternative; boundary="000000000000383f4405c43f99e7" Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=marcandre.lureau@gmail.com; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , QEMU , Stefan Hajnoczi , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000383f4405c43f99e7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Mon, Jun 7, 2021 at 6:19 PM Eric Blake wrote: > On Mon, May 17, 2021 at 08:30:32PM +0400, marcandre.lureau@redhat.com > wrote: > > From: Marc-Andr=C3=A9 Lureau > > > > Wrap the 'if' condition in a higher-level object. Not only this allows > > more type safety but also further refactoring without too much churn. > > Grammar suggestion: > > Not only does this provide more type safety, but it also enables > further refactoring without too much churn. > > done, thanks > > > The following patches will change the syntax of the schema 'if' > > conditions to be predicate expressions, and will generate code for > > different target languages (C, and Rust in another series). > > > > Signed-off-by: Marc-Andr=C3=A9 Lureau > > Reviewed-by: Stefan Hajnoczi > > Tested-by: John Snow > > --- > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org > > > --=20 Marc-Andr=C3=A9 Lureau --000000000000383f4405c43f99e7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Mon, Jun 7, 2021 at 6:19 PM Eric Blake <= ;eblake@redhat.com> wrote:
<= /div>
On Mon, May 17, 2021= at 08:30:32PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>
> Wrap the 'if' condition in a higher-level object. Not only thi= s allows
> more type safety but also further refactoring without too much churn.<= br>
Grammar suggestion:

Not only does this provide more type safety, but it also enables
further refactoring without too much churn.


done, thanks

>
> The following patches will change the syntax of the schema 'if'= ;
> conditions to be predicate expressions, and will generate code for
> different target languages (C, and Rust in another series).
>
> Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Tested-by: John Snow <jsnow@redhat.com>
> ---

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0+1-919-301-3266
Virtualization:=C2=A0 qemu.org | libvirt.org




--
Marc-Andr=C3=A9 Lureau
--000000000000383f4405c43f99e7--