qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: "Elena Ufimtseva" <elena.ufimtseva@oracle.com>,
	"John G Johnson" <john.g.johnson@oracle.com>,
	"Jag Raman" <jag.raman@oracle.com>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Felipe Franciosi" <felipe@nutanix.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Feedback on multi-process QEMU muser prototype
Date: Tue, 14 Jan 2020 15:22:30 +0000	[thread overview]
Message-ID: <CAJSP0QWUfHyAk-xLFA1-sWSU7CvB4yKu0=Okoc7wcv7TinmXWg@mail.gmail.com> (raw)

I haven't seen the link to the muser prototype shared on the list yet,
so I'm taking the liberty of posting it for discussion:
https://github.com/oracle/qemu/tree/multi-process-qemu-v0.4.1-muser

Great that a lot of the multi-process patch series is no longer
necessary.  The muser approach requires less code in QEMU.

The following points came to mind:

1. Configure PCI configuration space, BARs, and MSI/IRQs based on the PCIDevice
   instead of hard-coding the LSI SCSI controller's specifics.  That way any
   PCIDevice can run as an muser device.

2. Integrate with QEMU's event loop instead of spawning threads and calling
   lm_ctx_run().  The event loop should monitor the muser fd for activity using
   aio_set_fd_handler() and then call into libmuser to handle the event.  This
   will avoid thread model problems in the future and also allow true
   multi-threading (IOThreads).

3. Drop previous multi-process QEMU commits if they are not needed.

Stefan


             reply	other threads:[~2020-01-14 15:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 15:22 Stefan Hajnoczi [this message]
2020-01-15 10:58 ` Feedback on multi-process QEMU muser prototype Felipe Franciosi
2020-01-20 10:41   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJSP0QWUfHyAk-xLFA1-sWSU7CvB4yKu0=Okoc7wcv7TinmXWg@mail.gmail.com' \
    --to=stefanha@gmail.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=elena.ufimtseva@oracle.com \
    --cc=felipe@nutanix.com \
    --cc=jag.raman@oracle.com \
    --cc=john.g.johnson@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).