From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55CD4C2D0E4 for ; Fri, 20 Nov 2020 19:36:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E01A22264 for ; Fri, 20 Nov 2020 19:36:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dvkn9ZfO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E01A22264 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgCCz-00005R-Bo for qemu-devel@archiver.kernel.org; Fri, 20 Nov 2020 14:36:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgCCC-00084y-Th for qemu-devel@nongnu.org; Fri, 20 Nov 2020 14:35:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:38374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kgCCA-00041V-8l for qemu-devel@nongnu.org; Fri, 20 Nov 2020 14:35:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605900945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kaGyevx9bKbJa/Uo/GEmlNDAH9YfZ7oI6laQDA+pda0=; b=dvkn9ZfO4Mus2kZTp+oQRHSOGY8/M7o2hD2pvcjDx+4iCgX6pvxSNCQPravPpv/KSbL4SO xQ/Spk8Pp5VEd9gOru7b44HMBZtVynOeTf1Nv3ugXdcNWNhbVNr6IIF0LkEHXuqXrGYhcQ XcGDVAORxENWthLJjMdUUSfYl1qsKrU= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-76TeTUUrPlSSDbfQD0606A-1; Fri, 20 Nov 2020 14:35:42 -0500 X-MC-Unique: 76TeTUUrPlSSDbfQD0606A-1 Received: by mail-qt1-f197.google.com with SMTP id z8so8195123qti.17 for ; Fri, 20 Nov 2020 11:35:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kaGyevx9bKbJa/Uo/GEmlNDAH9YfZ7oI6laQDA+pda0=; b=uC1DiZP2KgV1LRwQl7pn/WCbIaTx/Cd6fZJvLh+Jv5p3n5CGy0vDI5jysomq+pFJu+ cxjsRS00aucHv0ZAtCLuOF6+V0sv7cSTkfGPD68M3xcYyTE/y/bwpoUnxlRwe4sGSt9b +aBWa2LC1ChMHTRnr69CTJ6CjujyyQaW7QnCuZPOvH0ejDZrOFXekxiD9Tk5cX2M4NXQ uhArAKGpy+5S4LpzlvjEFiqdAj3vqGYibwOn4KwJmBoVXjXl8aVQO6crbcp4WXNl9RnG GV6Wbeoi0HjevE64rnKR2lc3kfnaQKZTorN1HHwiWLAw0u90QiOPZqhIPGn4qRx7Uq0h PQug== X-Gm-Message-State: AOAM5323qy8qpKj+RQGSUZ7W5KXeE+CNKbME4v5aP0orN0M4GOL3p2SX cpITZ1AQhk+jD1Abeih97eaBpc+OllwjmiQjXhjuxC0fS61m8D+TpPczWtZckJ3HVCXtluiIeY1 cloBgZvJjvDnMWpyLZOTQxOAFYHAotPQ= X-Received: by 2002:ad4:4051:: with SMTP id r17mr13579864qvp.39.1605900942256; Fri, 20 Nov 2020 11:35:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJyEWE3AxwjU9e+BlJSEt7dnIJDH7qPT0GZiFEk0NSR9+fpXLCgv65B/saA/egK3fv56fMNdOMAejiJ325PXQg8= X-Received: by 2002:ad4:4051:: with SMTP id r17mr13579837qvp.39.1605900942042; Fri, 20 Nov 2020 11:35:42 -0800 (PST) MIME-Version: 1.0 References: <20201120185105.279030-1-eperezma@redhat.com> <20201120185105.279030-26-eperezma@redhat.com> In-Reply-To: <20201120185105.279030-26-eperezma@redhat.com> From: Eugenio Perez Martin Date: Fri, 20 Nov 2020 20:35:06 +0100 Message-ID: Subject: Re: [RFC PATCH 25/27] vhost: Do not commit vhost used idx on vhost_virtqueue_stop To: qemu-level Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eperezma@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm list , "Michael S. Tsirkin" , Jason Wang , Daniel Daly , virtualization@lists.linux-foundation.org, Liran Alon , Eli Cohen , Nitin Shrivastav , Alex Barba , Christophe Fontaine , Juan Quintela , Lee Ballard , Lars Ganrot , Rob Miller , Stefano Garzarella , Howard Cai , Parav Pandit , vm , Salil Mehta , Stephen Finucane , Xiao W Wang , Sean Mooney , Stefan Hajnoczi , Jim Harford , Dmytro Kazantsev , Siwei Liu , Harpreet Singh Anand , Michael Lilja , Max Gurtovoy Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Nov 20, 2020 at 8:12 PM Eugenio P=C3=A9rez wr= ote: > > ... if sw lm is enabled > > Signed-off-by: Eugenio P=C3=A9rez > --- > hw/virtio/vhost.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c > index cb44b9997f..cf000b979f 100644 > --- a/hw/virtio/vhost.c > +++ b/hw/virtio/vhost.c > @@ -1424,17 +1424,22 @@ static void vhost_virtqueue_stop(struct vhost_dev= *dev, > struct vhost_vring_state state =3D { > .index =3D vhost_vq_index, > }; > - int r; > + int r =3D -1; > > if (virtio_queue_get_desc_addr(vdev, idx) =3D=3D 0) { > /* Don't stop the virtqueue which might have not been started */ > return; > } > > - r =3D dev->vhost_ops->vhost_get_vring_base(dev, &state); > - if (r < 0) { > - VHOST_OPS_DEBUG("vhost VQ %u ring restore failed: %d", idx, r); > - /* Connection to the backend is broken, so let's sync internal > + if (!dev->sw_lm_enabled) { > + r =3D dev->vhost_ops->vhost_get_vring_base(dev, &state); > + if (r < 0) { > + VHOST_OPS_DEBUG("vhost VQ %u ring restore failed: %d", idx, = r); > + } > + } > + > + if (!dev->sw_lm_enabled || r < 0) { This test should actually test for `dev->sw_lm_enabled`, not for negation. > + /* Connection to the backend is unusable, so let's sync internal > * last avail idx to the device used idx. > */ > virtio_queue_restore_last_avail_idx(vdev, idx); > -- > 2.18.4 >