From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50DE5C48BE5 for ; Mon, 21 Jun 2021 05:42:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3206610C7 for ; Mon, 21 Jun 2021 05:42:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3206610C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvChR-0002FI-4e for qemu-devel@archiver.kernel.org; Mon, 21 Jun 2021 01:42:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvCfd-0000CQ-Ga for qemu-devel@nongnu.org; Mon, 21 Jun 2021 01:40:29 -0400 Received: from mail-qt1-x834.google.com ([2607:f8b0:4864:20::834]:44741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lvCfb-0008UD-6O for qemu-devel@nongnu.org; Mon, 21 Jun 2021 01:40:29 -0400 Received: by mail-qt1-x834.google.com with SMTP id d9so12557161qtp.11 for ; Sun, 20 Jun 2021 22:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H18no8rwOwep5EM/qCes24/Dr5M502fsac8OlvlWGP4=; b=AdPX2mZzG5YgA/+bovdEiMEIanl4/urm9lcaafchrztIjxj4vyQjO1gtrLFoO0B8tQ 12IwSWr0yp5KywgfgGbPmbH0K1HBiMQxtJDV5IY+Yogg/4Vj3WthKi+xE46r0ABOStDP KFyOlAZqt4MVfcYvj7aur3htCl1jIMCoG2m0eRlI5YxyE1xpI/wObuozwr22Xlr3wTjb TVlEv1DLthPsnCOSwlK8gExVphqKexRg2P+JeIThEILFKUt6t5dxH0KZW8Xya780QfBw Lud0jF2oXiNNC2+Ew+2oq+VXJ0s7mV00V0sPcb+iqf/6etWjU5CG+dY13LG6uT5LFeOr 8riw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H18no8rwOwep5EM/qCes24/Dr5M502fsac8OlvlWGP4=; b=MB+ocoukg7yMZsFnA4vKBeKOFd7Lmu1VZwGJMe64nrypIInoaRWcSk0d+Z8Lh5/2A3 0PG95e+3UEDeWsrzOHqvdD75QF2X17PfN1GjQVXpPe2EW9KgyY2ffIbCnlmPuKeY5Qyh itiukWjPBnhj49t0JbaYMasX1hxmgxKBTwP60CRXuXVKagQEDZTWQjy6UmQGNegFFsL8 4gb9XgRthAdGCBhGB+u5IfKxBfmoQAZTLxhDVtqT5laPV15Mm+JJJudadqtTQDPIi1rY ofjwTG623MX2xVMyidTMoCUP4A9gcRUYIsZ/y/DrlSrSM4pJKRUzQEa0lES7NaDIkkAz idbQ== X-Gm-Message-State: AOAM530nvXxj7vXpxRiVvNgTa9175LJG6grotiECSciTWW7YJ5FRr92E W1/1/z9n94AHLV+g2SA11QKeA2KlEyk15lFHDRY= X-Google-Smtp-Source: ABdhPJzBfFor5bklWvGtWrLq6zVj3a+tGq5xVNRJHqJp6U7ai2CDdpljxnGGhYXacLc9XgKJoghg5hs6g+LuGxId38c= X-Received: by 2002:ac8:6b42:: with SMTP id x2mr22480662qts.382.1624254026242; Sun, 20 Jun 2021 22:40:26 -0700 (PDT) MIME-Version: 1.0 References: <20210621013439.1791385-1-richard.henderson@linaro.org> <20210621013439.1791385-8-richard.henderson@linaro.org> In-Reply-To: <20210621013439.1791385-8-richard.henderson@linaro.org> From: Michael Rolnik Date: Mon, 21 Jun 2021 08:39:50 +0300 Message-ID: Subject: Re: [PATCH 07/26] target/avr: Mark some helpers noreturn To: Richard Henderson Content-Type: multipart/alternative; boundary="000000000000425d8f05c5401cf3" Received-SPF: pass client-ip=2607:f8b0:4864:20::834; envelope-from=mrolnik@gmail.com; helo=mail-qt1-x834.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000425d8f05c5401cf3 Content-Type: text/plain; charset="UTF-8" Reviewed-by: Michael Rolnik On Mon, Jun 21, 2021 at 4:34 AM Richard Henderson < richard.henderson@linaro.org> wrote: > All of these helpers end with cpu_loop_exit. > > Cc: Michael Rolnik > Signed-off-by: Richard Henderson > --- > target/avr/helper.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/target/avr/helper.h b/target/avr/helper.h > index 8e1ae7fda0..4d02e648fa 100644 > --- a/target/avr/helper.h > +++ b/target/avr/helper.h > @@ -19,10 +19,10 @@ > */ > > DEF_HELPER_1(wdr, void, env) > -DEF_HELPER_1(debug, void, env) > -DEF_HELPER_1(break, void, env) > -DEF_HELPER_1(sleep, void, env) > -DEF_HELPER_1(unsupported, void, env) > +DEF_HELPER_1(debug, noreturn, env) > +DEF_HELPER_1(break, noreturn, env) > +DEF_HELPER_1(sleep, noreturn, env) > +DEF_HELPER_1(unsupported, noreturn, env) > DEF_HELPER_3(outb, void, env, i32, i32) > DEF_HELPER_2(inb, tl, env, i32) > DEF_HELPER_3(fullwr, void, env, i32, i32) > -- > 2.25.1 > > -- Best Regards, Michael Rolnik --000000000000425d8f05c5401cf3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Michael Rolnik <mrolnik@gmail.com>


On Mon, Jun 21, 2021 at = 4:34 AM Richard Henderson <richard.henderson@linaro.org> wrote:
All of these helpers end with cpu_loop_exi= t.

Cc: Michael Rolnik <mrolnik@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
=C2=A0target/avr/helper.h | 8 ++++----
=C2=A01 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/target/avr/helper.h b/target/avr/helper.h
index 8e1ae7fda0..4d02e648fa 100644
--- a/target/avr/helper.h
+++ b/target/avr/helper.h
@@ -19,10 +19,10 @@
=C2=A0 */

=C2=A0DEF_HELPER_1(wdr, void, env)
-DEF_HELPER_1(debug, void, env)
-DEF_HELPER_1(break, void, env)
-DEF_HELPER_1(sleep, void, env)
-DEF_HELPER_1(unsupported, void, env)
+DEF_HELPER_1(debug, noreturn, env)
+DEF_HELPER_1(break, noreturn, env)
+DEF_HELPER_1(sleep, noreturn, env)
+DEF_HELPER_1(unsupported, noreturn, env)
=C2=A0DEF_HELPER_3(outb, void, env, i32, i32)
=C2=A0DEF_HELPER_2(inb, tl, env, i32)
=C2=A0DEF_HELPER_3(fullwr, void, env, i32, i32)
--
2.25.1



--
Best Regards,
Michael Rolnik
--000000000000425d8f05c5401cf3--