From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7FA7C433EF for ; Mon, 6 Dec 2021 08:52:14 +0000 (UTC) Received: from localhost ([::1]:33858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mu9jJ-0000vd-TC for qemu-devel@archiver.kernel.org; Mon, 06 Dec 2021 03:52:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mu9hM-0006iM-Q0; Mon, 06 Dec 2021 03:50:14 -0500 Received: from [2607:f8b0:4864:20::92a] (port=38872 helo=mail-ua1-x92a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mu9hK-0002db-Fc; Mon, 06 Dec 2021 03:50:12 -0500 Received: by mail-ua1-x92a.google.com with SMTP id w23so18061563uao.5; Mon, 06 Dec 2021 00:50:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uIBm+33khz4qJcB2S1bLN20qZ2ixev1x0wOal4KORmE=; b=QWwVM2F6bnMSG55dUZiEiYLbc1bPqjs8vnon/ZoVrS1Y0OyoBodJzeKHTZSZTSvgpH AIegTf3gNVYhWi2rMnLYZqvUMzgoA8LhPaUIzjf3+/bxlvWfp5M2wFmmWzJfyOgVFaI4 h20Txzcd7hjX2MDvRdRP0p6MXUX5sgoWKWJoUJPAGsIgy8Pbk7KoKcxhx29a/LVfcBzv u45ca+zApo2aNZhg1o/kQmpeXhO5jX/vH1PxQAckIq+AnjrWvvqVAmMQ4+c6kBs7N0uB MYPZemXDqkvl5R3yNaWQFqOjRWRplnqTnjnNjSG4p2xxAcsD3XKJapm9kzENKcL7nR3f rlVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uIBm+33khz4qJcB2S1bLN20qZ2ixev1x0wOal4KORmE=; b=72kGRL4wusig6MkDeUsKhhPp7fZQHZEYP75M1Iy/eqLA2anFzbeEPMFCJdi2wbV5lW GfAxx74Tj32Q5+vbfTcN2bmxcExIfmoZKNuXaQDqbF5MrcdQucenbpFHoAGw8UlWHKVa 09nzm3JnDdMrIy0yg/i0I+RGqaoPvKANhzt079ITV8Q4WTUZJeh352Zr3c7CVrw5JXzV fehNly2Lct1J1TF9CY41K/hHODi4Y04DljGwsDM2aQ2bn4+1eJKd1TMTMjNaktaBGUPW ZJBOWtNAnbF7baodC+zcceDBonr0Mg2NX+hUUdXcj8h+wiRr1ZPrlF/FqbMkMo3XDEkK aOdQ== X-Gm-Message-State: AOAM531VY2MGuCAzzXdYVQY2tHWyE2oK/Mcobd63iFDMHp/wOn+jsmK6 F9Mb5z+MCYc6XDhqJ1R4xW09ZygoMsc5G/CvReDZalmWQzo= X-Google-Smtp-Source: ABdhPJwlWb5slHKskIt2QQkn34IOR+vLKFpniWfsamNlDY38HQe7LH3BhwM7mpB0f0tEZUeQ4dRM+mMB0SMKksAgpqg= X-Received: by 2002:a67:7247:: with SMTP id n68mr34449051vsc.6.1638780606703; Mon, 06 Dec 2021 00:50:06 -0800 (PST) MIME-Version: 1.0 References: <20211205224109.322152-1-f4bug@amsat.org> In-Reply-To: <20211205224109.322152-1-f4bug@amsat.org> From: Michael Rolnik Date: Mon, 6 Dec 2021 10:49:29 +0200 Message-ID: Subject: Re: [PATCH] hw/avr: Realize AVRCPU qdev object using qdev_realize() To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: multipart/alternative; boundary="000000000000ed6d3105d2765729" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::92a (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::92a; envelope-from=mrolnik@gmail.com; helo=mail-ua1-x92a.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000ed6d3105d2765729 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Rolnik On Mon, Dec 6, 2021 at 12:41 AM Philippe Mathieu-Daud=C3=A9 wrote: > TYPE_AVR_CPU inherits TYPE_CPU, which itself inherits TYPE_DEVICE. > TYPE_DEVICE instances are realized using qdev_realize(), we don't > need to access QOM internal values. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/avr/atmega.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/avr/atmega.c b/hw/avr/atmega.c > index 0608e2d475e..a34803e6427 100644 > --- a/hw/avr/atmega.c > +++ b/hw/avr/atmega.c > @@ -233,7 +233,7 @@ static void atmega_realize(DeviceState *dev, Error > **errp) > > /* CPU */ > object_initialize_child(OBJECT(dev), "cpu", &s->cpu, mc->cpu_type); > - object_property_set_bool(OBJECT(&s->cpu), "realized", true, > &error_abort); > + qdev_realize(DEVICE(&s->cpu), NULL, &error_abort); > cpudev =3D DEVICE(&s->cpu); > > /* SRAM */ > -- > 2.33.1 > > --=20 Best Regards, Michael Rolnik --000000000000ed6d3105d2765729 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Michael Rolnik <mrolnik@gmail.com>

On Mon, Dec 6, 2021 at 12:41 AM Philipp= e Mathieu-Daud=C3=A9 <f4bug@amsat.org= > wrote:
= TYPE_AVR_CPU inherits TYPE_CPU, which itself inherits TYPE_DEVICE.
TYPE_DEVICE instances are realized using qdev_realize(), we don't
need to access QOM internal values.

Signed-off-by: Philippe Mathieu-Daud=C3=A9 <f4bug@amsat.org>
---
=C2=A0hw/avr/atmega.c | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/avr/atmega.c b/hw/avr/atmega.c
index 0608e2d475e..a34803e6427 100644
--- a/hw/avr/atmega.c
+++ b/hw/avr/atmega.c
@@ -233,7 +233,7 @@ static void atmega_realize(DeviceState *dev, Error **er= rp)

=C2=A0 =C2=A0 =C2=A0/* CPU */
=C2=A0 =C2=A0 =C2=A0object_initialize_child(OBJECT(dev), "cpu", &= amp;s->cpu, mc->cpu_type);
-=C2=A0 =C2=A0 object_property_set_bool(OBJECT(&s->cpu), "reali= zed", true, &error_abort);
+=C2=A0 =C2=A0 qdev_realize(DEVICE(&s->cpu), NULL, &error_abort)= ;
=C2=A0 =C2=A0 =C2=A0cpudev =3D DEVICE(&s->cpu);

=C2=A0 =C2=A0 =C2=A0/* SRAM */
--
2.33.1



--
Best Regards,
Michael Rolnik
--000000000000ed6d3105d2765729--