From: Willian Rampazzo <wrampazz@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 2/2] tests/Makefile: add TESTFILES option to make check-acceptance
Date: Thu, 23 Sep 2021 08:54:56 -0300 [thread overview]
Message-ID: <CAKJDGDYAoh7YaJPkQRSQ8g1YCaW98Chz2bVwNaezP54ikA-tRA@mail.gmail.com> (raw)
In-Reply-To: <YUxMAJiCW+llt5ml@redhat.com>
On Thu, Sep 23, 2021 at 6:42 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Thu, Sep 23, 2021 at 11:34:18AM +0200, Philippe Mathieu-Daudé wrote:
> > On 9/22/21 21:46, Willian Rampazzo wrote:
> > > On Wed, Sep 22, 2021 at 4:08 PM Philippe Mathieu-Daudé
> > > <philmd@redhat.com> wrote:
> > > >
> > > > On 9/22/21 21:03, Willian Rampazzo wrote:
> > > > > Add the possibility of running all the tests from a single file, or
> > > > > multiple files, running a single test within a file or multiple tests
> > > > > within multiple files using `make check-acceptance` and the TESTFILES
> > > > > environment variable.
> > > > >
> > > > > Signed-off-by: Willian Rampazzo <willianr@redhat.com>
> > > > > ---
> > > > > docs/devel/testing.rst | 27 +++++++++++++++++++++++++++
> > > > > tests/Makefile.include | 5 ++++-
> > > > > 2 files changed, 31 insertions(+), 1 deletion(-)
> > > >
> > > > > diff --git a/tests/Makefile.include b/tests/Makefile.include
> > > > > index 6e16c05f10..82d7ef7a20 100644
> > > > > --- a/tests/Makefile.include
> > > > > +++ b/tests/Makefile.include
> > > > > @@ -88,6 +88,9 @@ clean-tcg: $(CLEAN_TCG_TARGET_RULES)
> > > > > TESTS_VENV_DIR=$(BUILD_DIR)/tests/venv
> > > > > TESTS_VENV_REQ=$(SRC_PATH)/tests/requirements.txt
> > > > > TESTS_RESULTS_DIR=$(BUILD_DIR)/tests/results
> > > > > +ifndef TESTFILES
> > > > > + TESTFILES=tests/acceptance
> > > > > +endif
> > > > > # Controls the output generated by Avocado when running tests.
> > > > > # Any number of command separated loggers are accepted. For more
> > > > > # information please refer to "avocado --help".
> > > > > @@ -130,7 +133,7 @@ check-acceptance: check-venv $(TESTS_RESULTS_DIR) get-vm-images
> > > > > --show=$(AVOCADO_SHOW) run --job-results-dir=$(TESTS_RESULTS_DIR) \
> > > > > --filter-by-tags-include-empty --filter-by-tags-include-empty-key \
> > > > > $(AVOCADO_TAGS) \
> > > > > - $(if $(GITLAB_CI),,--failfast) tests/acceptance, \
> > > > > + $(if $(GITLAB_CI),,--failfast) $(TESTFILES), \
> > > >
> > > > Since this is Avocado specific, maybe call the variable
> > > > AVOCADO_TESTFILES (similar to AVOCADO_TAGS)?
> > >
> > > I don't see a problem with changing that to AVOCADO_TESTFILES. I was
> > > trying to make things shorter and easy to remember. If the too-long
> > > variable name is not a problem, I can change that.
> >
> > This is the generic tests/Makefile, so $TESTFILES might be confusing,
> > which is why I prefer the explicit AVOCADO_ prefix (AVOCADO_SHOW,
> > AVOCADO_TAGS).
>
> IIUC, this is not actually just test files - it is test files plus the
> test names. So better just $(AVOCADO_TESTS)
>
Ack. I'll send another version soon.
>
> Regards,
> Daniel
> --
> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
>
prev parent reply other threads:[~2021-09-23 11:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 19:03 [PATCH 0/2] docs/devel/testing: improvements on make check-acceptance Willian Rampazzo
2021-09-22 19:03 ` [PATCH 1/2] docs/devel/testing: add instruction to run a single acceptance test Willian Rampazzo
2021-09-23 8:27 ` Daniel P. Berrangé
2021-09-23 11:53 ` Willian Rampazzo
2021-09-22 19:03 ` [PATCH 2/2] tests/Makefile: add TESTFILES option to make check-acceptance Willian Rampazzo
2021-09-22 19:08 ` Philippe Mathieu-Daudé
2021-09-22 19:46 ` Willian Rampazzo
2021-09-23 9:34 ` Philippe Mathieu-Daudé
2021-09-23 9:42 ` Daniel P. Berrangé
2021-09-23 9:53 ` Philippe Mathieu-Daudé
2021-09-23 11:54 ` Willian Rampazzo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKJDGDYAoh7YaJPkQRSQ8g1YCaW98Chz2bVwNaezP54ikA-tRA@mail.gmail.com \
--to=wrampazz@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).