From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ACFFC433DB for ; Mon, 29 Mar 2021 15:42:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F25786192F for ; Mon, 29 Mar 2021 15:42:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F25786192F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQu1k-0002oz-Up for qemu-devel@archiver.kernel.org; Mon, 29 Mar 2021 11:42:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQu0L-00021K-K7 for qemu-devel@nongnu.org; Mon, 29 Mar 2021 11:40:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:59535) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQu03-0005oN-8S for qemu-devel@nongnu.org; Mon, 29 Mar 2021 11:40:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617032414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7DZ1q2OCSzknA0FHL2Rr9UMhXqu/FUzqN36ywkA1x/8=; b=Q3X45j9rK4o0l9HiypUqfDPfEmNNQxL3ZM0gsYVSjhePRE/OkxPevtd82f+u1h1lrR6gwp i1nOKXQL8R3QQuzoSL3Uhw+8/VK2SnqfRE1ad+DezkH9uBuiouj0CCfXqKt2BGw7btwuza +XOdOjnJpEjucrYV5FEthZ9nRBEtpa4= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-506-VZScTVKGNfm758Ye5w1kJQ-1; Mon, 29 Mar 2021 11:40:11 -0400 X-MC-Unique: VZScTVKGNfm758Ye5w1kJQ-1 Received: by mail-ua1-f71.google.com with SMTP id r12so3861739uao.12 for ; Mon, 29 Mar 2021 08:40:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7DZ1q2OCSzknA0FHL2Rr9UMhXqu/FUzqN36ywkA1x/8=; b=M71iDHhxjSLKcpvVrL0WYt+pA4sy5xb8wg8NguRcXF5Dth13SLG70f6kV5bwRXkXxj i1PvBvgq62TxddVpD/MkXaE8T1LN3MPxxQKF7pRzRfp7PrIH+k81dKJq/PkfmceOlh/m U5vBa1n+5kPA3ou2yOzobMR6asz3ilOHWHBoadwqttyRyuCnWT8xgtGsUZ7P0DPJ/vNw I3R2JYpqhiLWwxnATS8wXFgvEL4CVnYksuNWx2yWXf750UtNEOu2K9xun+oWBFR2+dme a7M9gC6OdNIZHmXD9XzTS3L1QQ4QLDMThTsLyTE5xCDKA2Uzv5Ndi8m2q/uMzcheDOIu F3Hg== X-Gm-Message-State: AOAM533Njmz9A4WmniVd6b+gD6wXVhsOqg4OpS9uFceS5pQ5y0fSyJAW eZciGWJGVhziK0pEqawgLbBXlMQGoWQ1zOJnS9kokpCGUezRRZcvBqCus1CGd0Jy0U8FAMq2Auj FUMSq9+mf+rjntW6LgR8VjQg3cjZoF54= X-Received: by 2002:a67:ed86:: with SMTP id d6mr14256044vsp.50.1617032411455; Mon, 29 Mar 2021 08:40:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9cXc1UNXNqZGu3GoRc2klkX3KmgiR1Jjb+G80bIfVmYdlW3Lac5f0SlaUH772KIuxERJwLNvGLl8Z4iC7jDo= X-Received: by 2002:a67:ed86:: with SMTP id d6mr14256028vsp.50.1617032411276; Mon, 29 Mar 2021 08:40:11 -0700 (PDT) MIME-Version: 1.0 References: <20210329132632.68901-1-mreitz@redhat.com> <20210329132632.68901-4-mreitz@redhat.com> In-Reply-To: <20210329132632.68901-4-mreitz@redhat.com> From: Willian Rampazzo Date: Mon, 29 Mar 2021 12:39:45 -0300 Message-ID: Subject: Re: [PATCH 3/4] migrate-bitmaps-test: Fix pylint warnings To: Max Reitz Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wrampazz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=63.128.21.124; envelope-from=wrampazz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-devel , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Mar 29, 2021 at 10:28 AM Max Reitz wrote: > > There are a couple of things pylint takes issue with: > - The "time" import is unused > - The import order (iotests should come last) > - get_bitmap_hash() doesn't use @self and so should be a function > - Semicolons at the end of some lines > - Parentheses after "if" > - Some lines are too long (80 characters instead of 79) > - inject_test_case()'s @name parameter shadows a top-level @name > variable > - "lambda self: mc(self)" is equivalent to just "mc" > - Always put two empty lines after a function > - f'exec: cat > /dev/null' does not need to be an f-string > > Fix them. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/tests/migrate-bitmaps-test | 38 ++++++++++--------- > 1 file changed, 20 insertions(+), 18 deletions(-) > Reviewed-by: Willian Rampazzo