From: Willian Rampazzo <wrampazz@redhat.com>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>
Cc: Philippe Mathieu Daude <philmd@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Cleber Rosa Junior <crosa@redhat.com>
Subject: Re: [PATCH 4/7] tests/acceptance: Sun4uMachine: Remove dependency to LinuxKernelTest
Date: Mon, 24 May 2021 15:24:10 -0300 [thread overview]
Message-ID: <CAKJDGDZDLWZk=pB8N--oXV7FUvwNhiKVkUWqmzpG26qM3mV6Rw@mail.gmail.com> (raw)
In-Reply-To: <20210503224326.206208-5-wainersm@redhat.com>
On Mon, May 3, 2021 at 7:44 PM Wainer dos Santos Moschetta
<wainersm@redhat.com> wrote:
>
> The Sun4uMachine class inherit from LinuxKernelTest to effectively only use
> the KERNEL_COMMON_COMMAND_LINE attribute. This change remove that unneeded
> dependency, making Sun4uMachine self-content.
>
> I took the occasion to delint the code: the unused os import was
> removed, imports were reordered, and the module has a docstring now.
>
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> ---
> tests/acceptance/machine_sparc64_sun4u.py | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
next prev parent reply other threads:[~2021-05-24 18:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 22:43 [PATCH 0/7] tests/acceptance: Introducing the ConsoleMixIn Wainer dos Santos Moschetta
2021-05-03 22:43 ` [PATCH 1/7] tests/acceptance: Introduce the ConsoleMixIn class Wainer dos Santos Moschetta
2021-05-24 18:14 ` Willian Rampazzo
2021-05-03 22:43 ` [PATCH 2/7] tests/acceptance: Move exec_command to ConsoleMixIn Wainer dos Santos Moschetta
2021-05-24 18:16 ` Willian Rampazzo
2021-05-03 22:43 ` [PATCH 3/7] tests/acceptance: Move exec_command_and_wait_for_pattern " Wainer dos Santos Moschetta
2021-05-24 18:21 ` Willian Rampazzo
2021-05-03 22:43 ` [PATCH 4/7] tests/acceptance: Sun4uMachine: Remove dependency to LinuxKernelTest Wainer dos Santos Moschetta
2021-05-04 16:01 ` Philippe Mathieu-Daudé
2021-05-24 18:30 ` Willian Rampazzo
2021-05-24 18:54 ` Willian Rampazzo
2021-05-24 18:24 ` Willian Rampazzo [this message]
2021-05-03 22:43 ` [PATCH 5/7] tests/acceptance: replay_kernel: Remove unused wait_for_console_pattern Wainer dos Santos Moschetta
2021-05-24 18:32 ` Willian Rampazzo
2021-05-03 22:43 ` [PATCH 6/7] tests/acceptance: Move wait_for_console_pattern to ConsoleMixIn Wainer dos Santos Moschetta
2021-05-24 20:52 ` Willian Rampazzo
2021-05-03 22:43 ` [PATCH 7/7] tests/acceptance: Move _console_interaction " Wainer dos Santos Moschetta
2021-05-24 18:37 ` Willian Rampazzo
2021-05-24 20:58 ` [PATCH 0/7] tests/acceptance: Introducing the ConsoleMixIn Willian Rampazzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKJDGDZDLWZk=pB8N--oXV7FUvwNhiKVkUWqmzpG26qM3mV6Rw@mail.gmail.com' \
--to=wrampazz@redhat.com \
--cc=crosa@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).