From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E08C2B9F4 for ; Fri, 25 Jun 2021 20:52:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF04161973 for ; Fri, 25 Jun 2021 20:52:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF04161973 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwsog-0001gj-V6 for qemu-devel@archiver.kernel.org; Fri, 25 Jun 2021 16:52:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwsnk-0000dP-QK for qemu-devel@nongnu.org; Fri, 25 Jun 2021 16:51:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48089) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwsni-0000XP-Ea for qemu-devel@nongnu.org; Fri, 25 Jun 2021 16:51:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624654305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IMLUARK+F1ONepPDaHKUhMiMqXE6+v6gv5xylvK15+o=; b=hSCLsxQy7Zzy0K1UfCtpyPrwuj9d8eyQSIKR/SwKfckPKNX5hMhQ61mszcSlwmgmmxTcoj 1xtsraHxKoFpSRPtHwvlXhuPO4Keoaar/sjXEAQ+4xTwNWihIZ5nfBTzyZ27s+EVbEF5Vx IEnH6qujz6HB1KUDgzsML0UIolRalZE= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-142-aKW62zMXNV6ZaKWCdVbKzQ-1; Fri, 25 Jun 2021 16:51:44 -0400 X-MC-Unique: aKW62zMXNV6ZaKWCdVbKzQ-1 Received: by mail-vk1-f199.google.com with SMTP id e7-20020a1f1e070000b02901ffbfb6bcd1so3475807vke.22 for ; Fri, 25 Jun 2021 13:51:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=IMLUARK+F1ONepPDaHKUhMiMqXE6+v6gv5xylvK15+o=; b=UNgStO39IDOI2/F49Eo2HkliBOlTtf709UMSxme21tx15WhrbmzkejZ0ZhrMHRFi3L qFH0OnJT6LJxcEtIlC++aiFxkOhWXhMxVDkn/eDEx+9c98YRshKCk0U6ZZZw1Say3csE 1IYo1n7QBv15LZaojTr1gMS06Eyo6jis5u4SweKWbzAPVnijtJafg0YKRiPB/O2JuUFs x8fyX4eXyRmg+a6oNCaZkRO/ACmdzHKO/OFSAw9BpZKwPpbHY6+Zi2P4GOumZ9Af42RN dUsDoQ1IavZEk1Y3KKKAkSiDceUUa1J+DXRmOVwuJsWfFr05X/9rhUHwUkoKRbcbprdb a7uw== X-Gm-Message-State: AOAM531BQf2HowgKuZGRAv1/KXuDENEgQwBJmb0BIA0pAIP57Zr/tTbJ 4v0aAfzvueONzg5J4ZLowEqVQKMXDsobOL4F9/fWjOK16tDjgEw03tKfv+/29t/RkaqZYO8H0CC RH08YpdgPE8auB+Q+yoN6B96r79681H8= X-Received: by 2002:a1f:ae4e:: with SMTP id x75mr10269276vke.2.1624654303546; Fri, 25 Jun 2021 13:51:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJwFt/eiWD1Uq+F2xKshtmfhecnL2jWiat5KbZlEh75wrcPziojBJmGR8dWpDntRuBtSR8yi5g7hgQNmxvRwk= X-Received: by 2002:a1f:ae4e:: with SMTP id x75mr10269259vke.2.1624654303268; Fri, 25 Jun 2021 13:51:43 -0700 (PDT) MIME-Version: 1.0 References: <20210623142245.307776-1-berrange@redhat.com> <20210623142245.307776-6-berrange@redhat.com> In-Reply-To: <20210623142245.307776-6-berrange@redhat.com> From: Willian Rampazzo Date: Fri, 25 Jun 2021 17:51:17 -0300 Message-ID: Subject: Re: [PATCH v4 05/22] tests/docker: remove FEATURES env var from templates To: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wrampazz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=wrampazz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.362, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Thomas Huth , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , qemu-devel , Wainer dos Santos Moschetta , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , =?UTF-8?B?QWxleCBCZW5uw6ll?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jun 23, 2021 at 11:23 AM Daniel P. Berrang=C3=A9 wrote: > > In preparation for switching to auto-generated dockerfiles, remove the > FEATURES env variable. The equivalent functionality can be achieved in > most cases by just looking for existance of a binary. s/existance/existence/ > > The cases which don't correspond to binaries are simply dropped because > configure/meson will probe for any requested feature anyway. > > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Signed-off-by: Daniel P. Berrang=C3=A9 > --- > tests/docker/common.rc | 19 ++++++++++++++----- > tests/docker/dockerfiles/debian10.docker | 2 -- > .../dockerfiles/fedora-win32-cross.docker | 1 - > .../dockerfiles/fedora-win64-cross.docker | 1 - > tests/docker/dockerfiles/fedora.docker | 1 - > tests/docker/dockerfiles/ubuntu.docker | 1 - > tests/docker/dockerfiles/ubuntu1804.docker | 1 - > tests/docker/dockerfiles/ubuntu2004.docker | 1 - > tests/docker/run | 3 --- > tests/docker/test-clang | 2 +- > tests/docker/test-debug | 2 +- > tests/docker/test-mingw | 3 ++- > tests/docker/test-misc | 2 +- > tests/docker/test-tsan | 2 +- > 14 files changed, 20 insertions(+), 21 deletions(-) > Reviewed-by: Willian Rampazzo