From: Willian Rampazzo <wrampazz@redhat.com>
To: Cleber Rosa <crosa@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Willian Rampazzo" <willianr@redhat.com>,
"Eric Auger" <eauger@redhat.com>, "John Snow" <jsnow@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Beraldo Leal" <bleal@redhat.com>
Subject: Re: [PATCH v2 02/10] tests/acceptance/virtiofs_submounts.py: evaluate string not length
Date: Wed, 24 Mar 2021 16:54:22 -0300 [thread overview]
Message-ID: <CAKJDGDbXnuPUm8s1dgDi4gTJki7kFM_w_qf-j5-T9Vz4OdzLww@mail.gmail.com> (raw)
In-Reply-To: <20210323221539.3532660-3-crosa@redhat.com>
On Tue, Mar 23, 2021 at 7:15 PM Cleber Rosa <crosa@redhat.com> wrote:
>
> If the vmlinuz variable is set to anything that evaluates to True,
> then the respective arguments should be set. If the variable contains
> an empty string, than it will evaluate to False, and the extra
> arguments will not be set.
>
> This keeps the same logic, but improves readability a bit.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> Reviewed-by: Beraldo Leal <bleal@redhat.com>
> ---
> tests/acceptance/virtiofs_submounts.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
next prev parent reply other threads:[~2021-03-24 19:56 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 22:15 [PATCH v2 00/10] Acceptance Test: introduce base class for Linux based tests Cleber Rosa
2021-03-23 22:15 ` [PATCH v2 01/10] tests/acceptance/virtiofs_submounts.py: add missing accel tag Cleber Rosa
2021-03-24 8:45 ` Auger Eric
2021-03-23 22:15 ` [PATCH v2 02/10] tests/acceptance/virtiofs_submounts.py: evaluate string not length Cleber Rosa
2021-03-24 8:45 ` Auger Eric
2021-03-24 19:54 ` Willian Rampazzo [this message]
2021-03-23 22:15 ` [PATCH v2 03/10] Python: add utility function for retrieving port redirection Cleber Rosa
2021-03-24 8:58 ` Auger Eric
2021-03-24 20:35 ` Willian Rampazzo
2021-03-24 21:58 ` Cleber Rosa
2021-03-25 18:10 ` John Snow
2021-04-12 2:09 ` Cleber Rosa
2021-05-13 19:16 ` John Snow
2021-03-23 22:15 ` [PATCH v2 04/10] Acceptance Tests: move useful ssh methods to base class Cleber Rosa
2021-03-24 9:07 ` Auger Eric
2021-03-24 22:23 ` Cleber Rosa
2021-03-25 12:50 ` Auger Eric
2021-03-25 17:43 ` Wainer dos Santos Moschetta
2021-04-12 2:18 ` Cleber Rosa
2021-03-23 22:15 ` [PATCH v2 05/10] Acceptance Tests: add port redirection for ssh by default Cleber Rosa
2021-03-24 8:30 ` Marc-André Lureau
2021-03-24 22:28 ` Cleber Rosa
2021-03-24 9:10 ` Auger Eric
2021-03-24 22:27 ` Cleber Rosa
2021-03-25 17:57 ` Wainer dos Santos Moschetta
2021-04-12 2:47 ` Cleber Rosa
2021-03-24 10:36 ` Auger Eric
2021-03-24 22:40 ` Cleber Rosa
2021-03-24 20:39 ` Willian Rampazzo
2021-03-23 22:15 ` [PATCH v2 06/10] Acceptance Tests: make username/password configurable Cleber Rosa
2021-03-24 8:31 ` Marc-André Lureau
2021-03-24 9:18 ` Auger Eric
2021-03-24 20:43 ` Willian Rampazzo
2021-03-23 22:15 ` [PATCH v2 07/10] Acceptance Tests: set up SSH connection by default after boot for LinuxTest Cleber Rosa
2021-03-24 8:33 ` Marc-André Lureau
2021-03-24 9:22 ` Auger Eric
2021-03-24 22:45 ` Cleber Rosa
2021-03-24 20:45 ` Willian Rampazzo
2021-03-25 14:31 ` Wainer dos Santos Moschetta
2021-03-25 14:53 ` Wainer dos Santos Moschetta
2021-03-23 22:15 ` [PATCH v2 08/10] tests/acceptance/virtiofs_submounts.py: remove launch_vm() Cleber Rosa
2021-03-24 8:34 ` Marc-André Lureau
2021-03-24 9:24 ` Auger Eric
2021-03-24 20:46 ` Willian Rampazzo
2021-03-23 22:15 ` [PATCH v2 09/10] Acceptance Tests: add basic documentation on LinuxTest base class Cleber Rosa
2021-03-24 9:25 ` Auger Eric
2021-03-25 18:14 ` Wainer dos Santos Moschetta
2021-04-12 2:59 ` Cleber Rosa
2021-03-23 22:15 ` [PATCH v2 10/10] Acceptance Tests: introduce CPU hotplug test Cleber Rosa
2021-03-24 9:29 ` Auger Eric
2021-03-25 19:45 ` [PATCH v2 00/10] Acceptance Test: introduce base class for Linux based tests Wainer dos Santos Moschetta
2021-03-26 8:06 ` Auger Eric
2021-04-12 3:22 ` Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKJDGDbXnuPUm8s1dgDi4gTJki7kFM_w_qf-j5-T9Vz4OdzLww@mail.gmail.com \
--to=wrampazz@redhat.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=eauger@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).