From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2EF9C433DB for ; Wed, 13 Jan 2021 18:16:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F4FC23120 for ; Wed, 13 Jan 2021 18:16:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F4FC23120 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzkhJ-0000rO-AG for qemu-devel@archiver.kernel.org; Wed, 13 Jan 2021 13:16:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzkZD-0002zH-Am; Wed, 13 Jan 2021 13:08:23 -0500 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]:34020) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzkZA-0004Uv-L1; Wed, 13 Jan 2021 13:08:22 -0500 Received: by mail-io1-xd2a.google.com with SMTP id u17so6031961iow.1; Wed, 13 Jan 2021 10:08:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wtdFSjiQ2zg0qJQK7HrD7NYOhHYVO3DtRlu5GEVBbd4=; b=vgR6tuKhzxLqUwUR4hse5LbNfsvjTXeQv0xTyXflKI5eiwEnudOGVHBkfRSV/5PSsT D/a2x2DZ4S/LBIjIeVBmWTRmq4nZ+hdJBEkuHLjABS1haD7MjOcwdI8+24o8Jsb92roT dUz9OoeLrdOgqiCWKJoPdPwACzCgBQoKy28hZ0vKLSJ7Hj823RIP8GXoU/dzrYmEw4jh pQpk2+X7mQQlcdl8UkaLLz7Ur7k718KFTs0BhBQg4t4jysZworSG12JxL0qu+0GTAqsI /XlCM3Ac3r/J77XljPcMp5TrCHd3TIqoLhirbzgxHC/3zkGTSb+RYWV6v+8tmiXGLnnC iL/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wtdFSjiQ2zg0qJQK7HrD7NYOhHYVO3DtRlu5GEVBbd4=; b=MmSerYko/9DY0jG457nut0q++3YOmC347CofRxXfsk+VhUQIioRv/wCo+gkMAJaBRU a3KafQnrovyBv5ySuJwtTgvBZUlew8cHmPNR7REZRZzLWnBcb1CYRX+qy/PGjDn33maW 5dCYhWSvfZK8pV0tY7ox6h3+wIA5M9FdrZUOSYPKa1Tyfki8xtoMbRxuDP8T/LnKZqtP 689Dx9q7cLM9LMEdWlrOZkrWLr1ExpzDDaddhSjTi9AALq0VSxPFPQyyUknX0o7YlJhX vZpKm8/hsibNV2ncTxCn8GqmlqYWLIFD9yY3Pq6fCMAnsIWJ3hTTe5QnpLdVk36BmoSI dRHg== X-Gm-Message-State: AOAM5332jMQK0IIS6XWIZAPEIZNB5AiMe7xKJuTL/V6WMvJPNM0C/xq3 HlNeE9467VYlwAXfKX0XaFK4VWkT7IKk+bmAn0M= X-Google-Smtp-Source: ABdhPJxXUXCI+xBnZxJP+sCjYRYWrpWSQcEAKXw9N/29Gz8ghfBw9txaEkUmy5Su22oi27eP5f7uffMGTmRDgTv2unw= X-Received: by 2002:a02:5148:: with SMTP id s69mr3586856jaa.8.1610561298902; Wed, 13 Jan 2021 10:08:18 -0800 (PST) MIME-Version: 1.0 References: <20201231113010.27108-1-bmeng.cn@gmail.com> <20201231113010.27108-15-bmeng.cn@gmail.com> In-Reply-To: <20201231113010.27108-15-bmeng.cn@gmail.com> From: Alistair Francis Date: Wed, 13 Jan 2021 10:07:52 -0800 Message-ID: Subject: Re: [PATCH 14/22] hw/sd: ssi-sd: Support single block write To: Bin Meng Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::d2a; envelope-from=alistair23@gmail.com; helo=mail-io1-xd2a.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:RISC-V" , Qemu-block , Bin Meng , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , "qemu-devel@nongnu.org Developers" , Alistair Francis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Dec 31, 2020 at 3:43 AM Bin Meng wrote: > > From: Bin Meng > > Add 2 more states for the block write operation. The SPI host needs > to send a data start tocken to start the transfer, and the data block > written to the card will be acknowledged by a data response tocken. > > Signed-off-by: Bin Meng Acked-by: Alistair Francis Alistair > --- > > hw/sd/ssi-sd.c | 37 ++++++++++++++++++++++++++++++++++++- > 1 file changed, 36 insertions(+), 1 deletion(-) > > diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c > index 8eb48550cf..21a96e91f0 100644 > --- a/hw/sd/ssi-sd.c > +++ b/hw/sd/ssi-sd.c > @@ -42,6 +42,8 @@ typedef enum { > SSI_SD_DATA_START, > SSI_SD_DATA_READ, > SSI_SD_DATA_CRC16, > + SSI_SD_DATA_WRITE, > + SSI_SD_SKIP_CRC16, > } ssi_sd_mode; > > struct ssi_sd_state { > @@ -52,6 +54,7 @@ struct ssi_sd_state { > uint8_t response[5]; > uint16_t crc16; > int32_t read_bytes; > + int32_t write_bytes; > int32_t arglen; > int32_t response_pos; > int32_t stopping; > @@ -90,6 +93,9 @@ OBJECT_DECLARE_SIMPLE_TYPE(ssi_sd_state, SSI_SD) > /* dummy value - don't care */ > #define SSI_DUMMY 0xff > > +/* data accepted */ > +#define DATA_RESPONSE_ACCEPTED 0x05 > + > static uint32_t ssi_sd_transfer(SSIPeripheral *dev, uint32_t val) > { > ssi_sd_state *s = SSI_SD(dev); > @@ -103,10 +109,17 @@ static uint32_t ssi_sd_transfer(SSIPeripheral *dev, uint32_t val) > > switch (s->mode) { > case SSI_SD_CMD: > - if (val == SSI_DUMMY) { > + switch (val) { > + case SSI_DUMMY: > DPRINTF("NULL command\n"); > return SSI_DUMMY; > + break; > + case SSI_TOKEN_SINGLE: > + DPRINTF("Start write block\n"); > + s->mode = SSI_SD_DATA_WRITE; > + return SSI_DUMMY; > } > + > s->cmd = val & 0x3f; > s->mode = SSI_SD_CMDARG; > s->arglen = 0; > @@ -235,6 +248,27 @@ static uint32_t ssi_sd_transfer(SSIPeripheral *dev, uint32_t val) > s->response_pos = 0; > } > return val; > + case SSI_SD_DATA_WRITE: > + sdbus_write_byte(&s->sdbus, val); > + s->write_bytes++; > + if (!sdbus_receive_ready(&s->sdbus) || s->write_bytes == 512) { > + DPRINTF("Data write end\n"); > + s->mode = SSI_SD_SKIP_CRC16; > + s->response_pos = 0; > + } > + return val; > + case SSI_SD_SKIP_CRC16: > + /* we don't verify the crc16 */ > + s->response_pos++; > + if (s->response_pos == 2) { > + DPRINTF("CRC16 receive end\n"); > + s->mode = SSI_SD_RESPONSE; > + s->write_bytes = 0; > + s->arglen = 1; > + s->response[0] = DATA_RESPONSE_ACCEPTED; > + s->response_pos = 0; > + } > + return SSI_DUMMY; > } > /* Should never happen. */ > return SSI_DUMMY; > @@ -325,6 +359,7 @@ static void ssi_sd_reset(DeviceState *dev) > memset(s->response, 0, sizeof(s->response)); > s->crc16 = 0; > s->read_bytes = 0; > + s->write_bytes = 0; > s->arglen = 0; > s->response_pos = 0; > s->stopping = 0; > -- > 2.25.1 > >